plugin_label missing in feedback when TFA setup is canceled

Created on 18 October 2024, 6 months ago

Problem/Motivation

In some cases the plugin_label is missing in the feedback message, so that "Setup of canceled." will be displayed.
This happens for example when I cancel the setup form (/user//security/tfa/tfa_totp) of the module.

Steps to reproduce

  1. Login as user that does not have TFA activated yet or has it deactivated at the moment
  2. Open TFA page (/user//security/tfa)
  3. Click "Set up application" link (/user//security/tfa/tfa_totp)
  4. Click "Cancel" button of the form

Then the "Setup of canceled." message appears.

Proposed resolution

We could just move the $storage['plugin_label'] = $plugin['label']; in the buildForm() function outside of the if statement instead in the else part where in some cases the label doesn't get set.

πŸ› Bug report
Status

Active

Version

1.9

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany lmoeni

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024