- Issue created by @lmoeni
- Merge request !94Issue#3481622: Move declaration of $storage['plugin_label'] outside of if statement to fix... → (Merged) created by lmoeni
- 🇺🇸United States cmlara
Needs work for real minor changes, otherwise looks good to me.
- 🇩🇪Germany lmoeni
Thanks for taking a look at it and for your suggestion. I changed it a little bit so now it should be ready for testing.
- 🇺🇸United States cmlara
Committed to dev.
Thank you for the report and the fix.
Setting needs port as the commit does not appear to cleanly cherry-pick to 2.x and we will want to get it there too.
- Issue was unassigned.
- Status changed to Downport
about 1 month ago 1:07pm 23 May 2025 - 🇬🇧United Kingdom aaron.ferris
aaron.ferris → made their first commit to this issue’s fork.
- Merge request !135Issue #3481622: port move declaration ofplugin_label outside of if statement to 2.x → (Open) created by aaron.ferris
- 🇬🇧United Kingdom aaron.ferris
Thanks for this patch, I just came across this issue on one of my projects. Ive raised an MR into 2.x.
- First commit to issue fork.
- 🇬🇧United Kingdom scott_euser
Came across this as well, resolved the phpstan issue. Thanks!
- 🇺🇸United States cmlara
Setting NR to remind me to look at this in the morning.
- 🇺🇸United States cmlara
In 8.x-1.x $plugin is populated early while in 2.x we populate $plugin inside of the IF statment.
This means that in the case of clicking cancel on the password prompt page the default text of "plugin" is being displaed rather than the plugin name as would occur on the 8.x-1.x branch.
Leaving as NR as I want to look into the background issues of why the initialization was moved and if it should be moved back allow the actual plugin name to be populated.
Either way this is already an improvement from the current mainline.