- Issue created by @lmoeni
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: I think the module needs (Kernel + JS?) tests to cover such cases correctly and ensure it won't break in the future?
Can you reproduce this issue?There are already some Kernel tests present: https://git.drupalcode.org/project/spamspan/-/blob/3.x/tests/src/Kernel/...
I guess we need a general concept for tests in this module to make it easy to test further cases like the one described here.
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Please check if this is a duplicate of https://www.drupal.org/project/spamspan/issues/3372537 🐛 Extra attributes of the a tag are rendered in the obfuscated format Fixed
Also testing for the
title
attribute on sth. like<a href="mailto:info@example.com" title="My link title on hover">info@example.com</a>
that should be preserved, is a good test to add. Standalone or as additional attribute to existing tests. title is common for links and important for SEO. That should work :) - 🇩🇪Germany Grevil
This should've been fixed through 🐛 Fix Email address being removed in the link text and fix every second link not being obfuscated Fixed ! Let's comment in / add another js test here, just to be sure.
- last update
over 1 year ago 28 pass - @grevil opened merge request.
- Status changed to Needs review
over 1 year ago 2:25pm 12 July 2023 - 🇩🇪Germany Grevil
Yep, everything works now! Added / Enabled remaining tests, please review!
- Issue was unassigned.
- last update
over 1 year ago 28 pass - last update
over 1 year ago 28 pass - Status changed to Fixed
over 1 year ago 2:32pm 12 July 2023 - 🇧🇪Belgium joevagyok
This issue was fixed by #3372583 🐛 Fix Email address being removed in the link text and fix every second link not being obfuscated Fixed . Forgot to mention and link them, sorry.
Automatically closed - issue fixed for 2 weeks with no activity.