- Issue created by @ultrabob
- @ultrabob opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:15pm 30 August 2023 - 🇯🇵Japan ultrabob Japan
I've added a merge request that makes the button text consistent, and updates the help text to reflect the button text.
- 🇯🇵Japan ultrabob Japan
It would be better if the button was one word to avoid visual inconsistency, but I think this is clearer to the user.
- 🇺🇸United States mikemccaffrey
I don't understand how the layout got messed up, and the flex isn't applying to the items to align the buttons to the right side, since it doesn't look like you specifically removed that in the PR.
If the button is going to be two words, it should be either uniformly breaking or non-breaking, so we should adjust the css so they are uniform.
The wording is still not perfect. If we can't figure out a really good solution to the name, we should probably make the button text configurable.
- 🇺🇸United States mikemccaffrey
Here is a patch to change the button back to "Move to", at least for the meantime, so everything matches (and the original client gets their preference.
- 🇯🇵Japan ultrabob Japan
I'm ok with this. It would be nice to offer a config pane for the module, because I think Move to will not mean a lot to people new to the module, but tailoring it to those already using it makes sense.