- Issue created by @vyasdhruv
- Merge request !4Issue #3419110: Bootstrap library compatibility issue fix. → (Merged) created by vyasdhruv
- Status changed to Needs review
11 months ago 6:07pm 4 February 2024 - Issue was unassigned.
- Status changed to RTBC
11 months ago 7:15am 5 February 2024 - 🇮🇳India Sandeep_k New Delhi
Hi @vyasdhruv, I've Tested MR- MR !4 mergeableon Drupal version- 9.5.12-dev, The patch was applied successfully and looks good to me.
Testing Steps:
- Install Drupal 9.5
- Install and set Bootstrap 5 as the site's default theme.
- Install the Bootstrap "External Link Pop-up" module.
- Add an External link field to a Content type & create a new node- (Add a random external URL).
- Go to the created node and click on the added external URL(s). The external link won't open.
- Download the shared patch & apply.
- Revisit the content node & view to reverify this.
Testing Results:
After applying the patch, the External Link Pop-up is showing now & the link is opening as well. RTBC++ - Status changed to Needs review
9 months ago 12:12pm 15 March 2024 - 🇺🇸United States chrissnyder Maryland
Has anyone tested this patch to make sure it still works for sites using Bootstrap 4? We should ensure it does not cause any regressions for those still using Bootstrap 4.
- Status changed to RTBC
9 months ago 9:58am 26 March 2024 Hi,
I have tested this change, following the below mentioned steps and the popup worked for me with Bootstrap 4 theme as well.
Steps:- Install Drupal 10.2.2
- Install Bootstrap4 theme and set as default.
- Install Bootstrap External Link Popup module.
- Add some dummy content - with external link(s).
- Access the node, and click on the link(s) to verify.
- Apply the patch.
- Access the node again. Click on the link(s) to reverify.
Result:
- The popup worked for me before applying the patch.
- It worked same after applying the patch as well. Popup opened, on click cancel - it closed and on click ok - it redirected.
Hi,
I have tested this change following the below mentioned steps and the popup worked for me with Bootstrap 4 theme as well.
Steps:- Install Drupal 10.2.2
- Install Bootstrap4 theme and set as default.
- Install Bootstrap External Link Popup module.
- Add some dummy content - with external link(s).
- Access the node, and click on the link(s) to verify.
- Apply the patch.
- Access the node again. Click on the link(s) to reverify.
Result:
- The popup worked for me before applying the patch.
- It worked same after applying the patch as well. Popup opened, on click cancel - it closed and on click ok - it redirected.
-
ChrisSnyder →
committed a3ebdc5f on 2.x authored by
vyasdhruv →
Issue #3419110: Bootstrap library compatibility issue fix.
-
ChrisSnyder →
committed a3ebdc5f on 2.x authored by
vyasdhruv →
- Status changed to Fixed
9 months ago 3:28am 12 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.