Contrib.social

Can't override configuration via settings.php

Open on Drupal.org →
Created on 4 January 2023, over 1 year ago
Updated 20 October 2023, 9 months ago

Problem/Motivation

Configuration can't be overridden via settings.php

<!--break-->

Steps to reproduce

Within settings.php add something like

$config['adobe_launch.settings']['target-adobe-launch-environment'] = EnvironmentDetector::isProduction() ? 'prod' : 'staging';

Proposed resolution

Within adobe_launch_preprocess_html() and adobe_launch_preprocess_page() use \Drupal::config() instead of \Drupal::configFactory()->getEditable(). See attached patch.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

2.1

Component

Code

Created by

🇺🇸United States j.cowher

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 9 months ago →
    🇺🇸United States ansonwhan

    Patch applied to 2.1.x dev branch; can use a second set of eyes to smoke test one more time before formally adding a new stable release.

  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇺🇸United States ansonwhan

    Since the patch has been applied to 2.1.x dev branch; can use a second set of eyes to smoke test one more time before formally adding a new stable release.
    Updating issue status to "Needs review"

  • Comment 9 months ago →
    🇺🇸United States ansonwhan

    Since the patch has been applied to 2.1.x dev branch; can use a second set of eyes to smoke test one more time before formally adding a new stable release.
    Updating issue status to "Needs review"

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024