Re-rolled the patch from #4 to apply to version 3.1.33.
Changing the status of this issue to "Reviewed & tested by the community" per the Issue Status Field → documentation.
Also confirming that #95 worked for me for 3.1 release.
As a note for others - you'll need to update your config_ignore.settings after applying the patch from #95.
Examples
- * (will ignore everything)
- ~webform.webform.contact (will force import for this configuration, even if ignored by a wildcard)
- user.mail:register_no_approval_required.body (will ignore the body of the no approval required email setting, but will not ignore other user.mail configuration.)
- language.*|* (will ignore all language collections)
- language.fr|* (will ignore all fr language collection)
- language.fr|field.field.* (will ignore all fr field translations)
- ~language.fr|field.field.media.file.field_media_file (will force import for certain field translation)
Re-rolling for 9.5.11. The system schema version gets updated to 1011 with the current patches which could mess things up when it comes time to upgrade to Drupal 10.
j.cowher → created an issue.
j.cowher → created an issue.
j.cowher → created an issue.
I am seeing the same issue in my project when ignoring the description key on fields. This is causing our builds to fail because we have a step that checks that configuration was imported correctly.
When running drush cim --no --diff I see something like the following:
diff --git a/tmp/drush_tmp_1679421962_6419f20a98484/field.field.node.article.space_term.yml b/tmp/drush_tmp_1679421964_6419f20c4a00d/field.field.node.article.space_term.yml
index a7e6af484..792564d13 100644
--- a/tmp/drush_tmp_1679421962_6419f20a98484/field.field.node.article.space_term.yml
+++ b/tmp/drush_tmp_1679421964_6419f20c4a00d/field.field.node.article.space_term.yml
@@ -10,7 +10,6 @@ field_name: space_term
entity_type: node
bundle: article
label: 'Space'
-description: 'Space'
required: false
translatable: false
default_value: { }
@@ -19,3 +18,4 @@ settings:
handler: 'default:taxonomy_term'
handler_settings: { }
field_type: entity_reference
+description: 'Space'
I agree that, ideally, when scrolling horizontally the sticky header should also scroll, but what makes this difficult to implement is that when the header becomes sticky it becomes detached from the table (hence the stickiness). The only way I can think to resolve that is with some custom Javascript that binds to the horizontal scrolling on the table wrapper and updates the scroll position or x position of the sticky header - something I currently do not have time to help with, but maybe the maintainer of Gin has some ideas?
I was able to get the sticky header hiding/showing correctly when the table overflows on the horizontal axis. The underlying reason for this issue is that the IntersectionObserver API examines both the x and y axes and when the table is too wide to fit within the viewport it, technically, intersects with the right edge of the viewport which causes the sticky header to display.
We can fix this by observing the first
The patch from #13 partially worked. It worked when scrolling down, but failed to remove the --is-sticky class when scrolling back up. Uploading a patch that worked for me. The key for me was updating the logic to check for e.intersectionRatio === 0 instead of e.intersectionRatio < 1.
I am also experiencing this with a core.entity_view_display.* config file. I am on Drupal 9.5.3.
Original components:
57de20b1-6a3b-4491-ba6d-7d4ce5dfa3c0:
uuid: 57de20b1-6a3b-4491-ba6d-7d4ce5dfa3c0
region: content
configuration:
id: 'field_block:media:ceros:field_media_ceros'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: ceros_embed
label: hidden
settings: { }
third_party_settings:
fences:
fences_field_tag: div
fences_field_classes: ''
fences_field_item_tag: div
fences_field_item_classes: ''
fences_label_tag: div
fences_label_classes: ''
field_display_label_override:
label_value: ''
ds:
ft:
id: default
settings:
lb: ''
lb-col: false
classes: { }
weight: 0
additional: { }
f4978e4b-d0fe-4629-b332-7b5e76085334:
uuid: f4978e4b-d0fe-4629-b332-7b5e76085334
region: content
configuration:
id: 'field_block:media:ceros:field_media_section'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 1
additional: { }
89dfd115-9472-4185-9898-a72cc26ed7f0:
uuid: 89dfd115-9472-4185-9898-a72cc26ed7f0
region: content
configuration:
id: 'field_block:media:ceros:field_segment'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 2
additional: { }
5b8a2898-1eac-4756-bf29-286741c47cdb:
uuid: 5b8a2898-1eac-4756-bf29-286741c47cdb
region: content
configuration:
id: 'field_block:media:ceros:field_media_audience'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 3
additional: { }
third_party_settings: { }
After export:
57de20b1-6a3b-4491-ba6d-7d4ce5dfa3c0:
uuid: 57de20b1-6a3b-4491-ba6d-7d4ce5dfa3c0
region: content
configuration:
id: 'field_block:media:ceros:field_media_ceros'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: ceros_embed
label: hidden
settings: { }
third_party_settings:
fences:
fences_field_tag: div
fences_field_classes: ''
fences_field_item_tag: div
fences_field_item_classes: ''
fences_label_tag: div
fences_label_classes: ''
field_display_label_override:
label_value: ''
ds:
ft:
id: default
settings:
lb: ''
lb-col: false
classes: { }
weight: 0
additional: { }
f4978e4b-d0fe-4629-b332-7b5e76085334:
uuid: f4978e4b-d0fe-4629-b332-7b5e76085334
region: content
configuration:
id: 'field_block:media:ceros:field_media_section'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 1
additional: { }
89dfd115-9472-4185-9898-a72cc26ed7f0:
uuid: 89dfd115-9472-4185-9898-a72cc26ed7f0
region: content
configuration:
id: 'field_block:media:ceros:field_segment'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 2
additional: { }
5b8a2898-1eac-4756-bf29-286741c47cdb:
uuid: 5b8a2898-1eac-4756-bf29-286741c47cdb
region: content
configuration:
id: 'field_block:media:ceros:field_media_audience'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 3
additional: { }
third_party_settings: { }
b5b288aa-f620-4057-a9cb-7cc15d7353fa:
uuid: b5b288aa-f620-4057-a9cb-7cc15d7353fa
region: content
configuration:
id: 'field_block:media:ceros:field_media_ceros'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: ceros_embed
label: hidden
settings: { }
third_party_settings:
fences:
fences_field_tag: div
fences_field_classes: ''
fences_field_item_tag: div
fences_field_item_classes: ''
fences_label_tag: div
fences_label_classes: ''
field_display_label_override:
label_value: ''
ds:
ft:
id: default
settings:
lb: ''
lb-col: false
classes: { }
weight: 4
additional: { }
20cf119d-161a-49bb-86af-4e62f1068166:
uuid: 20cf119d-161a-49bb-86af-4e62f1068166
region: content
configuration:
id: 'field_block:media:ceros:field_media_section'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 5
additional: { }
7574088f-dc33-4837-b4ba-94b51d1f1184:
uuid: 7574088f-dc33-4837-b4ba-94b51d1f1184
region: content
configuration:
id: 'field_block:media:ceros:field_segment'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 6
additional: { }
c510be7f-1971-4a7a-adeb-3e7ee589af42:
uuid: c510be7f-1971-4a7a-adeb-3e7ee589af42
region: content
configuration:
id: 'field_block:media:ceros:field_media_audience'
label_display: '0'
context_mapping:
entity: layout_builder.entity
formatter:
type: entity_reference_label
label: visually_hidden
settings:
link: true
third_party_settings: { }
weight: 7
additional: { }
third_party_settings: { }
After importing and then exporting it appears that blocks are being duplicated with new uuids, but the existing blocks aren't being removed. It doesn't matter how many times I import and export there is always a diff with "new" blocks.
j.cowher → created an issue.
Thanks for this patch! I also needed to figure out how to ignore translated configuration and #78 worked great. We are using 3.0-beta2.
j.cowher → created an issue.
Also seeing this
Last patch was generated incorrectly and was missing files.
Re-rolling #14 for 9.5.3
Changing the status of this issue to "Needs Review" due to the fact that there are a few different approaches identified by the community. #15 and #4 can be applied via Composer patches, but #12 is more in-depth. Are there any intentions of merging #12 into a future release?
Patch #4 doesn't take into account removals.
Example:
$a = [1, 2, 3];
$b = [1, 2, 3, 4];
array_diff($a, $b); in this example would return an empty array and the rebuild would not run.
Attaching a new patch that was inspired by #4.
j.cowher → created an issue. See original summary → .