Flagging modal issue - z-index isn't being added in some cases

Created on 23 January 2023, over 1 year ago

Problem/Motivation

When the module is configured to display the reporting form in a dialog, the form is grayed out and is unusable. This doesn't happen in all cases and seems dependent on factors such as theme styles, etc.

Steps to reproduce

Go to a node that has comments on it. Click on the link to flag a comment. When the dialog opens, it is grayed out and unusable.

Proposed resolution

In my case, this was only happening for specific roles so I initially thought it was a permissions related issue, but upon further investigation it was determined that a z-index was not being applied to both the dialog and it's overlay.

Reviewing the API documentation for Ajax Dialog Boxes β†’ it appears that the Flag module fails to define the required dependency on the core/drupal.dialog.ajax library. Applying this dependency and rebuilding Drupal's cache appears to have fixed the issue. See attached patch.

Remaining tasks

Review the attached patch

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs review

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States j.cowher

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024