Post update script does not check if slack_link_names is already set

Created on 17 February 2023, almost 2 years ago
Updated 9 March 2023, over 1 year ago

Problem/Motivation

slack_post_update_slack_link_names() does not check if slack_link_names is already set. This causes drush config:status to report differences after importing configuration. This is normally not an issue unless you're using Acquia BLT within your CI pipeline which will fail the build if there are differences between configuration on disk and in the filesystem.

This could also cause an issue if someone were to set slack_link_names to FALSE and then the update script is executed on an environment after an upgrade, locally.

Steps to reproduce

  1. Update Slack module to 1.4 (locally)
  2. Export configuration
  3. Push changes to your Git repository
  4. On another computer, pull the code and run a composer install followed by drush updb
  5. Execute drush config:status
---------------- ----------- 
Name             State      
 ---------------- ----------- 
slack.settings   Different  
---------------- ----------- 

Proposed resolution

See attached patch.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.4

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States j.cowher

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024