- Issue created by @blainelang
- ๐ท๐บRussia znaeff
Hello blainelang,
We will investigate the issue and respond to you within 5 business days.
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 10:03am 16 November 2023 - ๐ฎ๐ณIndia chetan 11
Hi
I have fixed the above error on my local, please check the attached MR.
Thanks. - ๐จ๐ฆCanada blainelang
I have applied the patch and do not see the error any longer.
There is a consistent warning at the top of the Settings page though:
Warning message CleanTalk SFW update error: endOfUpdateCheckingData: The discrepancy between the amount of data received for the update and in the final table: cleantalk_sfw. RECEIVED: 14514. ADDED: 14513. Please, save settings to run new SFW update and wait for an hour. CleanTalk SFW update error: endOfUpdateCheckingData: The discrepancy between the amount of data received for the update and in the final table: cleantalk_sfw. RECEIVED: 14539. ADDED: 14538. Please, save settings to run new SFW update and wait for an hour.
- ๐บ๐ธUnited States maskedjellybean Portland, OR
Thank you for the MR/patch. After applying I no longer see the error.
- ๐ท๐บRussia znaeff
Dear blainelang,
About the warning message you pointed out here: https://www.drupal.org/project/cleantalk/issues/3401905#comment-15322644 ๐ When saving settings: Deprecated function: json_decode() Needs reviewCould you:
- Create a new issue on this site.
- Contact us via our private Ticket System and add there a link to the new issue: https://cleantalk.org/my/support/open. We need additional details about your website. - ๐ง๐ชBelgium cgoffin
I created a patch from the MR to be used with composer.
- Status changed to RTBC
about 1 year ago 6:59am 27 November 2023 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
It looks like this has been committed without the correct commit message.
https://git.drupalcode.org/project/cleantalk/-/blob/9.1.x/lib/Cleantalk/...
https://git.drupalcode.org/project/cleantalk/-/commit/ff139b002089512603...
A maintainer can set this issue to fixed and assign correct credits.
PS: For maintainers, it would help if you use the commit message format as shown on the bottom of the page. It's very important to for a number of reasons to do this, first of all it will show here in the issue queue that it got committed. Secondly, when looking at the commit history of a file you can quickly go back to the issue with all details why it was changed. Commits should start with "Issue #NUMBER"
- Status changed to Fixed
3 months ago 7:18am 10 September 2024 We cannot merge these changes - your branch is much behind the target branch. We have implemented your suggestion by our commit https://git.drupalcode.org/project/cleantalk/-/commit/ff139b002089512603...
Thank you so much for this good suggestion!Automatically closed - issue fixed for 2 weeks with no activity.