When saving settings: Deprecated function: json_decode()

Deprecated function: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in Cleantalk\Custom\Antispam\Cleantalk->httpRequest() (line 441 of /var/www/html/web/modules/contrib/cleantalk/lib/Cleantalk/Custom/Antispam/Cleantalk.php) #0 /var/www/html/web/core/includes/bootstrap.inc(347): _drupal_error_handler_real(8192, 'json_decode(): ...', '/var/www/html/w...', 441) #1 [internal function]: _drupal_error_handler(8192, 'json_decode(): ...', '/var/www/html/w...', 441) #2 /var/www/html/web/modules/contrib/cleantalk/lib/Cleantalk/Custom/Antispam/Cleantalk.php(441): json_decode(NULL, true) #3 /var/www/html/web/modules/contrib/cleantalk/lib/Cleantalk/Custom/Antispam/Cleantalk.php(163): Cleantalk\Custom\Antispam\Cleantalk->httpRequest(Object(Cleantalk\Custom\Antispam\CleantalkRequest)) #4 /var/www/html/web/modules/contrib/cleantalk/src/Form/CleantalkSettingsForm.php(95): Cleantalk\Custom\Antispam\Cleantalk->sendFeedback(Object(Cleantalk\Custom\Antispam\CleantalkRequest)) #5 [internal function]: Drupal\cleantalk\Form\CleantalkSettingsForm->validateForm(Array, Object(Drupal\Core\Form\FormState)) #6 /var/www/html/web/core/lib/Drupal/Core/Form/FormValidator.php(82): call_user_func_array(Array, Array) #7 /var/www/html/web/core/lib/Drupal/Core/Form/FormValidator.php(275): Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object(Drupal\Core\Form\FormState)) #8 /var/www/html/web/core/lib/Drupal/Core/Form/FormValidator.php(118): Drupal\Core\Form\FormValidator->doValidateForm(Array, Object(Drupal\Core\Form\FormState), 'cleantalk_setti...') #9 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(593): Drupal\Core\Form\FormValidator->validateForm('cleantalk_setti...', Array, Object(Drupal\Core\Form\FormState)) #10 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm('cleantalk_setti...', Array, Object(Drupal\Core\Form\FormState)) #11 /var/www/html/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\cleantalk\Form\CleantalkSettingsForm), Object(Drupal\Core\Form\FormState)) #12 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #13 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #14 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #15 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #16 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #17 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(169): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #18 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #19 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #22 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #23 /var/www/html/web/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(209): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #24 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #25 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #26 /var/www/html/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #27 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(718): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #28 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #29 {main}

Comments & Activities

Issue created by @blainelang
Comment 11 months ago →
🇷🇺Russia znaeff
Hello blainelang,

We will investigate the issue and respond to you within 5 business days.
Comment 11 months ago →
🇮🇳India chetan 11
chetan 11 → made their first commit to this issue’s fork.
Merge request !23fixed → (Closed) created by chetan 11
Status changed to Needs review 11 months ago10:03am 16 November 2023
Comment 11 months ago →
🇮🇳India chetan 11
Hi
I have fixed the above error on my local, please check the attached MR.
Thanks.

Comment 11 months ago →

🇨🇦Canada blainelang

I have applied the patch and do not see the error any longer.

There is a consistent warning at the top of the Settings page though:

Warning message
CleanTalk SFW update error: endOfUpdateCheckingData: The discrepancy between the amount of data received for the update and in the final table: cleantalk_sfw. RECEIVED: 14514. ADDED: 14513. Please, save settings to run new SFW update and wait for an hour.
CleanTalk SFW update error: endOfUpdateCheckingData: The discrepancy between the amount of data received for the update and in the final table: cleantalk_sfw. RECEIVED: 14539. ADDED: 14538. Please, save settings to run new SFW update and wait for an hour.

I have uploaded the module debug information →

Comment 11 months ago →
🇺🇸United States maskedjellybean Portland, OR
Thank you for the MR/patch. After applying I no longer see the error.
Comment 10 months ago →
🇷🇺Russia znaeff
Dear blainelang,
About the warning message you pointed out here: https://www.drupal.org/project/cleantalk/issues/3401905#comment-15322644 🐛 When saving settings: Deprecated function: json_decode() Needs review

Could you:
- Create a new issue on this site.
- Contact us via our private Ticket System and add there a link to the new issue: https://cleantalk.org/my/support/open. We need additional details about your website.
Comment 10 months ago →
🇧🇪Belgium cgoffin
I created a patch from the MR to be used with composer.
Status changed to RTBC 10 months ago6:59am 27 November 2023
Comment 10 months ago →
🇷🇺Russia znaeff
Comment 8 months ago →
🇧🇪Belgium BramDriesen Belgium 🇧🇪
It looks like this has been committed without the correct commit message.

https://git.drupalcode.org/project/cleantalk/-/blob/9.1.x/lib/Cleantalk/...

https://git.drupalcode.org/project/cleantalk/-/commit/ff139b002089512603...

A maintainer can set this issue to fixed and assign correct credits.

PS: For maintainers, it would help if you use the commit message format as shown on the bottom of the page. It's very important to for a number of reasons to do this, first of all it will show here in the issue queue that it got committed. Secondly, when looking at the commit history of a file you can quickly go back to the issue with all details why it was changed. Commits should start with "Issue #NUMBER"
Comment 19 days ago →
System Message
glomberg → closed merge request !23
Status changed to Fixed 19 days ago7:18am 10 September 2024
Comment 19 days ago →
Glomberg
We cannot merge these changes - your branch is much behind the target branch. We have implemented your suggestion by our commit https://git.drupalcode.org/project/cleantalk/-/commit/ff139b002089512603...
Thank you so much for this good suggestion!
Comment 5 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

When saving settings: Deprecated function: json_decode()

Merge Requests

!23When saving settings: Deprecated function: json_decode()
Closed

Comments & Activities

When saving settings: Deprecated function: json_decode()

Merge Requests

!23When saving settings: Deprecated function: json_decode()Closed

Comments & Activities

!23When saving settings: Deprecated function: json_decode()
Closed