🇨🇴Colombia @juandhr

Manizales
Account created on 30 August 2024, 9 months ago
  • Web backend developer at SeeD EM 
#

Recent comments

🇨🇴Colombia juandhr Manizales

I created the MR. The gitlab pipeline is now working.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I created the MR with the README.md content.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

The suggested summary for the project page to be displayed in the project browser is:

Provides a customizable floating bar for Drupal admins to quickly access frequently used tasks. Add personalized shortcuts with icons and position the bar for easy, efficient navigation.

In this issue #3516539 📌 Hook help: needs to be added Active , I made a suggestion for the description, here is a revised version:

The suggested description for the project page is:

Quick Shortcuts

Quick Shortcuts enhances the Drupal administrative experience by providing a customizable, floating shortcut bar. This feature allows administrators to quickly access frequently used tasks, improving efficiency and navigation within the Drupal admin interface.

Features

  • Personalized Shortcuts: Easily add, edit, and remove shortcuts to key administrative pages.
  • Intuitive Interface: User-friendly interface for managing shortcuts.
  • Icon Support: Utilizes icons from the administrative theme for visual clarity.
  • Customizable Positioning: Flexible placement options—center-bottom, bottom-left, or bottom-right.
  • Responsive Design: Adapts to various screen sizes, displaying only icons on mobile devices.
  • Seamless Navigation: Shortcuts open in new tabs for uninterrupted workflow.

Configuration

To manage your shortcuts:

  1. Navigate to Configuration > User Interface > Quick Shortcuts.
  2. Click Add Link to create a new shortcut.
  3. Provide a title, internal path, and select an icon.
  4. Define the shortcut bar position (bottom center, bottom left, or bottom right).
  5. Save the configuration; your shortcuts will appear in the floating bar.

Permissions

The module includes a permission (administer quick shortcuts) to control access. Ensure that only trusted roles can manage shortcuts for security purposes.

Help

For detailed guidance, refer to the module's help section available at /admin/help/quick_shortcuts after installation.

🇨🇴Colombia juandhr Manizales

Fised in issue 📌 Set Up GitLab CI Active .

🇨🇴Colombia juandhr Manizales

I created the MR with the logo.png file added.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I created the MR adding the logo.png file.

🇨🇴Colombia juandhr Manizales

Hi, I followed the steps to reproduce the error described in the issue.

After applying the fix from the merge request branch, the error no longer occurs when saving the form at /admin/config/content/rabbit-hole with the Content option enabled.

I can confirm the issue is resolved with this change, so I'm moving the issue to RTBC.

Thanks for the fix!

🇨🇴Colombia juandhr Manizales

Hi.

I'm setting the issue status to Needs work because the merge request has merge conflicts that need to be resolved.

Additionally, there's a missing use statement in class Drupal\lang_dropdown\Plugin\Block\LanguageDropdownBlock — it's referencing an interface that does not exist or is not properly imported:

TypeError: Drupal\lang_dropdown\Plugin\Block\LanguageDropdownBlock::__construct(): Argument #10 ($route_match) must be of type Drupal\lang_dropdown\Plugin\Block\RouteMatchInterface, Drupal\Core\Routing\CurrentRouteMatch given, called in /lang_dropdown/src/Plugin/Block/LanguageDropdownBlock.php on line 121 in Drupal\lang_dropdown\Plugin\Block\LanguageDropdownBlock->__construct() (line 106 of /lang_dropdown/src/Plugin/Block/LanguageDropdownBlock.php).

🇨🇴Colombia juandhr Manizales

It was determined that the requirement in this issue is obsolete and is currently outside the scope of the module's functionality.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I've created a merge request with the proposed changes and would appreciate it if you could take a look when you get a chance.

Additionally, I suggest reviewing the logic related to date range validation. It seems that when trying to view a node, the page always returns a "403 Access Denied" error, regardless of the configured visibility dates. This might indicate an issue in how the date restrictions are being applied.

🇨🇴Colombia juandhr Manizales

Hi.

I reviewed the structure of the README.md file and completed the missing sections and adjusting the formatting to follow the official Drupal README template.

I created a MR with the changes.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I reviewed the structure of the README.md file and completed the missing sections and adjusting the formatting to follow the official Drupal README template.

I also created a merge request with these changes for your review.

🇨🇴Colombia juandhr Manizales

Here is a suggested summary for the project, following Project Browser guidelines and highlighting the main functionality:

Grants sub-admins fine-grained permissions to block or unblock user accounts, restricted by role. Extends the Administer Users by Role module.

Please review.

🇨🇴Colombia juandhr Manizales

I have created the RM, but I am waiting for changes added in other issues to be incorporated into the main project, so that I can avoid conflicts when doing the merge.

🇨🇴Colombia juandhr Manizales

Hi! I’ve created a MR to add the content to the README.md file following the recommended Drupal.org template. The content includes an overview of the module, installation and configuration instructions, requirements, and usage details.

Please review

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I reviewed the structure of the README.md file and completed the missing sections, translating the remaining content into English and adjusting the formatting to follow the official Drupal README template.

I also created a merge request with these changes for your review.

🇨🇴Colombia juandhr Manizales

I followed the steps to reproduce the issue and tested the changes from the fork branch.

Everything worked correctly on my end using a fresh environment with Drupal 11. The error is no longer present when accessing the module settings page.

🇨🇴Colombia juandhr Manizales

I’ve created a Merge Request to add the initial content to the README.md file following the recommended Drupal.org template.

Please review and let me know if any adjustments are needed. Thanks!

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I created a Merge Request to fix the validation errors reported by the GitLab CI pipeline.

Most of the issues were resolved; however, some remain unresolved due to a recommendation to remove the MultiDatesPicker for jQuery UI library and handle it as an external dependency via the module's composer.json.

🇨🇴Colombia juandhr Manizales

I have created an MR with the adjustment to the hook_help() implementation, ensuring the text is in English and aligning the code with Drupal standards and best practices. Let me know if any further refinements are needed.

Please review.

Suggested Update for the Project Description on Drupal.org

It looks like the current project description is the default placeholder text. Below is a suggested description that better represents the module's purpose and functionality:

Suggested Project Description:

Quick Shortcuts provides a floating shortcut bar for Drupal administrators, offering quick access to frequently used administrative tasks. The module enhances efficiency by allowing users to create a personalized set of shortcuts to key pages within the admin interface.

Key Features:

  • Intuitive interface for adding and removing shortcuts.
  • Supports Drupal's administrative theme icons.
  • Customizable floating bar with flexible positioning (center-bottom, bottom-left, bottom-right).
  • Responsive design that adapts to different screen sizes, displaying only icons on mobile.
  • Links open in new tabs for seamless navigation.

Configuration:

Navigate to Configuration > User Interface > Quick Shortcuts to manage your shortcuts. Easily add new links, set their titles, assign icons, and define their position within the shortcut bar.

Suggested Update for the Help Page on Drupal.org

Additionally, the module could benefit from a more detailed help page on Drupal.org. Below is a proposed description that could be used:

Quick Shortcuts - Module Overview

Quick Shortcuts is a Drupal module that enhances the administrative experience by providing a floating shortcut bar. This feature allows site administrators to quickly access commonly used tasks, improving efficiency and navigation within the Drupal admin interface.

Features

  • Easily add, edit, and remove shortcuts.
  • Supports icons from the administrative theme.
  • Customizable positioning options.
  • Mobile-friendly design that adapts to different screen sizes.
  • Securely restricts access to authorized roles only.

Configuration Guide

  1. Navigate to Configuration > User Interface > Quick Shortcuts.
  2. Click "Add Link" to create a new shortcut.
  3. Provide a title, an internal path, and select an icon from the dropdown menu.
  4. Define the shortcut bar position (bottom center, bottom left, or bottom right).
  5. Save the configuration, and your shortcuts will appear in the floating bar.

Permissions

The module includes a permission (amazon_image_id_scan load_s3) to control access. Ensure that only trusted roles can manage shortcuts for security purposes.

More Information

For further details and updates, visit the project page: Quick Shortcuts on Drupal.org .

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I added the logo.png file in the MR. Please review.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I added the logo.png file in the MR, please review.

🇨🇴Colombia juandhr Manizales

I have created an MR with the changes suggested by the Drupal bot, adapting them to use dependency injection. I tested it on Drupal 10, and it appears to be compatible.

🇨🇴Colombia juandhr Manizales

I added the hook_help to amazon_image_id_scan.module file. Please review.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

The gitlab ci pipeline is now working. Please review.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

The gitlab ci pipeline is working now. Please review.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I created the MR with a commit adding the logo file. Please review @jhons0111.

🇨🇴Colombia juandhr Manizales

I added the .gitlab-ci.yml file.

I noticed that the module is not published yet, and the source files are not in the root of the project. I think it still needs some work from the maintainer.

🇨🇴Colombia juandhr Manizales

I followed the steps in the "Steps to reproduce" section, installing the minimal profile for Drupal 11. I was able to obtain the message "The role settings have been updated.", confirming that the modification works as expected.

Additionally, I ran the unit tests in core/modules/user/tests/src/Functional/UserRoleAdminTest.php, and the test execution completed successfully, validating the changes.

🇨🇴Colombia juandhr Manizales

I added the logo to module source code.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I 'm working on add logo to module source code.

🇨🇴Colombia juandhr Manizales

Suggested summary update:

Integrates Amazon Rekognition to verify uploaded documents. It checks authenticity, matches document types, and validates data, improving security for identity verification and official procedures.

You can update the project summary by following the step-by-step guide here: How to update projects to be compatible with Project Browser . The relevant section is "Short description".

🇨🇴Colombia juandhr Manizales

The Gitlab CI pipeline is working now.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I added this commit Issue #3482811 by juandhr: Compatibility fixes for drupal 11 in RekognitionTest class

🇨🇴Colombia juandhr Manizales

The Gitlab CI pipeline is now working.

I created the merge request.

🇨🇴Colombia juandhr Manizales

Working on it.

🇨🇴Colombia juandhr Manizales

The Gitlab CI pipeline is now working.

I created the merge request.

🇨🇴Colombia juandhr Manizales

Working on it.

🇨🇴Colombia juandhr Manizales

The Gitlab CI pipeline is now working.

I created the merge request.

🇨🇴Colombia juandhr Manizales

I have reviewed and tested the changes, and they work as expected.

  • The system no longer throws a fatal error when entering an invalid gift card code in the Add Transaction form.
  • Instead, the validation properly detects when the code does not exist and displays an appropriate error message.
  • Functionality was tested in a clean Drupal [version] environment, and no issues were found.

Since the validation is now correctly handling non-existing gift card codes and preventing fatal errors, I am marking this as RTBC.

🇨🇴Colombia juandhr Manizales

I have created a merge request based on the patch provided by @kevin-oyster in Replace_isFunction()_with_typeof_x_===_'function'.patch . I have reviewed and tested the changes in a Drupal 11 environment, and everything is working as expected.

I am marking this as RTBC.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

Please review the MR.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

I have reviewed and tested the changes from commerce_product_review-3512873/3512873-drupal-11-compatibility.

  • The module installed and worked correctly in a Drupal 11 environment with the core_version_requirement update in the .info.yml file.
  • The change successfully removes the deprecated Url::toRenderArray() usage, and the affected links/pages render correctly.

However, I noticed a deprecation using PhpStan. Drupal\commerce_product_review\Element\OverallProductRating extends the deprecated class Drupal\Core\Render\Element\FormElement, which was deprecated in Drupal 10.3.0 and will be removed in Drupal 12. The recommended replacement is Drupal\Core\Render\Element\FormElementBase.

Given that this does not prevent compatibility with Drupal 11, I will mark this as RTBC. However, addressing the deprecation would be ideal for long-term support.

🇨🇴Colombia juandhr Manizales

I can confirm that the changes introduced in the dwwed branch work as expected.

While testing these changes in a local environment, I:

  • Added the 'access administration pages', 'administer site configuration', and 'administer software updates' permissions to a test role.
  • Logged in with that role and navigated to the /update.php/selection page in the default update process.
  • Verified that the "Administration pages" and "Status report" links display correctly.

This confirms that the modification to use the access() method from Drupal\Core\Url is working as intended.

🇨🇴Colombia juandhr Manizales

Hi @adwivedi008,

The new section provided in README looks good and will help users set up their local environments correctly. I’d suggest a slight improvement in the wording for clarity.

Would you mind refining the second sentence a bit? Something like:

"... and bins. If both the "servers" and "bins" settings for a specified extension are empty arrays, this configuration allows developers to enable the module without requiring Memcache or Memcached in the local environment."

This would make it clearer while keeping the same intent.

🇨🇴Colombia juandhr Manizales

I have tested the newly added field "Google Maps API Key" in the theme configuration form and confirmed that:

  • The field is properly displayed in the UI.
  • The value is stored correctly in the configuration.
  • The field functions as expected.

Based on these checks, I am updating the status to Reviewed & tested by the community.

🇨🇴Colombia juandhr Manizales

Proposed lines in README.md:

Search API is required: Facets only supports Search API as a source for creating facets. Drupal Core's search is no longer supported as a source for facets.

🇨🇴Colombia juandhr Manizales

I have tested the newly added field "Google Maps API Key" in the theme configuration form and confirmed that:

  • The field is properly displayed in the UI.
  • The value is stored correctly in the configuration.
  • The field functions as expected.

Based on these checks, I am updating the status to Reviewed & tested by the community.

🇨🇴Colombia juandhr Manizales

juandhr made their first commit to this issue’s fork.

🇨🇴Colombia juandhr Manizales

Hi @alberto56,

I've updated the docblock in Drupal\Core\TypedData\ListInterface and Drupal\Core\TypedData\DataDefinitionInterface interfaces with the existing Drupal\Core\TypedData\ListDataDefinitionInterface interface, please check.

Production build 0.71.5 2024