- Issue created by @rhovland
- 🇨🇴Colombia juandhr Manizales
I have reviewed and tested the changes from commerce_product_review-3512873/3512873-drupal-11-compatibility.
- The module installed and worked correctly in a Drupal 11 environment with the core_version_requirement update in the .info.yml file.
- The change successfully removes the deprecated Url::toRenderArray() usage, and the affected links/pages render correctly.
However, I noticed a deprecation using PhpStan. Drupal\commerce_product_review\Element\OverallProductRating extends the deprecated class Drupal\Core\Render\Element\FormElement, which was deprecated in Drupal 10.3.0 and will be removed in Drupal 12. The recommended replacement is Drupal\Core\Render\Element\FormElementBase.
Given that this does not prevent compatibility with Drupal 11, I will mark this as RTBC. However, addressing the deprecation would be ideal for long-term support.
- 🇺🇸United States rhovland Oregon
That depreciation is handled in 📌 Implement validation tests Active