- Issue created by @kevin-oyster
Thanks for the report. If the resolution is that very clear I am tagging this "Novice" for the next steps.
- π¬π§United Kingdom kevin-oyster
Thanks cilefen,
Please see a patch we have used to test this. We haven't run extensive tests but similar changes resolves this issue in other code.
- First commit to issue fork.
- Merge request !610Issue #3512816 by kevin-oyster, juandhr: Replace jQuery.isFunction, removed in jQuery 4.0+ β (Merged) created by Unnamed author
- π¨π΄Colombia juandhr Manizales
I have created a merge request based on the patch provided by @kevin-oyster in Replace_isFunction()_with_typeof_x_===_'function'.patch β . I have reviewed and tested the changes in a Drupal 11 environment, and everything is working as expected.
I am marking this as RTBC.
- π¨π¦Canada mandclu
Wouldn't it make more sense to use the vanilla JS
checkValidity()
check and do away with the jQueryvalid()
? - π¨π¦Canada mandclu
I made a new MR that uses the native Javascript method instead. Here is some documentation on the method I am suggesting.
- π¨π¦Canada mandclu
mandclu β changed the visibility of the branch 3512816-checkvalidity to hidden.
- π¨π¦Canada mandclu
Right,
$form
at that point is really a jQuery object. There would need to be a much more significant rewrite to remove the dependency here on jQuery.Moving this back to RTBC on the previous MR.
- First commit to issue fork.
-
jrockowitz β
committed acd9f366 on 6.3.x authored by
juandhr β
Issue #3512816: jQuery.isFunction is removed in jQuery 4.0+
-
jrockowitz β
committed acd9f366 on 6.3.x authored by
juandhr β
-
jrockowitz β
committed acd9f366 on 6.x authored by
juandhr β
Issue #3512816: jQuery.isFunction is removed in jQuery 4.0+
-
jrockowitz β
committed acd9f366 on 6.x authored by
juandhr β