Remove "use strict" statements from JS files

As I said in 📌 Fix ESLint pipeline Active , the current eslint pipeline raises 23 errors like "'use strict' is unnecessary inside of modules", but this merge request removes use strict from 84 files. As I understand it, this should only be removed from the 23 files that are modules.

I am for any patch that simplifies the JS code and is safe to commit.

Core at some point reversed https://www.drupal.org/node/1570578 → and use strict is no longer included in core JS.

I grepped Drupal core for use strict and there are 117 JavaScript files that have it.

I would be OK with reverting this change and opening a new MR with a more targeted implementation.

You could just have a single commit that adds use strict in places where it is needed. I suggest making a merge request that reverts the original commit. Then look at the eslint report and remove it only where eslint calls for it to be removed. Squash the changes on merge and you get a single commit neatly re-adding it where it is needed. Thanks

I reverted the commit.

Probably needs a rebase as well before re-attempting this as some modules are removed.

I've uploaded two patch files generated by eslint, one before and one after the changes in the MR!621. It's worth noting that among the places eslint suggests removing the 'use strict' and the surrounding newlines, not all of them are within the modules. I have updated the issue title to reflect the fact that eslint suggests removal of 'use strict' more broadly.

This new MR focuses instead on the patterns identified by eslint for removal. The second patch file shows that all cited uses of 'use strict' are resolved by the new MR.

If all the tests pass this should RTBC.

Has a merge conflict.

Working on the rebase

Rebased the MR.
Please review

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.