Contrib.social

Token::replace() should accept any type of callable

Open on Drupal.org →
Created on 19 April 2013, about 12 years ago
Updated 15 May 2025, about 2 months ago

Problem/Motivation

Token replace takes a callback function, which is expected to be a string. This makes it difficult to be used for classes with methods. This problem was raised when doing the Token contrib module port to D8.

Proposed resolution

Make the argument accept a callable instead.

Remaining tasks

User interface changes

API changes

Original report by @Xano

Token::replace() accepts a callable in its $options['callback'] parameter:
1) The parameter does not clearly state what the callback should do.
2) The code keeps calling the callback a function, while it technically accepts any kind of callable, as it should.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

token system

Created by

🇬🇧United Kingdom Xano Southampton

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Comment about 2 months ago →
    🇨🇭Switzerland berdir Switzerland

    Still useful, but per #34, we only need the docblock change.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    Think a valid novice task?

  • Comment about 2 months ago →
    🇨🇭Switzerland berdir Switzerland

    Absolutely. Task: Convert the first chunk in the patch to a merge request.

  • First commit to issue fork.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024