Token::replace() should accept any type of callable

Created on 19 April 2013, about 12 years ago
Updated 15 May 2025, about 2 months ago

Problem/Motivation

Token replace takes a callback function, which is expected to be a string. This makes it difficult to be used for classes with methods. This problem was raised when doing the Token contrib module port to D8.

Proposed resolution

Make the argument accept a callable instead.

Remaining tasks

User interface changes

API changes

Original report by @Xano

Token::replace() accepts a callable in its $options['callback'] parameter:
1) The parameter does not clearly state what the callback should do.
2) The code keeps calling the callback a function, while it technically accepts any kind of callable, as it should.

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

token system

Created by

πŸ‡¬πŸ‡§United Kingdom Xano Southampton

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024