Contrib.social

password_confirm form element #title property is hardcoded

Open on Drupal.org →
Created on 6 November 2024, 6 months ago

Problem/Motivation

The password_confirm form element #title property is hardcoded and a duplicate title is shown if you use it.

This is what we have at this time in the class usage example:

/**
 * Provides a form element for double-input of passwords.
 *
 * Formats as a pair of password fields, which do not validate unless the two
 * entered passwords match.
 *
 * Properties:
 * - #size: The size of the input element in characters.
 *
 * Usage example:
 * @code
 * $form['pass'] = [
 *   '#type' => 'password_confirm',
 *   '#title' => $this->t('Password'),
 *   '#size' => 25,
 * ];
 * @endcode
 *
 * @see \Drupal\Core\Render\Element\Password
 */
#[FormElement('password_confirm')]
class PasswordConfirm extends FormElementBase {

and this is what we have in the processPasswordConfirm method:

  /**
   * Expand a password_confirm field into two text boxes.
   */
  public static function processPasswordConfirm(&$element, FormStateInterface $form_state, &$complete_form) {
    $element['pass1'] = [
      '#type' => 'password',
      '#title' => t('Password'),
      '#value' => empty($element['#value']) ? NULL : $element['#value']['pass1'],
      '#required' => $element['#required'],
      '#attributes' => [
        'class' => ['password-field', 'js-password-field'],
        'autocomplete' => ['new-password'],
      ],
      '#error_no_message' => TRUE,
    ];

Steps to reproduce

Create a custom form with a password_confirm form element with #title and you will see this:

    $form['password'] = [
      '#type' => 'password_confirm',
      '#title' => $this->t('Add your Password'),
      '#required' => TRUE,
    ];

Proposed resolution

We should allow the values to be set for the two password form elements.

Remaining tasks

TBD

User interface changes

None

API changes

TBD

Release notes snippet

TBD

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

forms system

Created by

🇨🇦Canada adriancid Montreal, Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024