- Issue created by @Sivaji_Ganesh_Jojodae
- 🇮🇳India Sivaji_Ganesh_Jojodae Chennai
sivaji_ganesh_jojodae → changed the visibility of the branch 3514936-modulesuninstallform.php-assigns-string to hidden.
- Merge request !11593Changing class attribute to array from string. → (Open) created by Sivaji_Ganesh_Jojodae
- 🇬🇧United Kingdom MrDaleSmith
Looks good to me, and the random test failure has been resolved by a re-run.
- 🇬🇧United Kingdom MrDaleSmith
Any reason why this has been set to needs work @smustgrave? There are no comments to advise what needs doing, and it's a very simple bit of code: I can't think what additional changes are needed?
- 🇬🇧United Kingdom MrDaleSmith
That feels like overkill - it's clearly fixing a common mistake most people do when adding css classes to render arrays: are we really going to add overhead to say this specific one has been added correctly?