Remove some unused variables

Comments & Activities

Issue created by @arti_parmar
Issue was unassigned.
Status changed to Needs review over 1 year ago1:21pm 28 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
132 pass
Comment over 1 year ago →
🇮🇳India arti_parmar
Kindly review patch.
Status changed to RTBC over 1 year ago9:43am 11 July 2023
Comment over 1 year ago →
🇮🇳India indrapatil Bangalore
reviewed the patch it's working So moving to RTCB
Status changed to Needs work 8 months ago2:27pm 17 April 2024

🇺🇸United States mradcliffe USA

+++ b/src/FreelinkingManager.php
@@ -119,7 +119,7 @@ class FreelinkingManager extends DefaultPluginManager implements FreelinkingMana
-    foreach ($items as $key => $item) {

+++ b/src/Plugin/Filter/Freelinking.php
@@ -174,7 +174,7 @@ EOF;
-    foreach ($allowed_plugins as $plugin_name => $plugin_info) {

I am always hesitant to use foreach without a key or index defined due to Drupalgeddon so I would prefer to keep these variables.

I'm now using GitLab CI so patch work flow is deprecated. Setting to needs work for that and comment above.

Comment 8 months ago →
🇺🇸United States mradcliffe USA
Status changed to Closed: outdated 3 months ago6:17pm 19 September 2024
Comment 3 months ago →
🇺🇸United States mradcliffe USA