- Issue created by @bnjmnm
- @bnjmnm opened merge request.
- Status changed to Needs review
over 1 year ago 5:32pm 26 July 2023 - 🇮🇳India Preeti.chawla
@bnjmnm I have not able to apply patch. There is something wrong, Even I have tried to add code manually and I check "buttonBorder" variable not declared anywhere
- 🇮🇳India Preeti.chawla
@bnjmnm Now I have tried to apply patch with this version Drupal9.5 and Gin 8.x-3.x-dev, Patch applied successfully but icons still not visible for me
- 🇺🇸United States bnjmnm Ann Arbor, MI
@bnjmnm Now I have tried to apply patch with this version Drupal9.5
This is a merge request, just copy paste the git commands in "show commands" to switch to the fork/branch instead of trying to treat a merge request as a patch.
buttonBorder"
is not a variable that needs to be declaredThat is correct, and not at all a problem. It's a system color, which is a best practice for providing fixed colors styling.
Patch applied successfully but icons still not visible for me
Without additional information I have to assume user error. It clearly works for me and I can't do much with "still not visible for me". Did you check your browser dev tools to confirm the styles added in the MR are present in the CSS ingested by the browser?
- 🇮🇳India mukeysh
@bnjmnm
I have tested the code the cross icon is there but not visible properly. I am attaching a screenshot for reference.I also noticed the status icon is not visible.
- 🇺🇸United States bnjmnm Ann Arbor, MI
That's a helpful explanation @Mukeysh, I now know what is happening here.
Automatic dark color mode is a Chrome experimental feature that can only be enabled via dev featurs. Drupal / Gin can't be expected to support Chrome experimental features, and is
To test dark themed forced colors mode, which is recognized by all Drupal supported browsers, choose
prefers-color-scheme: dark
in the "Emulate CSS media feature prefers-color-scheme" option. - 🇮🇳India mukeysh
@bnjmnm
It looks fine then attaching a screenshot for reference. I have noticed the message icon is not visible so I have made fixes in the MR. - 🇮🇳India indrapatil Bangalore
I reviewed this patch. I attached the screenshot.
- 🇮🇳India djsagar
Hi All,
This issue not replicate on drupal 10.1.2 with fin 8.x-3.x.
Please have look.
Thanks!
- Status changed to RTBC
over 1 year ago 8:11am 16 August 2023 - 🇮🇳India djsagar
So finally i applied this patch #9 in drupal 10.1.2 with fin 8.x-3.x. It's working as expected.
I attached the screenshot for reference.Thanks!
- First commit to issue fork.
-
saschaeggi →
committed 2a3db38e on 8.x-3.x authored by
bnjmnm →
Issue #3377202: messages close icon not visible in forced colors mode
-
saschaeggi →
committed 2a3db38e on 8.x-3.x authored by
bnjmnm →
- Status changed to Fixed
over 1 year ago 5:39pm 19 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.