- Issue created by @bendqh1
- Status changed to Closed: works as designed
over 1 year ago 1:37pm 9 July 2023 - ๐บ๐ธUnited States andy-blum Ohio, USA
The olivero design keeps content left-aligned in LTR languages, and right-aligned in RTL languages. Attaching the issue working on centering the layout.
Andy I am sorry but I don't understand what aligning has to do with this empty space in each webpage.
If the space is removed, anything could still be alinged to anywhere by CSS.- ๐บ๐ธUnited States andy-blum Ohio, USA
The page content is in a wrapper with a set max width. The โdropsโ pattern is the background that takes up the remainder of the page instead of blank white.
Hello Andy, by "content" I assume you meant the "Content region" and that this region is inside a wrapper, is that correct?
What I misunderstand is why is it good to not to cover the horizontal viewport entirely?...
I also seek a way to remove the empty space and to make my website's content to cover all of the horiztonal viewport --- how is it this possible CSSwise?
- Status changed to Active
over 1 year ago 3:47pm 16 July 2023 - ๐ฎ๐ณIndia indrapatil Bangalore
Hello @bendqh1
These web pages have empty space issues because of the below CSS..page-wrapper {
max-width: var(--max-bg-color);
background: var(--color--white);
}max-width: var(--max-bg-color); is creating the empty space.
If we make 100% then it will be fixed. - Status changed to Closed: works as designed
over 1 year ago 1:34am 20 July 2023 - ๐ฉ๐ชGermany tomsaw Essen
I've been asking myself the same question and this issue does not answer it yet.
The technical reason -
max-width: something
- is one way to answer the 'why' question.However, my thirst for comprehension of the purpose for this design decision remains unsatisfied.
What's the benefit of restricting the width to 87xy rem?
Does it f.e. improve the websites readability?
Or the space is reserved for some hovering widget like a chat bubble!? TomSaw, I agree, and also, the provided CSS above didn't fully solve the problem for me.
.page-wrapper { max-width: 100%; background: 100%; } body { background-image: none; background-position: unset; }
It's not enough that yes everything spans on 100% width and also the drops background image disappears but still, all content is marginalized to the leftmost of the screen (LTR languages) or to the rightmost of the screen (RTL languages).
Any suggestions how to solve this problem?
- Status changed to Needs work
about 1 year ago 4:47am 30 November 2023 - Status changed to Closed: works as designed
about 1 year ago 12:22pm 30 November 2023 - ๐บ๐ธUnited States andy-blum Ohio, USA
Page content is limited in width for readability.
https://css-tricks.com/six-tips-for-better-web-typography/Page layout is limited in width to keep the rest of the page elements in the same general area with the page content.
If you think this layout would look better center aligned, I'd direct you to a different issue, ๐ Olivero: Center align content (instead of left align) Needs work .
- Status changed to Active
about 1 year ago 1:24am 1 December 2023 andy-blum, either I miss something, you miss something or we both miss something.
In both your screenshots, an empty "column" with the body tag background images of Gray-colored drops.
I still ask with this empty column is there?
- Status changed to Closed: works as designed
about 1 year ago 1:56am 1 December 2023 - ๐บ๐ธUnited States andy-blum Ohio, USA
The empty column is there because the website layout has been deliberately limited to a max-width of 98.125rem. Without this limitation, the website would spread across the entire screen hindering readability of the content and causing large swaths of empty space between the content, the logo, and the navigation.
If this is not acceptable to you, you are free to make a new theme using Olivero as a starterkit ๐ [PP-1] Allow starterkit theme generator tool to clone Olivero Postponed . This design of Olivero has been finalized for quite some time now and it will not be changing. Please stop re-opening this issue.
I am allowed to re open this issue if I think that there is a misunderstanding, a misleading or a UX problem which has not been discussed enough.
I think you should allow this issue at least half a week, if not a week or a month to be widely addressed by the community.
I understand that with some different CSS than yours above, we can actually solve the problem without forking Olivero.
I have switched the right to left and vice versa for LTR testing instead of RTL testing./* delete drops image */ body { background-image: none; background-position: unset; } /* maximize page width */ .page-wrapper { max-width: 100%; } /* Centralize single column content */ #main .grid-full { grid-template-columns: none; } /* stretch and centralize main content */ #main > div.main-content > div { max-width: 100% !important; margin: 0 auto 0 !important; } /* stretch and centralize footer content */ #page > footer > div { max-width: 100% !important; margin: 0 auto 0 !important; } /* if your site is in a LTR language like English, make it margin-left instead */ .site-branding__inner { margin-left: 32.5px; } @media screen and (min-width: 480px) { /* fix discrapencies between the starting place of elements */ .region { justify-content: start; } /* fix asymmetry in desktop views from the left and right (switch to padding-right for LTR websites) */ .main-content__container, .container { padding-inline: unset; padding-right: 5%; } /* prevent images from overflowing in standard layout builder columns */ .layout--twocol-section img, .layout--threecol-section img, .layout--fourcol-section img { max-width: 350px; } }
- Status changed to Needs review
about 1 year ago 9:11am 1 December 2023 - Status changed to Needs work
about 1 year ago 2:56pm 1 December 2023 - ๐บ๐ธUnited States smustgrave
As noted the spacing was added on purpose and I highly doubt that's going to change at this point with the ability to clone the theme yourself for your custom needs.
Moving out of review as there is nothing to actually review.
Oh, I meant that I suggest other users to review the CSS I pasted above, is it out of scope here? What then is normally reviewed here?
- Status changed to Closed: works as designed
about 1 year ago 3:53pm 1 December 2023 - ๐บ๐ธUnited States andy-blum Ohio, USA
Typically code changes should be submitted as patches or MRs - that way the testing infrastructure can review the code as well. Your CSS, however, is not a bug fix. Your CSS is a change based on your opinion of a design that was finalized several years ago, and that is in active use in sites. Changing this design in Olivero now would cause regressions in existing sites. As such, I have continually marked this as "works as designed".
Again, if this change is something you feel that strongly about, I recommend using the starterkit patch provided above or some other method for creating your own custom solution.
- ๐บ๐ธUnited States volkswagenchick San Francisco Bay Area
Hey there, coming in as a member of the Community Health team, there seems to be some disagreement about where this issue fits in the ecosystem.
This discussion appears to include escalating emotions, creating the opportunity for miscommunication. The invested parties are encouraged to take a break from this discussion to help gain perspective. It is important to the community that all members are shown the appropriate amount of respect and openness when working together.
For more information, please refer to Drupalโs Values and Principles of seeking first to understand, then to be understood โ . Assume best intentions of other contributors and suspend judgment until you have invested time to understand decisions, ask questions, and listen. Before expressing a disagreement, make a serious attempt to understand the reasons behind the decision.
This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687 โ
I do see this is opened as a support request. Multiple Maintainers have weighed in about why this issue is marked "works as designed", and then the issue is being re-opened.
Please review
Using GitLab to Contribute to Drupal - https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... โ .
Issue etiquette - https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... โ I take MRs as "Merge Requests".
Alright, either a patch or an MR.
Thanks.
- ๐ฉ๐ชGermany tomsaw Essen
Yepp MR = [M]erge [R]equest and I also understand, that this is concidered a Feature and Olivero is feature complete and does not accept any changes. It's a good thing if things have some stability.
One thing to concider: I've created a olivero based theme ui_suite_olivero โ this year. Thanks to modules from UI Suite Initiave โ you can set all css variables of olivero easily in backend and they are stored in configurations which is sooper maintainable!
-> I also don't relly on oliveros limited width so I thought there could be a select or checkbox widget in the ui_suite_olivero settings to control the width behaviour!