Allow starterkit theme generator tool to clone Olivero

That was so easy, thanks so much! I've been trying to stick with just core stuff for a simple site and ended up needing to customize just a little of the css and templates, so this was a huge win for my site. Thanks!

Thanks a lot on this! This is already pretty useful ...
BUT I have faced some important issues trying to generate a custom theme of mine with this starterkit from Olivero, when using a machina name with underscores and a label/name with spaces inside it.

For instance the following command:

php core/scripts/drupal generate-theme my_custom_theme --name "My Custom Theme" --starterkit olivero

generated weird duplications and mismatches in the names of the generated files and also a pre-render class name with spaces ...
(nothing really usable)

The only working solution with this has been (so far) to create/use a theme with both machine name and name without underscore or spaces, such the following:

php core/scripts/drupal generate-theme mycustomtheme --name MyCustimTheme --starterkit olivero

It works, but is indeed not ideal ...

@itamir can you point to any specific examples where you encountered problems? I copied your example command and got perfectly valid results. I was able to fully install and set the new theme as default and browse the site without issue.

Hi Andy … well ok … sorry!
Donno what was it, how I experienced those weird behaviours, but I re-tested this few times more, and all LGTM now.
I am on a new Macbook ARM M2 and recently made some updates in my composer etc etc ...
Indeed now this looks neat and good to me.
I was able to start / fork 3 themes from Olivero, very quickly and with no apparent issues.

RTBC by me.

Now that 📌 Automated A11y tests in Nightwatch Fixed has landed, I've added it into our new testPerTheme() function. 🤞

Themes are created and installed successfully, but if their name does not contain the word "olivero". For example, if the theme's name is "custom_olivero" then there are issues with namespaces. Maybe it make sense just notify users about this in some doc?

Seems there are failures in the MR

Moving this to postponed as the starterkit tool theme is currently undergoing a re-write in 📌 Making a theme compatible with core's theme generator is too difficult Needs work . When that's done all Olivero should need to do is update .info.yml and add a .starterkit.yml file

How is this not ?! 🤯

Also, this is blocked on 📌 Making a theme compatible with core's theme generator is too difficult Needs work , which itself is blocked 😅

… it's blocked more than I thought 😅

Symfony's finder & filesystem components are now full runtime dependencies [ CR → ]

Now that 📌 Making a theme compatible with core's theme generator is too difficult Needs work is in, this is unblocked!

andy-blum → closed merge request !2996

andy-blum → changed the visibility of the branch 10.1.x to hidden.

Is it already possible to use/clone Olivero as a starterkit theme? Maybe with a patch since it hasn't made it into Drupal 11 yet.

For Drupal CMS there is the drupal_cms_olivero theme which itself uses Olivero as a base theme and which is not recommended like the module itself states in drupal_cms_olivero.info.yml.

# This theme is marked as @internal. It is intended to evolve and change over minor releases.
# Although we are sub-theming Olivero within Drupal CMS, sub-theming Olivero is
# explicitly not supported by Drupal core. This is intended as a stop-gap
# measure to provide great looking content types and components before a more
# robust design system can be implemented.

What is the proposed solution for Drupal CMS and Olivero and the build setup (CSS/JS/img optim) once Olivero got actually cloned? I would like to reuse the the 'menu' with it's a11y features.

Thanks for guidance.

Same question here for D11.1 core.

php core/scripts/drupal generate-theme mycustomtheme --name MyCustomTheme --starterkit olivero
[ERROR] Theme source theme olivero is not a valid starter kit.

I'm eagerly awaiting this issue to be ready for testing. I managed to patch Olivero to create a subtheme back under D9, but the patch wouldn't work for me in D10.

As a stop-gap, I've been using Jean Valverde's Olivero Subtheme Project. It links to this issue, and warns that it will soon be obsolete, but it doesn't seem to be quite yet!

I fully expect to recreate my subtheme as a Starterkit theme when possible, but just now Jean's project seems to be the best option for Olivero derived themes.

Whats holding this back? It's quite frustrating to see no progress here since a long time. In general, if Drupal "finally" wants to attract Frontend people the frontend topics should also be addressed like any other issue. Since my D6 days, the frontend has always been the stepchild ... I don't want to rant, but I'm actually a bit frustrated since I came back to Drupal after a while being away (for reasons) and things seem to be the same as they were in Drupal Frontendlandia ... marketing says it all changed but it unfortunately hasn't. Don't get me wrong and this is probably the wrong place to address this but on the otherhand it's also a core thing/theme where alot of effort already went into so why not reusing this great work.

Whats holding this back

Pretty sure we need some comprehensive tests.

Since my D6 days, the frontend has always been the stepchil

I hear that. But since D10, we've made a lot of improvements including a better dump(), UI for enabling twig debugging, some great new twig filters, and of course SDC

but we need a theme too (to glue it all together)

That's in progress now. See https://www.drupal.org/about/starshot/blog/announcing-the-selected-partn... →

probably the navigation/focus handling needs to be extracted/provided as a own navigation module which then can be integrated/combind in any theme.

Not sure this is possible. Obviously focus states are important, but so is order. But yeah, I hear you.

What can be done is install this theme

https://www.drupal.org/project/drupal_cms_olivero →

Now you can override wherever you need in a custom theme.