Allow starterkit theme generator tool to clone Olivero

That was so easy, thanks so much! I've been trying to stick with just core stuff for a simple site and ended up needing to customize just a little of the css and templates, so this was a huge win for my site. Thanks!

Thanks a lot on this! This is already pretty useful ...
BUT I have faced some important issues trying to generate a custom theme of mine with this starterkit from Olivero, when using a machina name with underscores and a label/name with spaces inside it.

For instance the following command:

php core/scripts/drupal generate-theme my_custom_theme --name "My Custom Theme" --starterkit olivero

generated weird duplications and mismatches in the names of the generated files and also a pre-render class name with spaces ...
(nothing really usable)

The only working solution with this has been (so far) to create/use a theme with both machine name and name without underscore or spaces, such the following:

php core/scripts/drupal generate-theme mycustomtheme --name MyCustimTheme --starterkit olivero

It works, but is indeed not ideal ...

@itamir can you point to any specific examples where you encountered problems? I copied your example command and got perfectly valid results. I was able to fully install and set the new theme as default and browse the site without issue.

Hi Andy … well ok … sorry!
Donno what was it, how I experienced those weird behaviours, but I re-tested this few times more, and all LGTM now.
I am on a new Macbook ARM M2 and recently made some updates in my composer etc etc ...
Indeed now this looks neat and good to me.
I was able to start / fork 3 themes from Olivero, very quickly and with no apparent issues.

RTBC by me.

Now that 📌 Automated A11y tests in Nightwatch Fixed has landed, I've added it into our new testPerTheme() function. 🤞

Themes are created and installed successfully, but if their name does not contain the word "olivero". For example, if the theme's name is "custom_olivero" then there are issues with namespaces. Maybe it make sense just notify users about this in some doc?

Seems there are failures in the MR

Moving this to postponed as the starterkit tool theme is currently undergoing a re-write in 📌 Making a theme compatible with core's theme generator is too difficult Needs work . When that's done all Olivero should need to do is update .info.yml and add a .starterkit.yml file

How is this not ?! 🤯

Also, this is blocked on 📌 Making a theme compatible with core's theme generator is too difficult Needs work , which itself is blocked 😅

… it's blocked more than I thought 😅

Symfony's finder & filesystem components are now full runtime dependencies [ CR → ]

Now that 📌 Making a theme compatible with core's theme generator is too difficult Needs work is in, this is unblocked!

andy-blum → closed merge request !2996

andy-blum → changed the visibility of the branch 10.1.x to hidden.