t() calls should be avoided in classes

Kindly review patch.

Hi @arti
You need to update the command which we need to run to test.
patch applied cleanly so moving to RTBC.

1. +++ b/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php
   @@ -73,7 +76,7 @@ abstract class MigrateUpgradeExecuteTestBase extends CoreUpgradeTestBase {
   -    $session->pageTextContains(t('Congratulations, you upgraded Drupal!'));
   +    $session->pageTextContains($this->t('Congratulations, you upgraded Drupal!'));
   

   This fix is wrong, we shuoldn't be using t() in tests, can you remove the trait and t() altogether

2. +++ b/tests/src/Kernel/FeedValidationTest.php
   @@ -55,9 +58,9 @@ class FeedValidationTest extends EntityKernelTestBase {
   -    $this->assertEquals(t('A feed named %value already exists. Enter a unique title.', ['%value' => $feed->label()]), $violations[0]->getMessage());
   +    $this->assertEquals($this->t('A feed named %value already exists. Enter a unique title.', ['%value' => $feed->label()]), $violations[0]->getMessage());
        $this->assertEquals('url', $violations[1]->getPropertyPath());
   -    $this->assertEquals(t('A feed with this URL %value already exists. Enter a unique URL.', ['%value' => $feed->getUrl()]), $violations[1]->getMessage());
   

   here too

Thanks for working on this.

Per my blog post, phpcs issues are great for new contributors. However I notice from your profile you already have several credits for PHPCS issues. As a result I'm removing credit in this instance. Feel free to stick around and help with the other issues in the module if you're looking to for the next step in your contribution journey.

Sure @larowlan I will work on the other issues.
Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.