- Issue created by @Hamid.ali
- 🇮🇳India Hamid.ali
I am working on this issue and will provide a patch for the same.
- last update
12 months ago 29,430 pass - Issue was unassigned.
- Status changed to Needs review
12 months ago 2:19pm 20 June 2023 - Assigned to Bushra Shaikh
- Issue was unassigned.
Hi @Hamid.ali,
can you please share the Olivero theme figma link for mobile view, so i can verified the issue and solution.
- Status changed to Postponed: needs info
12 months ago 3:34pm 21 June 2023 - 🇺🇸United States smustgrave
Figma should be added to the issue summary for others to compare.
- 🇮🇳India Hamid.ali
Here I am attaching the Olivero theme figma link for mobile view mobile view design
- Status changed to Needs review
12 months ago 7:36am 25 June 2023 - 🇮🇳India fadilraj
Applied the patch 3367957-3.patch. Although the position of the search bar has been corrected as per the Figma design, the size of the 'Search' icon does not seem to match. Below are attached screenshots. Changing the status to 'Needs Work' for now.
- Status changed to Needs work
12 months ago 5:54am 26 June 2023 - Assigned to Hamid.ali
- Status changed to Active
12 months ago 6:14am 26 June 2023 - 🇮🇳India Hamid.ali
I am working on this will provide the updated patch for the same.
- 🇮🇳India Hamid.ali
Fixed the search icon as per the Figma attached the updated patch along with the before and after screenshots.
Before Patch
After Patch
- last update
12 months ago 29,436 pass - Issue was unassigned.
- Status changed to Needs review
12 months ago 8:16am 26 June 2023 - Status changed to RTBC
12 months ago 9:10am 26 June 2023 - 🇮🇳India fadilraj
The patch 3367957-16_0.patch seems to be working fine and does match the Figma design. Screenshots are attached below, for before and after the patch. Changing the status to RTBC.
- Status changed to Needs review
12 months ago 11:41am 26 June 2023 - 🇺🇸United States smustgrave
Tagging for review by sub maintainer.
Also @Hamid.Ali you shouldn’t assign tickets to yourself unless you’re a maintainer. Per the policy
#14 was actually the correct way to go about it.
Hi,
I confirm that Patch #16 works fine on:
Drupal Core version: 10.1.0-dev
PHP Version: 8.2.6- 🇨🇴Colombia yovanny.gomez.oyola
Hello everyone,
I have validated and the patch #16 works well with Drupal: 10.1.0-dev and PHP: 8.1.19
Regards,
- 🇮🇳India Shiv_Sharma
As per figma design patch #16 is working fine.
Figma design link for reference.
https://www.figma.com/file/x5zBLbvoW1jsvyAOt4Gp9I/Olivero-Theme---Public... - 🇮🇳India Indra patil Bangalore
I Reviewed patch #16 I attached the screen shot
- last update
10 months ago 29,465 pass - 🇮🇳India Gauravvv Delhi, India
Everything looks good except the removing the padding-inline. I have attached the patch and interdiff for same. I have added before and after patch screenshot.
- Status changed to RTBC
10 months ago 10:02am 23 August 2023 - 🇮🇳India djsagar
I applied patch #24, now form component is as per the Figma design and I attached the screen shot.
- last update
10 months ago 29,469 pass - Status changed to Needs review
10 months ago 12:24pm 23 August 2023 - 🇮🇳India nilesh.k
Hi
patch #24 has been successfully applied on my local environment. I have also added screenshots, both
before
and
after
- Status changed to RTBC
8 months ago 6:39pm 12 October 2023 - 🇺🇸United States smustgrave
Was RTBC in #25
Still needs submaintainer sign off but putting back.
Am told design decisions were made before olivero launch that aren't in the figmas.
Personally for me this is a works by design. Magnifying glass on the left seems odd.
- last update
8 months ago 29,621 pass, 1 fail The last submitted patch, 24: 3367957-24.patch, failed testing. View results →