Olivero: Fix Search block form component

I am working on this issue and will provide a patch for the same.

Have attached the patch to fix this issue.

Hi @Hamid.ali,

can you please share the Olivero theme figma link for mobile view, so i can verified the issue and solution.

Figma should be added to the issue summary for others to compare.

Here I am attaching the Olivero theme figma link for mobile view mobile view design

Applied the patch 3367957-3.patch. Although the position of the search bar has been corrected as per the Figma design, the size of the 'Search' icon does not seem to match. Below are attached screenshots. Changing the status to 'Needs Work' for now.

Working on this issue

I am working on this will provide the updated patch for the same.

Fixed the search icon as per the Figma attached the updated patch along with the before and after screenshots.
Before Patch

After Patch

The patch 3367957-16_0.patch seems to be working fine and does match the Figma design. Screenshots are attached below, for before and after the patch. Changing the status to RTBC.

Tagging for review by sub maintainer.

Also @Hamid.Ali you shouldn’t assign tickets to yourself unless you’re a maintainer. Per the policy

#14 was actually the correct way to go about it.

Hi,

I confirm that Patch #16 works fine on:
Drupal Core version: 10.1.0-dev
PHP Version: 8.2.6

Hello everyone,

I have validated and the patch #16 works well with Drupal: 10.1.0-dev and PHP: 8.1.19

Regards,

As per figma design patch #16 is working fine.
Figma design link for reference.
https://www.figma.com/file/x5zBLbvoW1jsvyAOt4Gp9I/Olivero-Theme---Public...

I Reviewed patch #16 I attached the screen shot

Everything looks good except the removing the padding-inline. I have attached the patch and interdiff for same. I have added before and after patch screenshot.

I applied patch #24, now form component is as per the Figma design and I attached the screen shot.

Still needs review by sub maintainer

Hi

patch #24 has been successfully applied on my local environment. I have also added screenshots, both

before

and
after

Was RTBC in #25

Still needs submaintainer sign off but putting back.

Am told design decisions were made before olivero launch that aren't in the figmas.

Personally for me this is a works by design. Magnifying glass on the left seems odd.

The last submitted patch, 24: 3367957-24.patch, failed testing. View results →

i have fixed the issue for 11.x please review

Just seeing this now. Thank you for all the work, but this was an intentional decision made during the implementation phase (not sure if it's documented though).

Closing as won't fix.

smustgrave → closed merge request !9784