@saschaeggi would you help me to find those issues
This is core issue closing it from here
Shiv_Sharma → created an issue.
Shiv_Sharma → created an issue.
this MR working fine for me. adding screenshot for reference
Seem there are more fixes need to done as after applying patch still showing phpcs warning to me.
FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/tests/src/Kernel/EmailAttachmentTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 14 LINES
----------------------------------------------------------------------------------------------------------------
15 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [ ] Missing short description in doc comment
23 | ERROR | [x] Whitespace found at end of line
24 | ERROR | [x] Missing function doc comment
29 | ERROR | [x] Missing function doc comment
40 | ERROR | [x] Missing function doc comment
49 | ERROR | [x] Missing function doc comment
62 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
69 | ERROR | [ ] String concat is not required here; use a single string instead
70 | ERROR | [ ] String concat is not required here; use a single string instead
82 | ERROR | [x] Missing function doc comment
94 | ERROR | [x] Missing function doc comment
99 | ERROR | [x] Missing function doc comment
105 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/email_attachment.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 3 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
16 | WARNING | Hook implementations should not duplicate @param documentation
16 | ERROR | Missing parameter comment
59 | ERROR | Missing short description in doc comment
65 | ERROR | Description for the @return value is missing
110 | ERROR | Doc comment is empty
113 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_encode_header_rfc_2184" but expected
| | "email_attachment__encode_header_rfc_2184"
118 | ERROR | join() is a function name alias, use implode() instead
124 | WARNING | Hook implementations should not duplicate @param documentation
124 | ERROR | Missing parameter comment
124 | ERROR | Missing parameter type
125 | WARNING | Hook implementations should not duplicate @param documentation
125 | ERROR | Missing parameter comment
125 | ERROR | Missing parameter type
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/modules/email_attachment_demo/email_attachment_demo.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
15 | WARNING | Hook implementations should not duplicate @param documentation
15 | ERROR | Missing parameter comment
----------------------------------------------------------------------------------------------------------------------------------
FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/modules/email_attachment_demo/email_attachment_demo.info.yml
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
------------------------------------------------------------------------------------------------------------------------------------
Time: 135ms; Memory: 10MB
@Mrinalini I applied your patch it applied successfully but still able to see some warning which can be fix by phpcbf.
Shiv_Sharma → created an issue.
updated the issue
Shiv_Sharma → created an issue.
Shiv_Sharma → created an issue.
Shiv_Sharma → created an issue.
patch seems working fine on my local.
adding screenshot for reference.
@shashank5563 please let me know what is the issue you observed.
#9 Patch worked
Seems some issue patch is not working for me.
Shiv_Sharma → created an issue.
MR looks good no new warning on file.
created the patch for same please review
Shiv_Sharma → created an issue.
@nishant patch applied successfully. moving to RTBC
@mrinalini9 seems readme file get update on code base due to which not able to apply patch.
could you please rebase and create a new patch for same.
error msg:
error: README.txt: No such file or directory
created the patch now no new errors form PHPCS.
Shiv_Sharma → created an issue.
#2 patch applied perfectly.
adding screenshot for reference.
The patch looks good. RTBC +
create the patch and module is working as expected. with no error.
Shiv_Sharma → created an issue.
no patch added changing status to 'need work'
#10 patch is not working
patch #5 working fine for me.
created the patch for help page
added the patch to solve the issue.
Shiv_Sharma → created an issue.
Shiv_Sharma → created an issue.
tested the MR with patch able to see readme file.
create a new patch as #2 was on old code
Created the patch adding screenshot for reference.
Shiv_Sharma → created an issue.
patch applied successfully
patch is not applying
patch applied successfully adding screenshot for refrence
patch applied successfully adding screenshot for reference
As per figma design patch #16 is working fine.
Figma design link for reference.
https://www.figma.com/file/x5zBLbvoW1jsvyAOt4Gp9I/Olivero-Theme---Public...
As per figma design patch is working.
applied the patch and able to access the module on Drupal 10 environment.
patch applied successfully. adding screenshot for refrence
Created the patch for the same and module working as expected.
Shiv_Sharma → created an issue.
Created the patch to resolve this issue. and module is working as expected.
Shiv_Sharma → created an issue.
Shiv_Sharma → created an issue.
found some problem in my patch so updated it.
Created the new patch with drupal 10 compatibility.
Created a new patch with latest code. no new warning from phpcs
created the patch for same and added Installation and Maintainers for the module.
Shiv_Sharma → created an issue.
I fixed the issue and created the patch for same and its working fine.
Shiv_Sharma → created an issue.
Created the patch and module is working as expected.
Shiv_Sharma → created an issue.
created the patch module is working as expected and also no new warning reported.
Shiv_Sharma → created an issue.
Added the patch
Shiv_Sharma → created an issue.
patch applied successfully. added the screenshot for reference
Created the patch to update hook_help page. added screenshot for reference.
Shiv_Sharma → created an issue.
Create the patch for updating readme file
Shiv_Sharma → created an issue.
Added the patch and screenshot for reference.
Shiv_Sharma → created an issue.
Created a MR need to review
Shiv_Sharma → created an issue.
@fgm I have one concern that why it is required to add <a name="foo">Foo</a>: Foo
if we are not using href in anchor tag then what is the use of <a name="foo">Foo</a>: Foo
@omkar.podey PR does have 4 unresolved threads please resolve them,
I used @Hamid.ali code to create the merge request.
I have reviewed the figma Design Figma Design with the patch color code, both are same.