Contrib.social

Drupal calls should be avoided in classes, use dependency injection instead

Open on Drupal.org →
Created on 7 August 2023, over 1 year ago

Problem/Motivation

as per drupal standred we should avoid drupal call inside class, 

 public function locationCheck($woeid = NULL, $filter = '', $unit = 'f') {
    $settings = \Drupal::config('live_weather.settings')->get('settings');
    $data = '';

Steps to reproduce

file path src/LiveWeather.php.

Proposed resolution

use dependency injection

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.5

Component

Code

Created by

🇮🇳India Shiv_Sharma

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024