Fix the warnings/errors reported by PHP_CodeSniffer

there are still remain errors related to phpcs

Remove empty comment and function name changes according to above mention comment. Please review new PR.

Seem there are more fixes need to done as after applying patch still showing phpcs warning to me.

FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/tests/src/Kernel/EmailAttachmentTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 14 LINES
----------------------------------------------------------------------------------------------------------------
  15 | ERROR | [ ] Missing member variable doc comment
  19 | ERROR | [ ] Missing short description in doc comment
  23 | ERROR | [x] Whitespace found at end of line
  24 | ERROR | [x] Missing function doc comment
  29 | ERROR | [x] Missing function doc comment
  40 | ERROR | [x] Missing function doc comment
  49 | ERROR | [x] Missing function doc comment
  62 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
  69 | ERROR | [ ] String concat is not required here; use a single string instead
  70 | ERROR | [ ] String concat is not required here; use a single string instead
  82 | ERROR | [x] Missing function doc comment
  94 | ERROR | [x] Missing function doc comment
  99 | ERROR | [x] Missing function doc comment
 105 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/email_attachment.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 3 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  16 | WARNING | Hook implementations should not duplicate @param documentation
  16 | ERROR   | Missing parameter comment
  59 | ERROR   | Missing short description in doc comment
  65 | ERROR   | Description for the @return value is missing
 110 | ERROR   | Doc comment is empty
 113 | ERROR   | All functions defined in a module file must be prefixed with the module's name, found "_encode_header_rfc_2184" but expected
     |         | "email_attachment__encode_header_rfc_2184"
 118 | ERROR   | join() is a function name alias, use implode() instead
 124 | WARNING | Hook implementations should not duplicate @param documentation
 124 | ERROR   | Missing parameter comment
 124 | ERROR   | Missing parameter type
 125 | WARNING | Hook implementations should not duplicate @param documentation
 125 | ERROR   | Missing parameter comment
 125 | ERROR   | Missing parameter type
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/modules/email_attachment_demo/email_attachment_demo.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 15 | WARNING | Hook implementations should not duplicate @param documentation
 15 | ERROR   | Missing parameter comment
----------------------------------------------------------------------------------------------------------------------------------


FILE: /home/shivsharma/project/new/web/modules/contrib/email_attachment/modules/email_attachment_demo/email_attachment_demo.info.yml
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 14 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
------------------------------------------------------------------------------------------------------------------------------------

Time: 135ms; Memory: 10MB

zniki.ru → made their first commit to this issue’s fork.

MR 1 update, please make a review.

Thanks everyone. I have merged your proposed changes, except for these points:

• I changed the names of the functions so they start with an underscore to show that they are internal, including the @internal annotation.
• I fixed the project name in `modules/email_attachment_demo/email_attachment_demo.info.yml`
• I re-added some of the `@param` annotations that were removed in this MR.

Gogowitsch → closed merge request !1

Automatically closed - issue fixed for 2 weeks with no activity.