- Issue created by @hamid.ali
- 🇮🇳India hamid.ali
Working on the issue will provide updated patch to fix the issue
- last update
over 1 year ago 29,436 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:21pm 26 June 2023 - 🇮🇳India Shiv_Sharma
I have reviewed the figma Design Figma Design with the patch color code, both are same.
Hi @Hamid.ali,
I have applied your patch but it's throwing an error.Checking patch core/themes/olivero/css/components/breadcrumb.css... error: while searching for: margin-inline: 1rem 1.25rem; content: ""; transform: rotate(45deg); /* LTR */ border-block-start: 2px solid var(--color--gray-45); border-inline-end: 2px solid var(--color--gray-45); } .breadcrumb__item:last-child { error: patch failed: core/themes/olivero/css/components/breadcrumb.css:98 error: core/themes/olivero/css/components/breadcrumb.css: patch does not apply Checking patch core/themes/olivero/css/components/breadcrumb.pcss.css... error: while searching for: margin-inline: 16px 20px; content: ""; transform: rotate(45deg); /* LTR */ border-block-start: 2px solid var(--color--gray-45); border-inline-end: 2px solid var(--color--gray-45); } &:last-child { error: patch failed: core/themes/olivero/css/components/breadcrumb.pcss.css:83 error: core/themes/olivero/css/components/breadcrumb.pcss.css: patch does not apply
- Status changed to RTBC
over 1 year ago 8:53am 30 June 2023 - 🇮🇳India lokeshsahu Delhi
I have tested and verified patch #3 on Drupal-10.1.x-dev and Drupal-11.x. The patch was applied successfully without throwing any error and it's fixing the above-addressed issue. I am attaching a screenshot for reference, showing the state before and after applying the patch.
- last update
over 1 year ago 29,436 pass, 2 fail The last submitted patch, 3: 3370131-3.patch, failed testing. View results →
- last update
over 1 year ago 29,443 pass - Merge request !4306Issue #3370131: Olivero: Fix breadcrumb Chevron icon → (Closed) created by Shiv_Sharma
- last update
over 1 year ago 29,443 pass - Status changed to Needs review
over 1 year ago 4:34am 4 July 2023 - Status changed to Postponed: needs info
over 1 year ago 9:02pm 17 July 2023 - 🇺🇸United States smustgrave
So for me this is a won't fix. The proposed change introduce accessibility issue with poor color contrast.
- Status changed to Closed: outdated
3 months ago 1:51pm 10 September 2024 - 🇺🇸United States smustgrave
Since hasn't been a follow up going to close out. If still an issue please reopen