- ๐บ๐ธUnited States loze Los Angeles
This is broken now that we are using the core/js-cookie library instead of jquery cookie. Will provide a new patch shortly
- ๐บ๐ธUnited States loze Los Angeles
This patch gets the cookies working with js-cookie. Thanks.
- Status changed to Needs review
almost 2 years ago 1:09am 9 March 2023 - ๐ฌ๐งUnited Kingdom niklp Nottingham
Would I be correct in saying that this is the part of the patch that fixes the "$.cookie is not a function" error?
-(function ($, Drupal, drupalSettings, once) { +(function ($, Drupal, drupalSettings, once, cookies) {
- ๐บ๐ธUnited States loze Los Angeles
its part of it but not all of it.
see: https://www.drupal.org/node/3104677 โ - ๐จ๐ฆCanada floydm
The config change and javascript from comment 9 work great but AFAICT the QuickTabsInstanceEditForm does not save or reflect the remember_last_clicked_tab value from the config.
The attached patch makes explicit the saving of that value.
- last update
over 1 year ago 2 pass - First commit to issue fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @keshavv opened merge request.
- last update
over 1 year ago 2 pass - ๐ฎ๐ณIndia keshavv India
The patch given in #9 and #14 failed to apply due to some recent code changes.
The patch #9 also combines the Cookie issue ๐ Replace jquery.cookie with js-cookie Postponed , Which is already fixed on latest8.x-3.x
Branch.
So I have created the MR that will only add the configuration to toggle the remember last clicked tab.
Please review the MR
Thank you. - ๐ฎ๐ณIndia sahil.goyal
Thanks @keshavv as described #9 and #14 are now getting failed and some changes already been committed.
MR!14 is working correctly and tab history should be configurable and cookie can now and confirming its working fine and no any issue has been observed, attaching screenshots for the references.
RTBC+1 - ๐ฎ๐ณIndia indrapatil Bangalore
Hi
I have tested the patch it working I attached the screenshot for reference. - Status changed to RTBC
over 1 year ago 4:34am 17 August 2023 - ๐น๐ทTurkey kburakozdemir ฤฐstanbul
patch#14 works for me. thanks. RTBC+1...
- Status changed to Needs work
13 days ago 5:58pm 10 December 2024