Keep assets directory when clearing cache

That actually was already reported in https://www.drupal.org/project/drupal/issues/3301573#comment-15139595 📌 Remove the aggregate stale file threshold and state entry Fixed

Confirmed on latest 11.x

Can reproduce off a clean install and then a cache clear as well.

Run out of time to write tests but the fix seems pretty simple.

Closed 🐛 Aggregation sometimes tries to delete non-existing directories Closed: duplicate as duplicate. Agreed we can just check file_exists() here.

I think we should consider making ::deleteRecursive() stop logging a message though, so opened 🐛 FileSystem::deleteRecursive() shouldn't log a message when it tries to delete a non-existent directory Fixed .

Not the most elegant test but it does what it needs to, couldn't find any existing test coverage of deleteAll().

Closed 🐛 The file assets://css was not deleted because it does not exist. Closed: duplicate as duplicate.

Typically such things are tested through a decorated logger that can stack logs for later. I wonder if Drupal has such a logger. There is TestSystemLoggerChannel but it covers a specific use case.

@chi This issue from yesterday I was facing in my system
$ vendor/bin/drush cr
[notice] The file assets://css was not deleted because it does not exist.
[notice] The file assets://js was not deleted because it does not exist.
[success] Cache rebuild complete.

The front end totally broke the css after that I tried disabling
Aggregate CSS files
Aggregate JavaScript files

Now the site is working but when I run the vendor/bin/drush cr
still exist errors.
[notice] The file assets://css was not deleted because it does not exist.
[notice] The file assets://js was not deleted because it does not exist.

🐛 FileSystem::deleteRecursive() shouldn't log a message when it tries to delete a non-existent directory Fixed is RTBC, I think we might be OK there, so postponing this temporarily pending that one getting committed.

Retested after 🐛 FileSystem::deleteRecursive() shouldn't log a message when it tries to delete a non-existent directory Fixed got in and we get the same result (no log) so we can close this now.