Fix the issues reported by phpcs

Open on Drupal.org →

Created on 11 July 2023, over 1 year ago

Updated 1 November 2023, about 1 year ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/flag_block

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/flag_block/src/Plugin/Block/FlagBlock.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Block\BlockBase.
51 | ERROR | [ ] Missing parameter comment
52 | ERROR | [ ] Missing parameter comment
52 | ERROR | [ ] Missing parameter type
53 | ERROR | [ ] Missing parameter comment
53 | ERROR | [ ] Missing parameter type
54 | ERROR | [ ] Missing parameter comment
55 | ERROR | [ ] Missing parameter comment
56 | ERROR | [ ] Missing parameter comment
188 | ERROR | [ ] Description for the @return value is missing
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

Time: 187ms; Memory: 10MB

Steps to reproduce
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/flag_block/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

1.4

Component

Code

Created by

🇮🇳India indrapatil Bangalore

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @indrapatil
Comment over 1 year ago →
🇮🇳India indrapatil Bangalore
@indrapatil opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago12:28pm 11 July 2023
Comment over 1 year ago →
🇮🇳India indrapatil Bangalore
Status changed to RTBC over 1 year ago1:30pm 11 July 2023
Comment over 1 year ago →
🇵🇭Philippines roberttabigue
Hi,

I reviewed the changes made by @Indrapatil and applied the latest MR to the Flag Block module against 8.x-1.4.

Confirmed it resolves the PHPCS errors.

I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig flag_block/

Please see the attached files for reference.

I'm moving this to RTBC.

Thank you!
Status changed to Fixed about 1 year ago1:21pm 1 November 2023
Comment about 1 year ago →
🇺🇦Ukraine slivorezka
Status changed to Fixed about 1 year ago1:48pm 1 November 2023
Comment about 1 year ago →
🇺🇦Ukraine slivorezka

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024