Remove remaining uses of t() in assertEquals() calls

Tagging for coding standards and moving to the 'other' component where such issues live.

📌 Strip HTML tags when using assertEquals() to compare markup Fixed landed, so this can be worked on now.

Looks like @gxleano got busy with other things.

Un-assigning per Assigning ownership of a Drupal core issue → .

Updated the IS and started a patch for this. There is no need to run the whole test suit, so I am not running the tests.

I think this is a suitable new issue, so adding the novice tag. If anyone needs help Join #coding-standards in Drupal slack.

Hi, I worked on the files which are listed in the remove_t_list.txt file. Please let me know if this is correct.
In this other than assertEquals() it has all the t() functions listed.

Please guide me if anything needs to be done.

Opened the MR for the changes in the #8 patch

failures in the MR.

Also see that we are removing t() from translation tests, don't think we want to remove those.

Chandansha → changed the visibility of the branch 3337295-remove-remaining-uses to hidden.

Chandansha → changed the visibility of the branch 3337295-remove-remaining-uses to active.

Thanks for working on this. The tests failes on the MR, so moving to Needs Work, see: https://git.drupalcode.org/project/drupal/-/merge_requests/5735/pipelines

There are coding standards issues and I think we are still removing too much t() usages - the title suggest that we should only remove "uses of t() in assertEquals() calls" (if the title is incorrect, we need to update the title). Thanks!

This issue should be scoped as per the title. See the parent issue for other removals of this function.

Akhil Babu → made their first commit to this issue’s fork.

Updated t() functions in assertEquals() calls. I have raise a new MR 5862.

core/tests/Drupal/KernelTests/Core/Element/PathElementFormTest.php

Not sure this is testing translation.

zniki.ru → made their first commit to this issue’s fork.

core/tests/Drupal/KernelTests/Core/Element/PathElementFormTest.php

In this file there is no modules related to translation.
I believe no translation testing happened.
Made changes to MR 5862.

 find core -type f -iname '*Test.php' | xargs grep '[^a-zA-Z]t(' | grep assertE | awk -F: '{print $1}' | sort -u | nl

     1  core/modules/locale/tests/src/Functional/LocaleTranslationUiTest.php
     2  core/modules/locale/tests/src/Functional/LocaleUpdateTest.php
     3  core/tests/Drupal/FunctionalTests/Installer/InstallerTranslationMultipleLanguageNonInteractiveTest.php

My bad, didn't notice "novice" tag.

This actually seemed correct https://git.drupalcode.org/project/drupal/-/merge_requests/5862/diffs?co.... don't think we are testing that the Submit button is translated here.

@smustgrave you are right.
But this issue is about only removing t() in assertEquals().
That's why I remove it from MR.

Good point.

Thanks! This cleans up the remaining uses in assertEquals() and makes the tests a little bit easier to read in most cases, leaving only some tests that explicitly test translations.

Backported to 10.2.x as a tests-only cleanup.

Committed and pushed d9f34709f9 to 11.x and dca79fb044 to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.