Fix the issues reported by phpcs

Open on Drupal.org →

Created on 11 July 2023, over 1 year ago

Updated 28 June 2024, 5 months ago

Problem/Motivation
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/security_review.module
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\security_review\Checks\NamePasswords.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/Checks/NamePasswords.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
19 | ERROR | [x] Missing function doc comment
51 | ERROR | [x] Expected 1 space after "="; 2 found
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/Checks/Field.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------
91 | ERROR | [x] Expected 1 space after "="; 2 found
109 | ERROR | [x] Each PHP statement must be on a line by itself
110 | ERROR | [x] Inline comments must start with a capital letter
110 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
115 | WARNING | [ ] Unused variable $test.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/Checks/ViewsAccess.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
22 | ERROR | [x] Expected 1 blank line after function; 2 found
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/Checks/TrustedHosts.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
19 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/CheckSettings/NamePasswordsSettings.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
21 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/src/CheckSettings/ViewSettings.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
21 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/config/install/security_review.checks.yml
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

Time: 1.75 secs; Memory: 14MB

Steps to reproduce
Run this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/security_review/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇮🇳India indrapatil Bangalore

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

!42Fix the issues reported by phpcs
Closed
Unnamed author
updated 5 months ago

Comments & Activities

Issue created by @indrapatil
Merge request !42Fixed the coding standards. → (Closed) created by Unnamed author
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
15 pass
Issue was unassigned.
Status changed to Needs review over 1 year ago9:29am 11 July 2023
Comment over 1 year ago →
🇮🇳India indrapatil Bangalore
With this patch, the some of issues will fix
https://www.drupal.org/project/security_review/issues/3370990 📌 t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead Closed: won't fix
Status changed to Closed: won't fix over 1 year ago12:28pm 11 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
I don’t give credit for issues like this. I’ve reported this issue as it’s a farming technique that brings nothing but noise to the community.
Comment 5 months ago →
System Message
smustgrave → closed merge request !42

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024