I saw that in the query where we get the available points for a customer, the validity is always checked for the current date:
$query->condition('field_validity_date.value', gmdate('Y-m-d'), '>=');
This means if I get points that the seller gave me and no validity date was set for it, I can never use that.
This should be an < field > IS NULL OR < condition > in the query just like this:
$validityCondition = $query->orConditionGroup();
$validityCondition->notExists('field_validity_date.value');
$validityCondition->condition('field_validity_date.value', gmdate('Y-m-d'), '>=');
$query->condition($validityCondition);
Fixed
9.0
Code
Changes are added in 3.0.x branch, thanks for the MR.