- Issue created by @sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 9:11am 3 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
In the case of a bug, the description should also list the steps necessary to reproduce the issue, starting from when the module/theme is installed.Since those issues are reported by PHP_CodeSniffer, why does not this issue fix all the warnings/errors reported by PHP_CodeSniffer?
- Assigned to imustakim
- 🇮🇳India imustakim Ahmedabad
Issue summary updated.
Added coding standard tag to the issue. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:00pm 23 July 2023 - 🇮🇳India imustakim Ahmedabad
Fixed all the coding standard issues.
Patch updated and interdiff attached.
Please review. - Status changed to RTBC
over 1 year ago 5:07pm 28 July 2023 - 🇵🇭Philippines roberttabigue
Hi,
I reviewed the changes and confirmed that Patch #6 was applied cleanly to the Group Message module against 1.0.x-dev on Drupal 9.5.10.
Checking patch src/Plugin/Group/Relation/GroupMessage.php... Checking patch src/Plugin/Group/Relation/GroupMessageDeriver.php... Checking patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php... Applied patch src/Plugin/Group/Relation/GroupMessage.php cleanly. Applied patch src/Plugin/Group/Relation/GroupMessageDeriver.php cleanly. Applied patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml gmessage/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!