- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
12 months ago 10:19am 18 July 2023 - Status changed to Needs work
12 months ago 1:52pm 18 July 2023 - 🇵🇭Philippines clarkssquared
Hi arti_parmar
I applied and reviewed your patch #2 and I noticed that your patch didn't fix all the PHPCS errors, hence below is the remaining error that is shown in my terminal
FILE: /Users/studenttrainees/sector_layout/sector_layout.module
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
11 | ERROR | sector_layout_install() is an installation hook and must be declared in an install file
------------------------------------------------------------------------------------------------------Time: 180ms; Memory: 10MB
Please look at the screenshot I attached for your reference
Thank you.
- First commit to issue fork.
- @imustakim opened merge request.
- Status changed to Needs review
11 months ago 12:38pm 8 August 2023 - Status changed to RTBC
11 months ago 3:57pm 13 August 2023 - 🇮🇳India aayushDrupal
Hi @imustakim,
I have reviewed this issue in drupal version 10.1.x by following steps :
1) git clone --branch '1.0.x' https://git.drupalcode.org/project/sector_layout.git
2) cd sector_layout
3) ran phpcs command../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ../sector_layout/
4) Add and fetch MR !1- git remote add sector_layout-3375208 git@git.drupal.org:issue/sector_layout-3375208.git
- git fetch sector_layout-3375208
5) git checkout -b '3375208-fix-the-issue' --track sector_layout-3375208/'3375208-fix-the-issue'
6) I ran the phpcs command once more and did not find any errors. I have attached a screenshot for your reference. Also moving status to RTBC.