Fix the issues reported by phpcs

Hi @urvashi_vora,

I reviewed the changes and confirmed the Patch was applied cleanly.

Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.

However, I'm still seeing a couple of phpcs errors:

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/informea_api/README.md
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
  98 | WARNING | Line exceeds 80 characters; contains 104 characters
 100 | WARNING | Line exceeds 80 characters; contains 110 characters
--------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/informea_api/src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 48 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 513ms; Memory: 10MB

Moving this to Needs work.

Thank you.

  98 | WARNING | Line exceeds 80 characters; contains 104 characters
 100 | WARNING | Line exceeds 80 characters; contains 110 characters 

These two are commands so that needs to be in same line for a better understanding.
Updated the 3rd issue.
Please review.

Marking it to Needs Review, so that the patch could be reviewed.

Hi @sakthi_dev

I applied your Patch and confirmed it resolves the other PHPCS errors.

Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.

However, the errors regarding the "line exceeds" still exist.

Please see the attached file for your reference.

Moving this again to "Needs work".
Thank you!

Please review.

Hi @sakthi_dev,

Confirmed your Patch was applied cleanly.

Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.

However, I'm seeing new PHPCS errors, and the errors for the "line exceeds" have been fixed already.

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/informea_api/src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
 58 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
 59 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 493ms; Memory: 10MB

Assigning to Needs work for the investigation.
Thank you!

Updated patch #6 by addressing #7, please review it.

Thanks!

fields to the view, use the serializable versions of the fields(e.g. Title
+(serializable)).

There is a missing space before the parenthesis.

   /**
+   * Get the legislation relations.

The verb must be declined in the third person singular.

       '@use_keys' => $this->getSetting('use_keys')
-        ? $this->t('Yes')
-        : $this->t('No'),
+      ? $this->t('Yes')
+      : $this->t('No'),

The code is already correctly indented.

-   * @return boolean
+   * @return bool
    *   Yes if the string field value is yes.

Since that comment is changed, the return value description must be changed too: The Boolean values are TRUE and FALSE. That method cannot return Yes, which is not a constant PHP uses for Boolean values.

-    $value = isset($mapping[$field_value]) ? $mapping[$field_value] : NULL;
+    $value = isset($mapping[$field_value]) ?? NULL;

If the null coalescing operator is used, isset() is not used.

I faced some issue while creating the merge request.
So Updating the patch, please review. Address all the issue mentioned in #9 📌 Fix the issues reported by phpcs Needs review .

Hi,

I reviewed the changes made in #12 to address the issues mentioned in #9, and confirmed that Patch #12 was applied cleanly to the module.

Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.

And no PHPCS errors have been detected.

Please see the attached file for reference.

I'm moving this now to RTBC.

Thank you!

Can't show this merge request because the target branch 1.0.0-alpha1 is missing from project issue/informea_api-3371902. Close this merge request or update the target branch.

1.0.0-alpha1 is not a branch.

bindu r → made their first commit to this issue’s fork.

Updated IS with the remaining issues.

Updating IS for the remaining issue.

Please review. Thanks.

silvi.addweb → made their first commit to this issue’s fork.

apaderno → changed the visibility of the branch 3371902- to hidden.

GitLab CI does not report any PHP_CodeSniffer warning/error. MR!2 fixed all of them.