- Issue created by @sonam_sharma
- Status changed to RTBC
over 1 year ago 3:23pm 18 July 2023 - ๐ต๐ญPhilippines clarkssquared
Hi sonam_sharma
I applied your patch #4 to my local and I confirmed that your patch fixed all the PHPCS errors/issues of the module.
please look at the screenshot I attached for your reference
Thank you
- Status changed to Needs work
over 1 year ago 3:53pm 19 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Status changed to Needs review
over 1 year ago 9:44pm 23 July 2023 - Status changed to RTBC
over 1 year ago 1:19pm 15 August 2023 - ๐ฎ๐ณIndia aayushDrupal
Hi,
I conducted a test by implementing patch #4 and executing the following command
../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ../autogrow_textarea/
After thorough examination, I did not found any errors. Therefore, I am changing the status to RTBC. Screenshot is attached for your reference.
- ๐ฎ๐ณIndia akshay.singh Noida
akshay.singh โ made their first commit to this issueโs fork.
- Assigned to akshay.singh
- Status changed to Needs work
over 1 year ago 7:56am 16 August 2023 - ๐ฎ๐ณIndia akshay.singh Noida
+/** + * @file + * Module autogrow_textarea. + */
this is not the right info for the file.
/** * Implements hook_element_info_alter(). * * Adds autogrow_textarea.js as attached JavaScript to each textarea. */
these are the generic hooks not specific to piece of code, one shouldn't add this in function doc it must be added as commenting.
new_3374628.patch
not the right naming convention for a patch.
- Merge request !1Issue #3374628: Fix the issues reported by phpcs โ (Merged) created by akshay.singh
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:16am 16 August 2023 - ๐ฎ๐ณIndia akshay.singh Noida
All points incorporated.
Please review.
Thanks
- Status changed to Needs work
over 1 year ago 11:28am 17 August 2023 - Status changed to Needs review
over 1 year ago 7:23am 18 August 2023 - Status changed to Needs work
over 1 year ago 10:59am 18 August 2023 - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:57am 22 August 2023 - First commit to issue fork.
-
RobLoach โ
committed 6ee8dd1e on 2.0.x authored by
akshay.singh โ
Issue #3374628: Fix the issues reported by phpcs
-
RobLoach โ
committed 6ee8dd1e on 2.0.x authored by
akshay.singh โ
- Status changed to Fixed
8 months ago 5:57pm 28 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.