Fix the PHP_CodeSniffer issues reported by GitLab CI

Created on 14 February 2019, almost 6 years ago
Updated 14 August 2024, 3 months ago
šŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Deeksha B

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work about 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    A summary must describe what needs to be changed, and eventually why. A screenshot is not sufficient, even in the case a patch/MR is provided.
    In the case of bug reports, the steps to reproduce the bug should be provided too. In the case of coding standards issues found using an automatic tool, the report given by that tool be quoted too, including the arguments passed to that tool, if it is a command line tool.

  • Assigned to imustakim
  • šŸ‡®šŸ‡³India imustakim Ahmedabad

    Issue summary updated.

  • šŸ‡®šŸ‡³India imustakim Ahmedabad

    Updated patch and issue summary with css, js errors.
    Please review.

  • Issue was unassigned.
  • šŸ‡®šŸ‡³India imustakim Ahmedabad
  • Status changed to Needs review about 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Hi, patch #10 applied cleanly, and it is showing some whitespace warning.

     git apply -v 3033027-10.patch                                                 Checking patch businessplus_lite.theme...
    Checking patch config/install/block.block.businessplus_lite_breadcrumbs.yml...
    Checking patch css/base/elements.css...
    Checking patch css/components/buttons.css...
    Checking patch css/components/call-to-action.css...
    Checking patch css/components/detailed-feature-block.css...
    Checking patch css/components/dropdowns.css...
    Checking patch css/components/fa-icons-list.css...
    Checking patch css/components/icons-list.css...
    Checking patch css/components/menu.css...
    Checking patch css/components/messages.css...
    Checking patch css/components/pricing-tables.css...
    Checking patch css/components/progress-bars.css...
    Checking patch css/components/slideout.css...
    Checking patch css/components/to-bottom-button.css...
    Checking patch css/components/username.css...
    Checking patch css/components/views.css...
    Checking patch css/theme/color-blue.css...
    Checking patch css/theme/color-green.css...
    Checking patch css/theme/local-theme.css...
    3033027-10.patch:2967: new blank line at EOF.
    Checking patch js/init/flexslider-in-page-init.js...
    Checking patch js/init/magnific-popup-field-image-init.js...
    Checking patch js/init/owl-carousel-features-slideshow-init.js...
    Checking patch js/init/owl-carousel-testimonials-init.js...
    Checking patch js/init/slideout-init.js...
    Checking patch js/init/waypoints-animations-init.js...
    Checking patch js/init/waypoints-fixed-header-init.js...
    Applied patch businessplus_lite.theme cleanly.
    Applied patch config/install/block.block.businessplus_lite_breadcrumbs.yml cleanly.
    Applied patch css/base/elements.css cleanly.
    Applied patch css/components/buttons.css cleanly.
    Applied patch css/components/call-to-action.css cleanly.
    Applied patch css/components/detailed-feature-block.css cleanly.
    Applied patch css/components/dropdowns.css cleanly.
    Applied patch css/components/fa-icons-list.css cleanly.
    Applied patch css/components/icons-list.css cleanly.
    Applied patch css/components/menu.css cleanly.
    Applied patch css/components/messages.css cleanly.
    Applied patch css/components/pricing-tables.css cleanly.
    Applied patch css/components/progress-bars.css cleanly.
    Applied patch css/components/slideout.css cleanly.
    Applied patch css/components/to-bottom-button.css cleanly.
    Applied patch css/components/username.css cleanly.
    Applied patch css/components/views.css cleanly.
    Applied patch css/theme/color-blue.css cleanly.
    Applied patch css/theme/color-green.css cleanly.
    Applied patch css/theme/local-theme.css cleanly.
    Applied patch js/animate/animate.css cleanly.
    Applied patch js/custom/in-page-navigation-scroll.js cleanly.
    Applied patch js/custom/to-top.js cleanly.
    Applied patch js/flexslider/changelog.txt cleanly.
    Applied patch js/flexslider/jquery.flexslider.js cleanly.
    Applied patch js/init/flexslider-in-page-init.js cleanly.
    Applied patch js/init/magnific-popup-field-image-init.js cleanly.
    Applied patch js/init/owl-carousel-features-slideshow-init.js cleanly.
    Applied patch js/init/owl-carousel-testimonials-init.js cleanly.
    Applied patch js/init/slideout-init.js cleanly.
    Applied patch js/init/waypoints-animations-init.js cleanly.
    Applied patch js/init/waypoints-fixed-header-init.js cleanly.
    Applied patch js/magnific-popup/jquery.magnific-popup.js cleanly.
    Applied patch js/owl-carousel/assets/owl.carousel.css cleanly.
    Applied patch js/owl-carousel/assets/owl.theme.default.css cleanly.
    Applied patch js/owl-carousel/assets/owl.theme.green.css cleanly.
    Applied patch js/owl-carousel/owl.carousel.js cleanly.
    Applied patch js/slideout/slideout.css cleanly.
    Applied patch js/waypoints/jquery.waypoints.js cleanly.
    Applied patch js/waypoints/shortcuts/inview.js cleanly.
    Applied patch js/waypoints/shortcuts/sticky.js cleanly.
    Applied patch theme-settings.php cleanly.
    warning: 1 line adds whitespace errors.
    

    Thankyou.

  • Status changed to Needs work 3 months ago
  • Hi @imustakim,

    The patch you applied was applied not-so successfully, massive errors were still reported. Please see below:

     businessplus_lite git:(8.x-1.0) curl https://www.drupal.org/files/issues/2023-10-24/3033027-10.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  503k  100  503k    0     0   894k      0 --:--:-- --:--:-- --:--:--  911k
    patching file businessplus_lite.theme
    Hunk #1 FAILED at 1.
    Hunk #2 succeeded at 14 (offset -1 lines).
    Hunk #3 succeeded at 48 (offset -1 lines).
    Hunk #4 succeeded at 69 (offset -1 lines).
    Hunk #5 FAILED at 100.
    Hunk #6 succeeded at 175 (offset -1 lines).
    Hunk #7 succeeded at 214 (offset -1 lines).
    Hunk #8 succeeded at 286 (offset -1 lines).
    Hunk #9 succeeded at 374 (offset -1 lines).
    Hunk #10 succeeded at 391 (offset -1 lines).
    Hunk #11 succeeded at 442 (offset -1 lines).
    Hunk #12 succeeded at 618 (offset -1 lines).
    Hunk #13 succeeded at 637 (offset -1 lines).
    Hunk #14 succeeded at 651 (offset -1 lines).
    Hunk #15 succeeded at 673 (offset -1 lines).
    Hunk #16 succeeded at 695 (offset -1 lines).
    Hunk #17 succeeded at 720 (offset -1 lines).
    Hunk #18 succeeded at 777 (offset -1 lines).
    Hunk #19 succeeded at 808 (offset -1 lines).
    Hunk #20 succeeded at 820 (offset -1 lines).
    Hunk #21 succeeded at 831 (offset -1 lines).
    Hunk #22 succeeded at 842 (offset -1 lines).
    Hunk #23 succeeded at 853 (offset -1 lines).
    Hunk #24 succeeded at 864 (offset -1 lines).
    Hunk #25 succeeded at 877 (offset -1 lines).
    Hunk #26 succeeded at 892 (offset -1 lines).
    2 out of 26 hunks FAILED -- saving rejects to file businessplus_lite.theme.rej
    patching file config/install/block.block.businessplus_lite_breadcrumbs.yml
    patching file css/base/elements.css
    patching file css/components/buttons.css
    patching file css/components/call-to-action.css
    patching file css/components/detailed-feature-block.css
    patching file css/components/dropdowns.css
    patching file css/components/fa-icons-list.css
    patching file css/components/icons-list.css
    patching file css/components/menu.css
    patching file css/components/messages.css
    patching file css/components/pricing-tables.css
    patching file css/components/progress-bars.css
    patching file css/components/slideout.css
    patching file css/components/to-bottom-button.css
    patching file css/components/username.css
    patching file css/components/views.css
    patching file css/theme/color-blue.css
    patching file css/theme/color-green.css
    patching file css/theme/local-theme.css
    patching file js/animate/animate.css
    patching file js/custom/in-page-navigation-scroll.js
    patching file js/custom/to-top.js
    patching file js/flexslider/changelog.txt
    patching file js/flexslider/jquery.flexslider.js
    patching file js/init/flexslider-in-page-init.js
    patching file js/init/magnific-popup-field-image-init.js
    patching file js/init/owl-carousel-features-slideshow-init.js
    patching file js/init/owl-carousel-testimonials-init.js
    patching file js/init/slideout-init.js
    patching file js/init/waypoints-animations-init.js
    patching file js/init/waypoints-fixed-header-init.js
    patching file js/magnific-popup/jquery.magnific-popup.js
    patching file js/owl-carousel/assets/owl.carousel.css
    patching file js/owl-carousel/assets/owl.theme.default.css
    patching file js/owl-carousel/assets/owl.theme.green.css
    patching file js/owl-carousel/owl.carousel.js
    patching file js/slideout/slideout.css
    patching file js/waypoints/jquery.waypoints.js
    patching file js/waypoints/shortcuts/inview.js
    patching file js/waypoints/shortcuts/sticky.js
    patching file theme-settings.php
    āžœ  businessplus_lite git:(8.x-1.0) āœ— ..
    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig businessplus_lite
    
    
    FILE: ...-orgissue/web/modules/contrib/businessplus_lite/businessplus_lite.info.yml
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     1 | WARNING | "core_version_requirement" property is missing in the info.yml
       |         | file
    --------------------------------------------------------------------------------
    
    
    FILE: ...rgissue/web/modules/contrib/businessplus_lite/css/components/accordion.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     124 | ERROR | Class definition is empty
    --------------------------------------------------------------------------------
    
    
    FILE: ...e/web/modules/contrib/businessplus_lite/css/components/inverted-header.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     53 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...ssue/web/modules/contrib/businessplus_lite/css/components/social-links.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     41 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...gissue/web/modules/contrib/businessplus_lite/css/components/highlights.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     106 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...web/modules/contrib/businessplus_lite/css/components/language-switcher.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     20 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...pal-orgissue/web/modules/contrib/businessplus_lite/css/components/menu.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     666 | ERROR | Class definition is empty
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-green.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...al-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-gold.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-khaki.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-orange.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...ue/web/modules/contrib/businessplus_lite/css/theme/color-purple-orange.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     87 | ERROR | Style definitions must end with a semicolon
     94 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...issue/web/modules/contrib/businessplus_lite/css/theme/color-night-blue.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue/web/modules/contrib/businessplus_lite/css/theme/local-theme.css
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     1 | ERROR | [x] Additional whitespace found at start of file
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...al-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-gray.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...pal-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-red.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...al-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-pink.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...al-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-blue.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...-orgissue/web/modules/contrib/businessplus_lite/css/theme/color-purple.css
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
     100 | ERROR | Style definitions must end with a semicolon
     108 | ERROR | Style definitions must end with a semicolon
    --------------------------------------------------------------------------------
    
    
    FILE: ...web/modules/contrib/businessplus_lite/js/magnific-popup/magnific-popup.css
    --------------------------------------------------------------------------------
    FOUND 162 ERRORS AFFECTING 135 LINES
    --------------------------------------------------------------------------------
      11 | ERROR | [x] Closing brace of class definition must be on new line
      21 | ERROR | [x] Closing brace of class definition must be on new line
      31 | ERROR | [x] Closing brace of class definition must be on new line
      37 | ERROR | [x] Closing brace of class definition must be on new line
      40 | ERROR | [x] Closing brace of class definition must be on new line
      48 | ERROR | [x] Closing brace of class definition must be on new line
      53 | ERROR | [x] Closing brace of class definition must be on new line
      56 | ERROR | [x] Closing brace of class definition must be on new line
      58 | ERROR | [x] Multiple selectors should each be on a single line
      61 | ERROR | [x] Closing brace of class definition must be on new line
      67 | ERROR | [x] Closing brace of class definition must be on new line
      70 | ERROR | [x] Closing brace of class definition must be on new line
      78 | ERROR | [x] Closing brace of class definition must be on new line
      81 | ERROR | [x] Closing brace of class definition must be on new line
      84 | ERROR | [x] Closing brace of class definition must be on new line
      87 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but
         |       |     found #CCC
      95 | ERROR | [x] Closing brace of class definition must be on new line
      96 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
      97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      97 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but
         |       |     found #CCC
      97 | ERROR | [x] Closing brace of class definition must be on new line
      98 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
      99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
      99 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but
         |       |     found #FFF
      99 | ERROR | [x] Closing brace of class definition must be on new line
     102 | ERROR | [x] Closing brace of class definition must be on new line
     105 | ERROR | [x] Closing brace of class definition must be on new line
     119 | ERROR | [x] Closing brace of class definition must be on new line
     123 | ERROR | [x] Closing brace of class definition must be on new line
     136 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but
         |       |     found #FFF
     139 | ERROR | [x] Closing brace of class definition must be on new line
     140 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     141 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     142 | ERROR | [x] Closing brace of class definition must be on new line
     143 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     144 | ERROR | [x] Closing brace of class definition must be on new line
     147 | ERROR | [x] Closing brace of class definition must be on new line
     151 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but
         |       |     found #FFF
     155 | ERROR | [x] Closing brace of class definition must be on new line
     161 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but
         |       |     found #CCC
     164 | ERROR | [x] Closing brace of class definition must be on new line
     175 | ERROR | [x] Closing brace of class definition must be on new line
     176 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     177 | ERROR | [x] Closing brace of class definition must be on new line
     178 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     179 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     180 | ERROR | [x] Closing brace of class definition must be on new line
     181 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     182 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     192 | ERROR | [x] Closing brace of class definition must be on new line
     193 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     196 | ERROR | [x] Closing brace of class definition must be on new line
     197 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     200 | ERROR | [x] Closing brace of class definition must be on new line
     203 | ERROR | [x] Closing brace of class definition must be on new line
     204 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     205 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but
         |       |     found #FFF
     206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     206 | ERROR | [x] Closing brace of class definition must be on new line
     207 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     209 | ERROR | [x] CSS colours must be defined in lowercase; expected #3f3f3f
         |       |     but found #3F3F3F
     209 | ERROR | [x] Closing brace of class definition must be on new line
     212 | ERROR | [x] Closing brace of class definition must be on new line
     213 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     214 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but
         |       |     found #FFF
     215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     215 | ERROR | [x] Closing brace of class definition must be on new line
     216 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     217 | ERROR | [x] CSS colours must be defined in lowercase; expected #3f3f3f
         |       |     but found #3F3F3F
     217 | ERROR | [x] Closing brace of class definition must be on new line
     221 | ERROR | [x] Closing brace of class definition must be on new line
     222 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     225 | ERROR | [x] Closing brace of class definition must be on new line
     226 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     227 | ERROR | [x] Closing brace of class definition must be on new line
     233 | ERROR | [x] Closing brace of class definition must be on new line
     234 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     237 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     242 | ERROR | [x] Closing brace of class definition must be on new line
     253 | ERROR | [x] Closing brace of class definition must be on new line
     257 | ERROR | [x] Closing brace of class definition must be on new line
     258 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     259 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     260 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     261 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     262 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     263 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     264 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     265 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     267 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     269 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     270 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     270 | ERROR | [x] Closing brace of class definition must be on new line
     271 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     272 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     272 | ERROR | [x] CSS colours must be defined in lowercase; expected #bdbdbd
         |       |     but found #BDBDBD
     273 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     274 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     275 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     275 | ERROR | [x] Closing brace of class definition must be on new line
     276 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
     277 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     277 | ERROR | [x] Closing brace of class definition must be on new line
     285 | ERROR | [x] Closing brace of class definition must be on new line
     290 | ERROR | [x] CSS colours must be defined in lowercase; expected #f3f3f3
         |       |     but found #F3F3F3
     292 | ERROR | [x] Closing brace of class definition must be on new line
     295 | ERROR | [x] Closing brace of class definition must be on new line
     298 | ERROR | [x] Closing brace of class definition must be on new line
     302 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
     303 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
     306 | ERROR | [x] Closing brace of class definition must be on new line
     308 | ERROR | [x] Closing brace of class definition must be on new line
     311 | ERROR | [x] Closing brace of class definition must be on new line
     314 | ERROR | [x] Closing brace of class definition must be on new line
     322 | ERROR | [x] Closing brace of class definition must be on new line
     323 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     324 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
     324 | ERROR | [x] Closing brace of class definition must be on new line
     327 | ERROR | [x] Closing brace of class definition must be on new line
     337 | ERROR | [x] Closing brace of class definition must be on new line
     342 | ERROR | [x] Closing brace of class definition must be on new line
     345 | ERROR | [x] Closing brace of class definition must be on new line
     348 | ERROR | [x] Closing brace of class definition must be on new line
     351 | ERROR | [x] Closing brace of class definition must be on new line
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 162 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...orgissue/web/modules/contrib/businessplus_lite/js/flexslider/changelog.txt
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------------
     13 | WARNING | Line exceeds 80 characters; contains 103 characters
     33 | WARNING | Line exceeds 80 characters; contains 96 characters
     36 | WARNING | Line exceeds 80 characters; contains 111 characters
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue/web/modules/contrib/businessplus_lite/js/owl-carousel/README.md
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------------
     37 | WARNING | Line exceeds 80 characters; contains 92 characters
     41 | WARNING | Line exceeds 80 characters; contains 96 characters
     44 | WARNING | Line exceeds 80 characters; contains 114 characters
     61 | WARNING | Line exceeds 80 characters; contains 166 characters
     74 | WARNING | Line exceeds 80 characters; contains 116 characters
     95 | WARNING | Line exceeds 80 characters; contains 81 characters
     98 | WARNING | Line exceeds 80 characters; contains 100 characters
    --------------------------------------------------------------------------------
    
    
    FILE: ...web/modules/contrib/businessplus_lite/templates/maintenance-page.html.twig
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     138 | ERROR | [x] Expected 1 newline at end of file; 0 found
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...pal-orgissue/web/modules/contrib/businessplus_lite/businessplus_lite.theme
    --------------------------------------------------------------------------------
    FOUND 47 ERRORS AND 9 WARNINGS AFFECTING 50 LINES
    --------------------------------------------------------------------------------
       1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank
         |         |     line
       7 | WARNING | [x] Unused use statement
       8 | ERROR   | [x] Use statements should be sorted alphabetically. The first
         |         |     wrong one is Drupal\Core\Form\FormStateInterface.
      10 | WARNING | [x] Unused use statement
      11 | WARNING | [x] Unused use statement
      12 | WARNING | [x] Unused use statement
      13 | WARNING | [x] Unused use statement
      21 | ERROR   | [ ] Doc comment is empty
      85 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
      91 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
     107 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     110 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     117 | ERROR   | [x] No space found before comment text; expected "// Load
         |         |     fixed-header library" but found "//Load fixed-header
         |         |     library"
     117 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     124 | ERROR   | [x] No space found before comment text; expected "// Load
         |         |     page-container-border" but found "//Load
         |         |     page-container-border"
     124 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     131 | ERROR   | [x] Concat operator must be surrounded by a single space
     133 | ERROR   | [x] No space found before comment text; expected "// Load
         |         |     transparent-header library" but found "//Load
         |         |     transparent-header library"
     133 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     139 | ERROR   | [x] No space found before comment text; expected "// Inverted
         |         |     header state" but found "//Inverted header state"
     139 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     146 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     148 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced
         |         |     with use statements
     152 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
         |         |     question marks, colons, or closing parentheses
     161 | ERROR   | [x] Missing function doc comment
     161 | ERROR   | [x] Expected 1 space before opening brace; found 0
     164 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
     164 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
     169 | ERROR   | [x] Short array syntax must be used to define arrays
     170 | WARNING | [x] A comma should follow the last multiline array item.
         |         |     Found: $page_title
     182 | ERROR   | [ ] Doc comment is empty
     191 | ERROR   | [ ] The array declaration extends to column 127 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     198 | ERROR   | [ ] Doc comment is empty
     202 | ERROR   | [ ] Doc comment is empty
     712 | ERROR   | [ ] Doc comment is empty
     716 | ERROR   | [ ] Doc comment is empty
     722 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced
         |         |     with use statements
     727 | WARNING | [ ] Unused variable $path_args.
     736 | ERROR   | [ ] Doc comment is empty
     740 | ERROR   | [ ] Doc comment is empty
     769 | ERROR   | [ ] Doc comment is empty
     790 | ERROR   | [ ] Doc comment is empty
     794 | ERROR   | [ ] Doc comment is empty
     815 | ERROR   | [ ] Doc comment is empty
     827 | ERROR   | [ ] Doc comment is empty
     838 | ERROR   | [ ] Doc comment is empty
     849 | ERROR   | [ ] Doc comment is empty
     860 | ERROR   | [ ] Doc comment is empty
     871 | ERROR   | [ ] Doc comment is empty
     884 | ERROR   | [ ] Doc comment is empty
     898 | ERROR   | [ ] Doc comment is empty
     902 | ERROR   | [ ] Doc comment is empty
     911 | ERROR   | [ ] Doc comment is empty
     915 | ERROR   | [ ] Doc comment is empty
     922 | ERROR   | [ ] Doc comment is empty
     926 | ERROR   | [ ] Doc comment is empty
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 28 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...e/drupal-orgissue/web/modules/contrib/businessplus_lite/theme-settings.php
    --------------------------------------------------------------------------------
    FOUND 36 ERRORS AND 1 WARNING AFFECTING 33 LINES
    --------------------------------------------------------------------------------
      3 | ERROR   | Missing short description in doc comment
     10 | ERROR   | Doc comment short description must start with a capital letter
     10 | ERROR   | Doc comment short description must end with a full stop
     13 | ERROR   | The array declaration extends to column 132 (the limit is 120).
        |         | The array content should be split up over multiple lines
     15 | ERROR   | The array declaration extends to column 176 (the limit is 120).
        |         | The array content should be split up over multiple lines
     16 | ERROR   | The array declaration extends to column 562 (the limit is 120).
        |         | The array content should be split up over multiple lines
     17 | ERROR   | The array declaration extends to column 169 (the limit is 120).
        |         | The array content should be split up over multiple lines
     18 | ERROR   | The array declaration extends to column 375 (the limit is 120).
        |         | The array content should be split up over multiple lines
     19 | ERROR   | The array declaration extends to column 571 (the limit is 120).
        |         | The array content should be split up over multiple lines
     20 | ERROR   | The array declaration extends to column 171 (the limit is 120).
        |         | The array content should be split up over multiple lines
     21 | ERROR   | The array declaration extends to column 337 (the limit is 120).
        |         | The array content should be split up over multiple lines
     22 | ERROR   | The array declaration extends to column 170 (the limit is 120).
        |         | The array content should be split up over multiple lines
     23 | ERROR   | The array declaration extends to column 528 (the limit is 120).
        |         | The array content should be split up over multiple lines
     23 | ERROR   | The array declaration extends to column 527 (the limit is 120).
        |         | The array content should be split up over multiple lines
     24 | ERROR   | The array declaration extends to column 174 (the limit is 120).
        |         | The array content should be split up over multiple lines
     24 | WARNING | Avoid backslash escaping in translatable strings when possible,
        |         | use "" quotes instead
     25 | ERROR   | The array declaration extends to column 581 (the limit is 120).
        |         | The array content should be split up over multiple lines
     25 | ERROR   | The array declaration extends to column 580 (the limit is 120).
        |         | The array content should be split up over multiple lines
     26 | ERROR   | The array declaration extends to column 374 (the limit is 120).
        |         | The array content should be split up over multiple lines
     27 | ERROR   | The array declaration extends to column 172 (the limit is 120).
        |         | The array content should be split up over multiple lines
     28 | ERROR   | The array declaration extends to column 403 (the limit is 120).
        |         | The array content should be split up over multiple lines
     29 | ERROR   | The array declaration extends to column 161 (the limit is 120).
        |         | The array content should be split up over multiple lines
     30 | ERROR   | The array declaration extends to column 397 (the limit is 120).
        |         | The array content should be split up over multiple lines
     31 | ERROR   | The array declaration extends to column 167 (the limit is 120).
        |         | The array content should be split up over multiple lines
     32 | ERROR   | The array declaration extends to column 397 (the limit is 120).
        |         | The array content should be split up over multiple lines
     33 | ERROR   | The array declaration extends to column 173 (the limit is 120).
        |         | The array content should be split up over multiple lines
     34 | ERROR   | The array declaration extends to column 407 (the limit is 120).
        |         | The array content should be split up over multiple lines
     35 | ERROR   | The array declaration extends to column 164 (the limit is 120).
        |         | The array content should be split up over multiple lines
     36 | ERROR   | The array declaration extends to column 397 (the limit is 120).
        |         | The array content should be split up over multiple lines
     37 | ERROR   | The array declaration extends to column 180 (the limit is 120).
        |         | The array content should be split up over multiple lines
     38 | ERROR   | The array declaration extends to column 408 (the limit is 120).
        |         | The array content should be split up over multiple lines
     39 | ERROR   | The array declaration extends to column 202 (the limit is 120).
        |         | The array content should be split up over multiple lines
     40 | ERROR   | The array declaration extends to column 430 (the limit is 120).
        |         | The array content should be split up over multiple lines
     41 | ERROR   | The array declaration extends to column 161 (the limit is 120).
        |         | The array content should be split up over multiple lines
     42 | ERROR   | The array declaration extends to column 392 (the limit is 120).
        |         | The array content should be split up over multiple lines
     43 | ERROR   | The array declaration extends to column 171 (the limit is 120).
        |         | The array content should be split up over multiple lines
     44 | ERROR   | The array declaration extends to column 396 (the limit is 120).
        |         | The array content should be split up over multiple lines
    --------------------------------------------------------------------------------
    
    Time: 4.01 secs; Memory: 36MB

    Kindly check

    Thanks,
    Jake

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's create a merge request, now that patches are no longer tested, and enable GitLab CI for the merge request.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    3 months ago
    Total: 3688s
    #253783
  • First commit to issue fork.
  • Pipeline finished with Success
    3 months ago
    Total: 3700s
    #253918
  • Pipeline finished with Success
    3 months ago
    Total: 629s
    #254152
  • Pipeline finished with Success
    3 months ago
    Total: 2505s
    #254158
  • Status changed to Needs review 3 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    3 months ago
    Total: 675s
    #254187
  • Pipeline finished with Success
    3 months ago
    Total: 813s
    #254188
Production build 0.71.5 2024