- Issue created by @Zed9
- Status changed to Needs work
about 1 year ago 5:37am 3 October 2023 - ๐ฎ๐ณIndia aayushDrupal
Hi,
The patch0001-Fix-the-errors-found-by-phpcs.patch
has been successfully applied, but it does not completely resolve all the errors. Please check the attached screenshot.Moving to Needs work.
Thanks. - ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Merge request !6Issue #3390583: Fix issues reported by phpcs and enable gitlab pipeline โ (Merged) created by chetan 11
- Status changed to Needs review
about 1 year ago 7:59am 3 October 2023 - ๐ฎ๐ณIndia chetan 11
Hi @Gab.
I fixed the phpcs issues, please review & let me know if any updates required. - Status changed to Needs work
about 1 year ago 9:26am 3 October 2023 - ๐ฎ๐ณIndia aayushDrupal
Hi chetan 11,
Merge request !6 has been successfully applied, but there are still remaining phpcs errors. A screenshot is attached for your reference. Please check.Moving to Needs work.
Thnaks. - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 11:37pm 7 October 2023 - ๐ต๐ญPhilippines clarkssquared
Hi imustakim,
I applied the updated MR !6 and I confirmed that it fixes all the PHPCS issues, the remaining issues being flagged are the project, version, and datestamp which I believe occurs when the module is installed via composer and I don't think this is a PHPCS issue, I will retain the status to needs review for others to review and give feedbacks to your patch. RTBC +1 from me.
โ custom_view_filters git:(main) โ curl https://git.drupalcode.org/project/custom_view_filters/-/merge_requests/6.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 13956 0 13956 0 0 15791 0 --:--:-- --:--:-- --:--:-- 15895 patching file CHANGELOG.txt patching file 'src/Plugin/views/filter/CustomAzFilter.php' patching file 'src/Plugin/views/filter/DateRangePickerFilter.php' patching file 'src/Plugin/views/filter/NodeGranularDateFilter.php' โ custom_view_filters git:(main) โ .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml custom_view_filters FILE: ...pal10/web/modules/contrib/custom_view_filters/custom_view_filters.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- Time: 335ms; Memory: 12MB โ contrib git:(main) โ
- Status changed to RTBC
about 1 year ago 7:16am 9 October 2023 - ๐ฎ๐ณIndia Gautam_105@
@imustakim,
I have applied the updated MR !6 and I confirmed that it fixes all the PHPCS issues.Moving to +RTBC. see the screenshot as well. - First commit to issue fork.
-
rcodina โ
committed fdb699a5 on 2.x authored by
chetan 11 โ
Issue #3390583 by rcodina, chetan 11, gab., imustakim: Fix issues...
-
rcodina โ
committed fdb699a5 on 2.x authored by
chetan 11 โ
- Status changed to Fixed
3 months ago 7:22pm 20 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.