Contrib.social

Drupal Coding Standards Issues | phpcs

Open on Drupal.org ā†’
Created on 14 February 2023, almost 2 years ago

Problem/Motivation

FILE: C:\xampp\htdocs\abc\drupal\modules\spambot\spambot.install
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
94 | WARNING | [x] Inline @var declarations should use the /** */
| | delimiters
122 | WARNING | [x] Inline @var declarations should use the /** */
| | delimiters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: C:\xampp\htdocs\abc\drupal\modules\spambot\spambot.module
----------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
20 | WARNING | [ ] Global constants should not be used, move it to
| | a class or interface
513 | ERROR | [ ] unserialize() is insecure unless allowed classes
| | are limited. Use a safe format like JSON or use
| | the allowed_classes option.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...modules\spambot\src\Controller\SpambotUserSpamPageController.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
24 | WARNING | [ ] \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...docs\abc\drupal\modules\spambot\src\Form\SpambotSettingsForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 23 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
272 | WARNING | [ ] \Drupal calls should be avoided in classes, use
| | dependency injection instead
355 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
356 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
361 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
362 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
364 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
365 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
366 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
367 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
368 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
369 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
370 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
371 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
377 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
378 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
380 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
381 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
382 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
383 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
384 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
385 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
386 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
387 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait
| | and $this->t() instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...docs\abc\drupal\modules\spambot\src\Form\SpambotUserspamForm.php
----------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
137 | ERROR | [ ] The array declaration extends to column 116 (the
| | limit is 80). The array content should be split
| | up over multiple lines
190 | WARNING | [ ] Node::load calls should be avoided in classes,
| | use dependency injection instead
279 | WARNING | [ ] Unused variable $comments_enabled.
569 | ERROR | [ ] The array declaration extends to column 89 (the
| | limit is 80). The array content should be split
| | up over multiple lines
574 | ERROR | [ ] The array declaration extends to column 92 (the
| | limit is 80). The array content should be split
| | up over multiple lines
586 | ERROR | [ ] The array declaration extends to column 87 (the
| | limit is 80). The array content should be split
| | up over multiple lines
587 | ERROR | [ ] The array declaration extends to column 83 (the
| | limit is 80). The array content should be split
| | up over multiple lines
592 | ERROR | [ ] The array declaration extends to column 90 (the
| | limit is 80). The array content should be split
| | up over multiple lines
593 | ERROR | [ ] The array declaration extends to column 83 (the
| | limit is 80). The array content should be split
| | up over multiple lines
612 | WARNING | [ ] \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...abc\drupal\modules\spambot\tests\src\Kernel\SpambotCacheTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but
| | found "\r\n"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...\drupal\modules\spambot\tests\src\Kernel\SpambotUserspamTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but
| | found "\r\n"
39 | ERROR | [ ] The array declaration extends to column 98 (the
| | limit is 80). The array content should be split up
| | over multiple lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 934ms; Memory: 16MB

Steps to reproduce

Run the following command :
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /modules/contrib/spambot

Proposed resolution

Fix all the php coding standard issues and warnings.

šŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Charchil Khandelwal

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Charchil Khandelwal
  • Merge request !8Issue #3341484: Drupal Coding Standards Issues | phpcs ā†’ (Open) created by Charchil Khandelwal
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India Charchil Khandelwal
  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago ā†’
    gaurav-mathur

    FILE: C:\xampp\htdocs\drupal\modules\spambot\spambot.module
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    18 | WARNING | Global constants should not be used, move it to a
    | | class or interface
    ----------------------------------------------------------------------

    FILE: ...modules\spambot\src\Controller\SpambotUserSpamPageController.php
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    24 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    ----------------------------------------------------------------------

    FILE: ...docs\drupal\modules\spambot\src\Form\SpambotSettingsForm.php
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    272 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    ----------------------------------------------------------------------

    FILE: ...docs\drupal\modules\spambot\src\Form\SpambotUserspamForm.php
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ----------------------------------------------------------------------
    289 | WARNING | Unused variable $comments_enabled.
    646 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    ----------------------------------------------------------------------

    Need to fix these errors and warnings.

  • Assigned to indrapatil
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India indrapatil Bangalore

    I will work on this.

  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India indrapatil Bangalore
  • Issue was unassigned.
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India indrapatil Bangalore
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Assigned to imustakim
  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago ā†’
    šŸ‡ØšŸ‡¦Canada imustakim Canada

    Working on this.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago ā†’
    šŸ‡ØšŸ‡¦Canada imustakim Canada

    There are still this 3 error showing up in phpcs, there is an open issue for these error -> https://www.drupal.org/project/coder/issues/3326197 āœØ REVERTED: Allow passing constants to t() translate function to prevent 'Only string literals should be passed to t() where possible' CS warning Fixed
    I've updated the changes in the patch. Please review.

  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡³India sagarTiwari

    @imustakim Reviewed the patch you gave it works as expected following comment #13 it still has 3 warnings
    (Only string literals should be passed to t() where possible).

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
    +  /**
+   * The SpambotUserSpamPageController constructor.
+   *
+   * @param \Drupal\Core\Render\RendererInterface $renderer
+   *   The renderer service.
+   */
+  public function __construct(RendererInterface $renderer) {
+    $this->renderer = $renderer;
+  }

    Short descriptions for methods and functions start with a verb.
    The class namespace is missing.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India sahil.goyal

    Addressed the comment #15 However missing class namespace is not relevant in this case, as the namespace is already present in the code.

  • Comment 12 months ago ā†’
    šŸ‡®šŸ‡³India zkhan.aamir
  • Assigned to nitin_lama
  • Comment 12 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 12 months ago
    4 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 12 months ago
    4 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update 12 months ago
    4 pass
  • Comment 12 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India

    Rebased and pushed DI issues fix in the MR. Updating the IS for the remaining issues.

  • Issue was unassigned.
  • Comment 12 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India
  • Comment 12 months ago ā†’
    šŸ‡®šŸ‡³India nitin_lama India

    WARNING | Global constants should not be used, move it to a class or interface

    To address this warning, one possible solution is to create a distinct class for the constants and subsequently employ that class within the .module. I refrained from pushing the modifications as there is only a single constant variable. I am uncertain whether it is acceptable to disregard the warning or if it is necessary to establish a separate class to resolve it. please review the remaining issues.

  • Comment 11 months ago ā†’
    šŸ‡®šŸ‡³India Shreyas gowda
  • Comment 10 months ago ā†’
    shruu_rao

    Hi,
    Applied #22 patch. patch applied cleanly but still could see some errors.

    FILE: C:\spambot\spambot.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  19 | WARNING | Global constants should not be used, move it to a class or interface
  43 | WARNING | Code after the RETURN statement on line 41 cannot be executed
 539 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\spambot\src\Controller\SpambotUserSpamPageController.php
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------


FILE: C:\spambot\src\Form\SpambotSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 25 WARNINGS AFFECTING 25 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 125 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 279 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 362 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 363 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 368 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 369 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 371 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 372 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 373 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 374 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 375 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 376 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 377 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 378 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 384 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 385 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 387 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 388 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 389 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 390 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 391 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 392 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 393 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 394 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\spambot\src\Form\SpambotUserspamForm.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------
 194 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead
 283 | WARNING | Unused variable $comments_enabled.
 636 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------


FILE: C:\spambot\src\Plugin\WebformHandler\SpamBotWebformHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 113 | WARNING | Only string literals should be passed to t() where possible
 114 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 118 | WARNING | Only string literals should be passed to t() where possible
 119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 123 | WARNING | Only string literals should be passed to t() where possible
 124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
  • First commit to issue fork.
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India sakthi_dev

    sakthi_dev ā†’ changed the visibility of the branch 8.x-1.x-local to hidden.

  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India sakthi_dev

    sakthi_dev ā†’ changed the visibility of the branch 3341484-drupal-coding-standards to hidden.

  • Merge request !11Phpcs issue ā†’ (Open) created by sakthi_dev
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 10 months ago
    4 pass
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 10 months ago
    4 pass
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India sakthi_dev

    Fixed all the PHPCS issues. Please review.
    As per the new rules constructs description is not mandatory.

  • Status changed to RTBC 7 months ago
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    Patch Failed to Apply
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 7 months ago
    4 pass
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @sakthi_dev,

    I applied MR!11, it applied smoothly and fixed the phpcs issues.

    āžœ  spambot git:(0a6a6e6) curl https://git.drupalcode.org/project/spambot/-/merge_requests/11.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 28853    0 28853    0     0  61249      0 --:--:-- --:--:-- --:--:-- 61389
patching file spambot.install
patching file spambot.module
patching file src/ConstantInterface.php
patching file src/Controller/SpambotUserSpamPageController.php
patching file src/Form/SpambotSettingsForm.php
patching file src/Form/SpambotUserspamForm.php
patching file src/Plugin/WebformHandler/SpamBotWebformHandler.php
patching file tests/src/Kernel/SpambotUserspamTest.php
āžœ  spambot git:(0a6a6e6) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml spambot

FILE: /Users/interns/Demo-site/drupal-orgissue/web/modules/contrib/spambot/src/Controller/SpambotUserSpamPageController.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 22 | ERROR | Missing short description in doc comment
---------------------------------------------------------------------------------------------------------------------------

Time: 823ms; Memory: 14MB

āžœ  contrib git:(main) āœ—

    I will move the status to Reviewed & tested by the community since it is stated in comment #28 that the it is not mandatory.

    Thank you.

  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    apaderno ā†’ changed the visibility of the branch 8.x-1.x to hidden.

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • First commit to issue fork.
  • Comment 3 months ago ā†’
    šŸ‡®šŸ‡³India harshitthakore Pune
  • Comment 2 months ago ā†’
    šŸ‡ØšŸ‡¦Canada nickdickinsonwilde Victoria, BC (T'So-uke lands)

    Closing this as outdated. Current 8.x-1.x-dev is phpcs passing now. If further improvement in strings is desired by anyone, please open a new ticket

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024