@gaurav-mathur

Account created on 2 September 2021, about 3 years ago
#

Recent comments

Please ignore patch #13 and @tunic thanks for informing me. I will take care of it & never repeat it again

FILE: C:\xampp\htdocs\drupal\modules\spambot\spambot.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | Global constants should not be used, move it to a
| | class or interface
----------------------------------------------------------------------

FILE: ...modules\spambot\src\Controller\SpambotUserSpamPageController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
24 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------

FILE: ...docs\drupal\modules\spambot\src\Form\SpambotSettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
272 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------

FILE: ...docs\drupal\modules\spambot\src\Form\SpambotUserspamForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
289 | WARNING | Unused variable $comments_enabled.
646 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------

Need to fix these errors and warnings.

hey @Jay Jangid , mr work fine in my system.
LGTM to RTBC.

Tested and verified merge request !6, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !2, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !4, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !3, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !4, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !2, it works fine to me.
So moving it to RTBC
Thanks

Tested and verified merge request !2, it works fine to me.
So moving it to RTBC
Thanks

Tested and verified merge request !5, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !2, it works fine.
So moving it to RTBC
Thanks

Tested and verified merge request !2, it works fine.
So moving it to RTBC
Thanks

FILE: ...abc\drupal\modules\odata_client\src\Odata\InputOutputService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
242 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------

Need to fix this warning.

FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockHu.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------

FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockSk.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------

Need to fix these errors.

Thanks @Charchil Khandelwal, MR !1 looks good.
So, moving to RTBC.

Thank You.

FILE: ...bc\drupal\modules\contextly\src\Contextly\ContextlyDrupalKit.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
401 | ERROR | Type hint "\ContextlyKitApiTokenInterface" missing for
| | $token
----------------------------------------------------------------------

FILE: ...htdocs\abc\drupal\modules\contextly\src\ContextlyBaseService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
346 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
480 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
----------------------------------------------------------------------

FILE: ...ontextly\src\Controller\ContextlyAjaxEditorRequestController.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
24 | ERROR | The $_POST super global must not be accessed directly;
| | inject the request_stack service and use
| | $stack->getCurrentRequest()->request instead
----------------------------------------------------------------------

FILE: ...bc\drupal\modules\contextly\src\Form\ContextlyImageAdminForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
65 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
----------------------------------------------------------------------

FILE: ...abc\drupal\modules\contextly\src\Form\ContextlyTagsAdminForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
61 | WARNING | NodeType::loadMultiple calls should be avoided in
| | classes, use dependency injection instead
----------------------------------------------------------------------

Need to fix these issues.

Thanks @Charchil Khandelwal, its looks good now.
So, moving to RTBC.

Thank You.

Thanks, its looks good now.
So, moving to RTBC.

Thank You.

Thank you both, its looks good now.
So, moving to RTBC.

Thank You.

Thanks @Charchil Khandelwal, its looks good now.
So, moving to RTBC.

Thank You.

Thanks @sahil.goyal and @Charchil Khandelwal, its looks good now.
So, moving to RTBC.

Thank You.

Thanks everyone, All the errors have been resolved. Hence, moving to RTBC.

Thanks everyone,
All the errors have been resolved. Hence, moving to RTBC.

Thanks @Charchil Khandelwal, All the errors have been resolved. Hence, moving to RTBC.

Thanks @samit.310@gmail.com and @Charchil Khandelwal, All the errors have been resolved. Hence, moving to RTBC.

Production build 0.71.5 2024