Fix the issues reported by phpcs

FILE: /home/system/Documents/contribution/layoutcomponents-3293054/src/LcLayoutsManager.php --------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 541 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/layoutcomponents-3293054/src/LcTheme.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 257 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/layoutcomponents-3293054/src/LcLayoutRender.php -------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES -------------------------------------------------------------------------------------------------- 297 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 446 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 450 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 485 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 566 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 589 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 714 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 718 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 946 | WARNING | Unused variable $description. -------------------------------------------------------------------------------------------------- Time: 1.05 secs; Memory: 22MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work over 1 year ago5:41pm 1 May 2023

Comment over 1 year ago →

🇮🇹Italy apaderno Brescia, 🇮🇹

+/**
+ * @file
+ * Description.
+ */
+

That is not the correct short description for a module file.

    * @return \Drupal\layoutcomponents\LcLayoutRender
+   *   Description for the return value.
    */
   public function getLayout() {

That is not the return value description.

-      //$build['layout_settings']['container']['section']['sub_section'] = $sub_section;
-
+      // $build['layout_settings']['container']['section']['sub_section'] =
+      // $sub_section;

The existing commented-out code is correct as it is. There is only a missing space after the comment delimiter.

   /**
    * Set the region content.
    *
-   * @param $region
+   * @param array $region

Since that documentation comment is changed, the verb in the short description must be changed to use the third singular person.

-  public function getDefaultColumnOption($type) {
+  public function getDefaultColumnOption(numeric $type) {

numeric is not a PHP type that can be used in defining parameters.

+   * @param bool $isSubregion
+   *   The bool.

That does not describe the parameter.

Comment 12 months ago →
🇮🇳India pray_12
Preethy_ray → made their first commit to this issue’s fork.
Assigned to nitin_lama
Comment 12 months ago →
🇮🇳India nitin_lama India
Comment 12 months ago →
🇮🇳India nitin_lama India
Patch #2 doesn't applies on 3.0.x branch. Providing the updated patch. Updating the IS with the remaining issues.

@preethy_ray moving forward please provide a patch for the issues you have worked on.
Issue was unassigned.
Comment 12 months ago →
🇮🇳India nitin_lama India
Comment 10 months ago →
shruu_rao
Hi,
Tested the #8 patch, patch does not apply and throws following errors.

Checking patch src/LcLayoutRender.php...
Hunk #1 succeeded at 327 (offset 1 line).
Checking patch src/LcLayoutsManager.php...
warning: src/LcLayoutsManager.php has type 100644, expected 100755
Checking patch src/LcTheme.php...
warning: src/LcTheme.php has type 100644, expected 100755
error: while searching for:
use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\Core\Layout\LayoutPluginManager;
use Drupal\Core\Routing\RouteMatchInterface;
use Drupal\node\Entity\Node;
use Symfony\Component\DependencyInjection\ContainerInterface;

error: patch failed: src/LcTheme.php:5
error: src/LcTheme.php: patch does not apply
Checking patch src/Plugin/Layout/LcBase.php...
warning: src/Plugin/Layout/LcBase.php has type 100644, expected 100755
Comment 6 months ago →
🇮🇳India dev16.addweb
Kindly review this patch.
Comment 6 months ago →
🇮🇳India dev16.addweb
Comment 6 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3.0.x to hidden.
Merge request !15Issue #3293054: Fix the issues reported by phpcs → (Open) created by apaderno
Pipeline finished with Failed
6 months ago
Total: 696s
#186046

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Merge Requests

!15Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Merge Requests

!15Fix the issues reported by phpcsOpen

Comments & Activities

!15Fix the issues reported by phpcs
Open