Fix the issues reported by phpcs

Hi I revised the MR changes .
I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig . inside module folder

phpcs has been fixed

moving to RTBC.

diff --git a/README.md b/README.md
index 4834c199c1616fac46e5cd1d0c041e63564ac305..880ad97b7849133d01909d864d59024fe94587e9 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,10 @@
+<?php
+
+/**
+ * @file
+ * This module provides a PHP client to make requests to the Eudonet API.
+ */
+?>

No, those lines are not necessary in a README.md file. I do not even see a warning in the shown report that say they must be added.

-/** @var \Drupal\eudonet\EudonetSearchQueryResultItemWrapper $item */
+/**
+ * QueryResultItem.
+ *
+ * @var \Drupal\eudonet\EudonetSearchQueryResultItemWrapper $item
+ */

The existing code is already correct: /** @var \Drupal\eudonet\EudonetSearchQueryResultItemWrapper $item */ must be on a single line.

-<?php
+< ? php

There is no need to add spaces in the <?php tag.

 /**
- * Class Eudonet.
+ * The class of eudonet.

The description is still repeating the class name without saying what the class does.

-      throw new Exception('A descId or \'Users\' are required to use the catalog resource');
+      throw new \Exception('A descId or \'Users\' are required to use the catalog resource');

Instead of escaping the string delimiter inside the string, the string should use a different string delimiter.

 /**
- * Trait EudonetMappingTrait.
+ * Trait mappingtrait.

 /**
- * Trait EudonetQueryConditionTrait.
+ * Trait queryconditiontrait.
  *

Trait descriptions must not start with Trait. Those descriptions do not say what the trait purpose is.

+  /**
+   * Array $fields.
+   *
+   * @var array
+   */
   protected $fields = [];

A property description must describe the property, not repeat the property type and the variable name.

+* The EudonetQuery plug-in type is responsible for the
+ http request to the eudonet API.

Since that is part of a list, the second line needs to be indented.

/**
- * Class Eudonet.
+ * The class of eudonet.

That description is still repeating the class name. Class descriptions must not start with The class of, which does not even make sense when it is followed by the class name.

+  /**
+   * The wrapped item.
+   *
+   * @var mixed
+   */
   private $item;

That property's type is array.

+   * The value representing an image.
+   *
+   * @var string
    */
-  public function __construct(array $configuration, string $plugin_id, $plugin_definition, ClientFactory $http_client_factory, Eudonet $eudonet, EudonetQueryResultManager $eudonet_query_result_manager) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $http_client_factory, $eudonet, $eudonet_query_result_manager);
-  }
+  protected $imageValue;

$imageValue is an array, not a string, since it is initialized by the following code.

$this->imageValue = [
  'DescId' => $this->mapping[$field_name] ?? $field_name,
  'Value' => $value,
];

 /**
- * Class SearchQuery.
+ * Epresents a search query for retrieving specific data.

There is a typo in that description.

- * Trait EudonetMappingTrait.
+ * Trait mappingtrait.

- * Trait EudonetQueryConditionTrait.
+ * Trait queryconditiontrait.

 /**
- * Trait EudonetQueryFieldTrait.
+ * Trait queryfieldtrait.

Trait descriptions must not start with Trait. Those descriptions do not say what the trait purpose is. (What follow Trait is not an English word, then.)

+  /**
+   * Array $fields will have fieldname.
+   *
+   * @var array
+   */
   protected $fields = [];

That description does not make sense.

-   * @param int|string $field_name
+   * @param int|array $field_name
    *   The field name to get in the request response.

$field_name is not an array or an integer, but a string or an integer.

-  public function addField($field_name) {
+  public function addField(array $field_name) {

Since $field_name can be either a string or an integer, it cannot be type-hinted to array.

+  /**
+   * Array $papger.
+   *
+   * @var array
+   */
   protected $pager = [];

The description must say for what that property is used, not repeat its type and the variable name.

bindu r → made their first commit to this issue’s fork.

Hi,
Reviewed MR !2, found few remaining errors adding some below.

FILE: C:\eudonet\eudonet.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\README.md
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\Annotation\EudonetQuery.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\Annotation\EudonetQueryResult.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\Eudonet.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\EudonetMappingPluginManager.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\EudonetMappingPluginManagerInterface.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\EudonetQueryCondition.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------


FILE: C:\eudonet\src\EudonetSearchQueryResultItemWrapper.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

@shruu_rao It's not showing any error for me upon running the command.

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,js,css,info,txt,md

Attaching the screenshot.