Phpcs Drupal standard coding issue

Created on 25 July 2022, almost 2 years ago
Updated 27 February 2024, 4 months ago
๐Ÿ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia Harsh panchal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Charchil Khandelwal

    Charchil Khandelwal โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review 6 months ago
  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 6 months ago
    5 pass
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia viren18febS

    I have made the changes and added repatch #7.please review.

  • Hii,
    After applying the patch #14, the patch is successfully applied, but there are still some errors found when running the phpcs command.

    \group_domain\src\EventSubscriber\PathRequestSubscriber.php
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
    148 | ERROR | Missing short description in doc comment
    149 | ERROR | Description for the @return value must be on the next line
    --------------------------------------------------------------------------------

    \group_domain\src\Plugin\views\filter\DomainGroupContent.php
    ---------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
    ---------------------------------------------------------------------------------
    23 | ERROR | Missing member variable doc comment
    24 | ERROR | Missing member variable doc comment
    25 | ERROR | Missing member variable doc comment
    27 | ERROR | Doc comment is empty
    112 | WARNING | Unused variable $tq.
    ---------------------------------------------------------------------------------

  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 5 months ago
    5 pass
  • Addressed the remaining errors and warnings of #15, Created a patch and an interdiff file.

  • Addressed the remaining errors and warnings of #15, created a patch and a interdiff file
    Thank you !!

  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 5 months ago
    5 pass
  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines paraderojether

    Hi Shruu_rao,

    I applied patch #18, and there are still remaining phpcs errors shown below:

    FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/group_domain/src/GroupDomainInfo.php
    ------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------------
     30 | ERROR | Missing member variable doc comment
     31 | ERROR | Missing member variable doc comment
    ------------------------------------------------------------------------------------------------------
    
    Time: 369ms; Memory: 12MB

    Kindly check and advise, please.
    Thank you.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Preethy_ray

    Hi,
    I have applied the patch #18.
    The patch is successfully applied without any errors.

  • Status changed to Needs review 4 months ago
Production build 0.69.0 2024