Contrib.social

Phpcs Drupal standard coding issue

Open on Drupal.org →
Created on 25 July 2022, over 2 years ago
Updated 31 January 2023, about 2 years ago

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\group_domain.module
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Cache\Context\GroupDomainCacheContext.php
-------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
24 | ERROR | [x] Additional blank lines found at end of doc comment
24 | ERROR | [ ] Missing @var tag in member variable comment
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\EventSubscriber\PathRequestSubscriber.php
-------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
27 | ERROR | [ ] Missing @var tag in member variable comment
32 | ERROR | [ ] Missing @var tag in member variable comment
37 | ERROR | [ ] Missing @var tag in member variable comment
42 | ERROR | [ ] Missing @var tag in member variable comment
109 | ERROR | [ ] Missing short description in doc comment
110 | ERROR | [ ] Description for the @return value must be on the next line
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Form\GroupDomainSettingsForm.php
----------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
23 | ERROR | [ ] Missing @var tag in member variable comment
28 | ERROR | [ ] Missing @var tag in member variable comment
33 | ERROR | [ ] Missing @var tag in member variable comment
67 | ERROR | [ ] Description for the @return value is missing
83 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\GroupDomainInfo.php
-------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
54 | ERROR | [ ] Description for the @return value must be on the next line
63 | ERROR | [ ] Description for the @return value must be on the next line
75 | ERROR | [ ] Description for the @return value is missing
96 | ERROR | [x] Expected "arraystring|null" but found "array|null" for function return type
96 | ERROR | [ ] Description for the @return value is missing
126 | ERROR | [ ] Description for the @return value must be on the next line
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\GroupDomainServiceProvider.php
----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
19 | ERROR | [ ] Doc comment short description must start with a capital letter
20 | ERROR | [ ] Doc comment short description must end with a full stop
20 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\PathProcessor.php
-------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 5 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
24 | ERROR | [x] Additional blank lines found at end of doc comment
24 | ERROR | [ ] Missing @var tag in member variable comment
30 | ERROR | [x] Additional blank lines found at end of doc comment
30 | ERROR | [ ] Missing @var tag in member variable comment
43 | ERROR | [x] Additional blank lines found at end of doc comment
43 | ERROR | [ ] Missing @var tag in member variable comment
49 | ERROR | [x] Additional blank lines found at end of doc comment
49 | ERROR | [ ] Missing @var tag in member variable comment
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Plugin\Validation\Constraint\GroupDomainConstraint.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
22 | ERROR | [x] Additional blank lines found at end of doc comment
22 | ERROR | [ ] Missing @var tag in member variable comment
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Plugin\Validation\Constraint\GroupDomainValidator.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Plugin\views\argument_default\GroupFromDomain.php
---------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
29 | ERROR | [x] Additional blank lines found at end of doc comment
29 | ERROR | [ ] Missing @var tag in member variable comment
35 | ERROR | [x] Expected 1 spaces after parameter type; 32 found
37 | ERROR | [x] Expected 1 spaces after parameter type; 31 found
39 | ERROR | [x] Expected 1 spaces after parameter type; 32 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\src\Routing\GroupDomainRouteProvider.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\tests\modules\group_domain_test\src\EventSubscriber\GroupDomainTestSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
17 | ERROR | [x] Missing function doc comment
24 | ERROR | [ ] Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\group_domain\tests\src\Kernel\GroupDomainTest.php
----------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
22 | ERROR | [x] Doc comment short description must end with a full stop
24 | ERROR | [x] Additional blank lines found at end of doc comment
40 | ERROR | [x] Additional blank lines found at end of doc comment
40 | ERROR | [ ] Missing @var tag in member variable comment
82 | ERROR | [x] Missing function doc comment
101 | ERROR | [ ] Missing short description in doc comment
102 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India Harsh panchal

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇮🇳India Charchil Khandelwal

    Charchil Khandelwal → made their first commit to this issue’s fork.

  • Comment about 1 year ago →
    🇮🇳India zkhan.aamir
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    5 pass
  • Comment about 1 year ago →
    🇮🇳India viren18febs

    I have made the changes and added repatch #7.please review.

  • Comment about 1 year ago →
    shruu_rao

    Hii,
    After applying the patch #14, the patch is successfully applied, but there are still some errors found when running the phpcs command.

    \group_domain\src\EventSubscriber\PathRequestSubscriber.php
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------------
    148 | ERROR | Missing short description in doc comment
    149 | ERROR | Description for the @return value must be on the next line
    --------------------------------------------------------------------------------

    \group_domain\src\Plugin\views\filter\DomainGroupContent.php
    ---------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
    ---------------------------------------------------------------------------------
    23 | ERROR | Missing member variable doc comment
    24 | ERROR | Missing member variable doc comment
    25 | ERROR | Missing member variable doc comment
    27 | ERROR | Doc comment is empty
    112 | WARNING | Unused variable $tq.
    ---------------------------------------------------------------------------------

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    5 pass
  • Comment about 1 year ago →
    shruu_rao

    Addressed the remaining errors and warnings of #15, Created a patch and an interdiff file.

  • Comment about 1 year ago →
    shruu_rao

    Addressed the remaining errors and warnings of #15, created a patch and a interdiff file
    Thank you !!

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update about 1 year ago
    5 pass
  • Comment about 1 year ago →
    shruu_rao
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇵🇭Philippines paraderojether

    Hi Shruu_rao,

    I applied patch #18, and there are still remaining phpcs errors shown below: 

    FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/group_domain/src/GroupDomainInfo.php
------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------
 30 | ERROR | Missing member variable doc comment
 31 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------

Time: 369ms; Memory: 12MB

    Kindly check and advise, please.
    Thank you.

  • Comment about 1 year ago →
    🇮🇳India pray_12

    Hi,
    I have applied the patch #18.
    The patch is successfully applied without any errors.

  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇮🇳India zkhan.aamir
  • Status changed to Needs work 8 months ago
  • Comment 8 months ago →
    🇮🇳India riddhi.addweb

    I tried Patch 18, but still some errors were displayed. Please review it:-

    FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/GroupDomainInfo.php
-------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------
 30 | ERROR | [ ] Missing member variable doc comment
 31 | ERROR | [ ] Missing member variable doc comment
 40 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Plugin/views/argument_default/GroupFromDomain.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 49 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Plugin/views/filter/DomainGroupContent.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 53 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/EventSubscriber/PathRequestSubscriber.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/PathProcessor.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 62 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Form/GroupDomainSettingsForm.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 64 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
  • Status changed to Closed: outdated 3 months ago
  • Comment 3 months ago →
    heddn Nicaragua

    This is all fixed in https://www.drupal.org/project/group_domain/issues/3451117 📌 Automated Drupal 11 compatibility fixes for group_domain Needs review

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024