Phpcs Drupal standard coding issue

Comment almost 2 years ago →
🇮🇳India Charchil Khandelwal
Charchil Khandelwal → made their first commit to this issue’s fork.
Comment 11 months ago →
🇮🇳India zkhan.aamir
Status changed to Needs review 11 months ago6:01am 11 January 2024
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
5 pass
Comment 11 months ago →
🇮🇳India viren18febS
I have made the changes and added repatch #7.please review.
Comment 10 months ago →
shruu_rao
Hii,
After applying the patch #14, the patch is successfully applied, but there are still some errors found when running the phpcs command.

\group_domain\src\EventSubscriber\PathRequestSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
148 | ERROR | Missing short description in doc comment
149 | ERROR | Description for the @return value must be on the next line
--------------------------------------------------------------------------------

\group_domain\src\Plugin\views\filter\DomainGroupContent.php
---------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------
23 | ERROR | Missing member variable doc comment
24 | ERROR | Missing member variable doc comment
25 | ERROR | Missing member variable doc comment
27 | ERROR | Doc comment is empty
112 | WARNING | Unused variable $tq.
---------------------------------------------------------------------------------
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
5 pass
Comment 10 months ago →
shruu_rao
Addressed the remaining errors and warnings of #15, Created a patch and an interdiff file.
Comment 10 months ago →
shruu_rao
Addressed the remaining errors and warnings of #15, created a patch and a interdiff file
Thank you !!
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
5 pass
Comment 10 months ago →
shruu_rao
Status changed to Needs work 10 months ago3:41am 17 January 2024

Hi Shruu_rao,

I applied patch #18, and there are still remaining phpcs errors shown below:

FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/group_domain/src/GroupDomainInfo.php
------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------
 30 | ERROR | Missing member variable doc comment
 31 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------

Time: 369ms; Memory: 12MB

Kindly check and advise, please.
Thank you.

Comment 10 months ago →
🇮🇳India pray_12
Hi,
I have applied the patch #18.
The patch is successfully applied without any errors.
Status changed to Needs review 9 months ago11:31am 27 February 2024
Comment 9 months ago →
🇮🇳India zkhan.aamir
Status changed to Needs work 5 months ago10:27am 11 July 2024

Comment 5 months ago →

🇮🇳India riddhi.addweb

I tried Patch 18, but still some errors were displayed. Please review it:-

FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/GroupDomainInfo.php
-------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------
 30 | ERROR | [ ] Missing member variable doc comment
 31 | ERROR | [ ] Missing member variable doc comment
 40 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Plugin/views/argument_default/GroupFromDomain.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 49 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Plugin/views/filter/DomainGroupContent.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 53 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/EventSubscriber/PathRequestSubscriber.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/PathProcessor.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 62 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/group_domain/src/Form/GroupDomainSettingsForm.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 64 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

Phpcs Drupal standard coding issue

Comments & Activities