- Merge request !67Issue #3331396: Drupal Coding Standards Issues | phpcs → (Open) created by _pratik_
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 9:26am 8 February 2023 - 🇮🇳India spriya2896
This patch got failed on the drupal 8 versions and PHP version 7.4.21.
- Assigned to rassoni
- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
- 🇮🇳India sahil.goyal
addressed #14 as per Updating the issue summery.
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
I will raise the MR which will solve the phpcs issues.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & sqlite-3.27last update
over 1 year ago Not currently mergeable. - Issue was unassigned.
- 🇮🇳India akshaydalvi212
solved most of the issues, still some are remaining.
- Assigned to ankitv18
- First commit to issue fork.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.2 & sqlite-3.34last update
10 months ago Not currently mergeable. Remaining errors
FILE: C:\search_api\modules\search_api_db\README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 34 | WARNING | Line exceeds 80 characters; contains 81 characters ---------------------------------------------------------------------- FILE: C:\search_api\modules\search_api_db\src\Plugin\search_api\backend\Database.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 1508 | ERROR | The array declaration extends to column 439 (the limit is 80). The array content should be split up over multiple lines 1525 | ERROR | The array declaration extends to column 443 (the limit is 80). The array content should be split up over multiple lines 1779 | ERROR | No key specified for array entry; first entry specifies key 2004 | ERROR | No key specified for array entry; first entry specifies key ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\modules\search_api_db\tests\fixtures\update\search-api-db-base.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 52 | WARNING | Unused variable $data. --------------------------------------------------------------------------------------------------- FILE: C:\search_api\modules\search_api_db\tests\src\FunctionalJavascript\IntegrationTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 33 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\modules\search_api_db\tests\src\Kernel\BackendTest.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 16 ERRORS AFFECTING 16 LINES --------------------------------------------------------------------------------------------------------------------------------------- 348 | ERROR | No key specified for array entry; first entry specifies key 351 | ERROR | No key specified for array entry; first entry specifies key 399 | ERROR | No key specified for array entry; first entry specifies key 402 | ERROR | No key specified for array entry; first entry specifies key 470 | ERROR | No key specified for array entry; first entry specifies key 473 | ERROR | No key specified for array entry; first entry specifies key 479 | ERROR | No key specified for array entry; first entry specifies key 488 | ERROR | No key specified for array entry; first entry specifies key 491 | ERROR | No key specified for array entry; first entry specifies key 497 | ERROR | No key specified for array entry; first entry specifies key 983 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines 1275 | ERROR | No key specified for array entry; first entry specifies key 1288 | ERROR | No key specified for array entry; first entry specifies key 1300 | ERROR | No key specified for array entry; first entry specifies key 1313 | ERROR | Key specified for array entry; first entry has no key 1317 | ERROR | Key specified for array entry; first entry has no key --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 127 | WARNING | Line exceeds 80 characters; contains 83 characters ---------------------------------------------------------------------- FILE: C:\search_api\search_api.api.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 342 | WARNING | Unused variable $datasource_id. 367 | WARNING | Unused variable $datasource_id. ---------------------------------------------------------------------- FILE: C:\search_api\search_api.drush.inc --------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------- 86 | ERROR | The array declaration extends to column 167 (the limit is 80). The array content should be split up over multiple lines 87 | ERROR | The array declaration extends to column 238 (the limit is 80). The array content should be split up over multiple lines 183 | ERROR | The array declaration extends to column 199 (the limit is 80). The array content should be split up over multiple lines 184 | ERROR | The array declaration extends to column 189 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\search_api.install -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 195 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\search_api.post_update.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 42 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\src\Display\DisplayPluginBase.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 140 | WARNING | The deprecation-version 'Search' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or | | project:n.n.n or project:n.n.n-label[n] 140 | WARNING | The removal-version '5' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n | | or project:n.n.n-label[n] ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\src\Entity\Index.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 161 | ERROR | Missing short description in doc comment 193 | ERROR | Missing short description in doc comment 242 | ERROR | Missing short description in doc comment 1010 | ERROR | The array declaration extends to column 117 (the limit is 80). The array content should be split up over multiple lines 1127 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines 1155 | ERROR | The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines 1178 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 1619 | WARNING | There must be no blank line following an inline comment ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\search_api\src\Entity\Task.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 141 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option. -------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\src\ParamConverter\SearchApiConverter.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 59 | WARNING | The deprecation-version 'search_api' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or | | project:n.n.n or project:n.n.n-label[n] 59 | WARNING | The removal-version '2.0.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or | | project:n.n.n or project:n.n.n-label[n] ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\src\Plugin\search_api\parse_mode\Phrase.php ---------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------- 24 | ERROR | No key specified for array entry; first entry specifies key ---------------------------------------------------------------------------- FILE: C:\search_api\src\Plugin\search_api\parse_mode\Terms.php --------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------- 88 | ERROR | No key specified for array entry; first entry specifies key --------------------------------------------------------------------------- FILE: C:\search_api\src\Plugin\search_api\processor\Stemmer.php ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------- 144 | WARNING | Unused variable $i. ---------------------------------------------------------------------------- FILE: C:\search_api\src\Plugin\views\filter\SearchApiFulltext.php ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 452 | ERROR | No key specified for array entry; first entry specifies key ------------------------------------------------------------------------------ FILE: C:\search_api\src\Plugin\views\query\SearchApiQuery.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 464 | ERROR | The trigger_error message '\Drupal\search_api\Plugin\views\query\SearchApiQuery::getEntityTypes() is deprecated in 8.x-1.x is removed from Search API | | 8.x-1.5. Use \Drupal\search_api\IndexInterface::getEntityTypes() instead. See https://www.drupal.org/node/2899682' does not match the strict standard | | format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link% ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\src\Utility\FieldsHelper.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 178 | WARNING | Unused variable $i. ---------------------------------------------------------------------- FILE: C:\search_api\tests\src\Kernel\BackendTestBase.php --------------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 12 LINES --------------------------------------------------------------------------- 266 | ERROR | No key specified for array entry; first entry specifies key 269 | ERROR | No key specified for array entry; first entry specifies key 275 | ERROR | No key specified for array entry; first entry specifies key 573 | ERROR | No key specified for array entry; first entry specifies key 590 | ERROR | No key specified for array entry; first entry specifies key 594 | ERROR | No key specified for array entry; first entry specifies key 606 | ERROR | No key specified for array entry; first entry specifies key 611 | ERROR | No key specified for array entry; first entry specifies key 629 | ERROR | No key specified for array entry; first entry specifies key 638 | ERROR | No key specified for array entry; first entry specifies key 646 | ERROR | No key specified for array entry; first entry specifies key 650 | ERROR | No key specified for array entry; first entry specifies key --------------------------------------------------------------------------- FILE: C:\search_api\tests\src\Kernel\Processor\LanguageWithFallbackTest.php ---------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------- 111 | WARNING | Variable $expected inside unset call is undefined. 118 | WARNING | Variable $expected inside unset call is undefined. ---------------------------------------------------------------------------------------- FILE: C:\search_api\tests\src\Kernel\Processor\RenderedItemTest.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 355 | WARNING | Unused variable $key. -------------------------------------------------------------------------------- FILE: C:\search_api\tests\src\Kernel\Views\ViewsQueryTypeUpdateTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 21 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations. ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\search_api\tests\src\Unit\Processor\HtmlFilterTest.php ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------- 283 | WARNING | Variable $config inside unset call is undefined. ---------------------------------------------------------------------------- FILE: C:\search_api\tests\src\Unit\TermsParseModeTest.php --------------------------------------------------------------------------- FOUND 10 ERRORS AFFECTING 10 LINES --------------------------------------------------------------------------- 62 | ERROR | No key specified for array entry; first entry specifies key 70 | ERROR | No key specified for array entry; first entry specifies key 77 | ERROR | No key specified for array entry; first entry specifies key 87 | ERROR | No key specified for array entry; first entry specifies key 98 | ERROR | No key specified for array entry; first entry specifies key 106 | ERROR | No key specified for array entry; first entry specifies key 114 | ERROR | No key specified for array entry; first entry specifies key 118 | ERROR | No key specified for array entry; first entry specifies key 124 | ERROR | No key specified for array entry; first entry specifies key 132 | ERROR | No key specified for array entry; first entry specifies key ---------------------------------------------------------------------------- 🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch apaderno-3331396-8.1.x to hidden.
- Status changed to Closed: won't fix
9 months ago 3:08pm 13 March 2024