Fix the issues reported by phpcs

Charchil Khandelwal → made their first commit to this issue’s fork.

Created MR.

Please review.

The merge request appears to be the same as the originally submitted patch and does not address the issue in jcnventura's
comment, the breaking of backward-compatibility in the KeyConfigOverrides constructor. Also, coding standard violations are not bugs.

Submitted a new MR to branch 3325937-drupal-coding-standards that applies the changes in patch #2 without DI of entityTypeManager as requested in #3.

Did not edit the MR in branch 8.x-1.x as it is confusing to have a feature branch name that is the same as the module's dev branch.

     arguments: ['key_input', '@container.namespaces', '@cache.discovery', '@module_handler']
   key.config_override:
     class: \Drupal\key\KeyConfigOverrides
-    arguments: ['@config.factory', '@cache.data']
+    arguments: ['@config.factory', '@cache.data', '@entity_type.manager']

The entity type manager is yet added to the constructor since arguments is the list of the arguments passed to a service constructor. That is what jcnventura said not to do, in comment #3.

zkhan.aamir → made their first commit to this issue’s fork.

All phpcs issues are fixed on MR 10. Please review.

Shruu_rao → made their first commit to this issue’s fork.

apaderno → changed the visibility of the branch 8.x-1.x to hidden.

Checked all the changes in the MR. Only phpcs-style changes are being made, and the changes are good, The use of the null coalescing operator means that after this change the module is only for PHP 7.0+, but PHP 5.6 support has been dropped a long time ago by everyone (PHP, Drupal and all decent hosters).

Please add the GitLab CI changes, then merge this MR. We can then use the GitLab pipelines to see if there's anything still left. Maybe add credit on this issue to the ones that contributed to 📌 Drupal Coding Standards Issues | phpcs Needs review .