- Status changed to Needs work
over 1 year ago 1:33am 2 June 2023 - 🇵🇭Philippines paraderojether
I applied patch #4 againts Key version 8.x-1.x-dev, and there are still phpcs remaining issue shown below:
FILE: ...Drupal.org/drupalorg-site/docroot/modules/contrib/key/tests/src/Unit/Entity/KeyEntityTest.php --------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------- 44 | ERROR | Class property $key_type_settings should use lowerCamel naming without underscores 52 | ERROR | Class property $key_provider_settings should use lowerCamel naming without | | underscores 60 | ERROR | Class property $key_input_settings should use lowerCamel naming without underscores 111 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content | | should be split up over multiple lines --------------------------------------------------------------------------------------------------- FILE: ....org/drupalorg-site/docroot/modules/contrib/key/tests/src/Functional/KeyOverrideAdminTest.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 16 | ERROR | Missing member variable doc comment --------------------------------------------------------------------------------------------------- FILE: .../drupalorg-site/docroot/modules/contrib/key/tests/src/Functional/KeyRepositoryServiceTest.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 64 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content | | should be split up over multiple lines --------------------------------------------------------------------------------------------------- FILE: ...nees/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/KeyConfigOverrideInterface.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 9 | WARNING | The class short comment should describe what the class does and not simply repeat | | the class name --------------------------------------------------------------------------------------------------- FILE: ...tudenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/Form/KeyEditForm.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and not simply repeat | | the class name --------------------------------------------------------------------------------------------------- FILE: ...studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/Form/KeyAddForm.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 11 | WARNING | The class short comment should describe what the class does and not simply repeat | | the class name --------------------------------------------------------------------------------------------------- FILE: ...s/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/Form/KeyConfigOverrideAddForm.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------- 18 | WARNING | The class short comment should describe what the class does and not simply repeat | | the class name 300 | ERROR | The array declaration extends to column 111 (the limit is 80). The array content | | should be split up over multiple lines --------------------------------------------------------------------------------------------------- FILE: ...denttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/KeyConfigOverrides.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------- 54 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 73 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 144 | WARNING | Unused variable $id. --------------------------------------------------------------------------------------------------- FILE: ...nttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/key/src/Commands/KeyCommands.php --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------- 17 | WARNING | The class short comment should describe what the class does and not simply repeat | | the class name 234 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content | | should be split up over multiple lines --------------------------------------------------------------------------------------------------- Time: 1.6 secs; Memory: 14MB
Please check.Thank You.
- Assigned to nitin_lama
- last update
over 1 year ago 7 pass, 1 fail - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:56am 2 June 2023 The last submitted patch, 7: changes_coding_standard3332958-7.patch, failed testing. View results →
- Assigned to nitin_lama
- Status changed to Needs work
over 1 year ago 8:17am 2 June 2023 - Status changed to Needs review
over 1 year ago 8:43am 2 June 2023 - last update
over 1 year ago 8 pass - 🇮🇳India nitin_lama India
Only issue remaining:
FILE: /home/system/Documents/contribution/key/tests/src/Unit/Entity/KeyEntityTest.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------- 44 | ERROR | Class property $key_type_settings should use lowerCamel naming without underscores 52 | ERROR | Class property $key_provider_settings should use lowerCamel naming without underscores 60 | ERROR | Class property $key_input_settings should use lowerCamel naming without underscores 111 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- Time: 346ms; Memory: 10MB
Updated patch. Please review. Thanks.
- 🇯🇵Japan ptmkenny
We need to consolidate the work in this issue and 📌 Fix the issues reported by phpcs Needs review .
- 🇵🇹Portugal jcnventura
Since this issue doesn't have an MR, I'd suggest to merge 📌 Fix the issues reported by phpcs Needs review and then check if there's still anything still outstanding that is fixed in this issue. A cursory look at the contents of both suggests that the fixes here are a subset of the ones in the other issue.
- Status changed to Closed: duplicate
6 months ago 7:54am 4 June 2024