Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Issue summary updated.

 /**
- * Class EntityAccessCheckTest
+ * Class EntityAccessCheckTest.
  *
  * @group permissions_by_term
  */

The description for a class must not start with Class nor repeat the class name.

    * @return \Symfony\Component\EventDispatcher\EventDispatcher
+   *   Return the EventDispatcher instance.
    */

The description for the return value must not start with Return nor Returns.

   /**
-   * Unpublished nodes without restrictions should not be visible to anonymous
-   * users.
+   * Unpublished nodes without restrictions should not be visible to anonymous.
+   *
+   * Users.
    */

Splitting the short description into short description and long description as done there is wrong. Users. is not enough as long description.
Either the short description is left as it is, or it is rewritten to make it shorted. Keep in mind that anonymous is not a short for anonymous users. Visitors can be used as synonym of anonymous users.

+  /**
+   * Constructor for AccessResultCache class.
+   *
+   * @param \Drupal\Core\Cache\CacheBackendInterface $cache
+   *   The cache interface instance.
+   */
   public function __construct(CacheBackendInterface $cache) {

The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and ends with object.

+  /**
+   * Set access results cache.
+   *
+   * @param int $accountId
+   *   Account id.
+   * @param int $entityId
+   *   Entity id.
+   * @param \Drupal\Core\Access\AccessResult $accessResult
+   *   Access result instance.
+   */
   public function setAccessResultsCache(int $accountId, int $entityId, AccessResult $accessResult): void {

The verb used in the short description must be declined to the third person singular.
The parameter descriptions are each missing the definite article.
id is misspelled (since it is ID).

-   * @var CacheTagsInvalidator
+   * Cache instance.
+   *
+   * @var \Drupal\Core\Cache\Cache
    */
   private $cacheTagsInvalidator;

That is a \Drupal\Core\Cache\CacheTagsInvalidator instance.

   /**
+   * Value of entity.
+   *
    * @var bool
    */
   public $value;

Description of properties must not start with Value of.

     if ($form_state->getValue('disable_node_access_records') && !\Drupal::configFactory()
-        ->getEditable('permissions_by_term.settings')
-        ->get('disable_node_access_records')) {
-      node_access_rebuild(true);
+      ->getEditable('permissions_by_term.settings')
+      ->get('disable_node_access_records')) {

As per Drupal coding standards, control structure conditions must be written on a single line.

Some points from #19 are covered in patch.
Thanks

    * @return \Symfony\Component\EventDispatcher\EventDispatcher
+   *   The EventDispatcher instance will be returned.

The return value description must just say what is returned, without saying will be returned nor the class of the returned value.

   /**
-   * Unpublished nodes without restrictions should not be visible to anonymous
-   * users.
+   * Unpublished nodes without restrictions should not be
+   * visible to anonymous user.
+   * 
    */
   public function testAnonymousCannotViewUnpublishedNodesWithoutTermPermissions(): void {

The short description must be shorter than 81 characters.
That short description does not describe that method, though.

+/**
+ * AccessResultCache class.
+ */
 class AccessResultCache {
 
   /**
@@ -16,10 +18,26 @@ class AccessResultCache {
    */
   protected $cache;
 
+  /**
+   * Constructs a new AccessResultCache object.
+   *
+   * @param \Drupal\Core\Cache\CacheBackendInterface $cache
+   *   The cache interface instance.
+   */
   public function __construct(CacheBackendInterface $cache) {
     $this->cache = $cache;
   }

Those changes are not correct, since a class description must not repeat the class name.
The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and ends with object.

+  /**
+   * Set access results cache.
+   *
+   * @param int $accountId
+   *   Account id.
+   * @param int $entityId
+   *   Entity id.
+   * @param \Drupal\Core\Access\AccessResult $accessResult
+   *   Access result instance.
+   */
   public function setAccessResultsCache(int $accountId, int $entityId, AccessResult $accessResult): void {

The verb used in the short description must be declined to the third person singular.
The parameter descriptions are each missing the definite article.
id is misspelled (since it is ID).

I think we need to update the version of this module to 3.1.x as target branch is 3.1.x-dev. Current patches applies to 3.0.x-dev

Shruu_rao → made their first commit to this issue’s fork.

hi,
I will work on this issues and resolve it as well.

Hi,
I resolved almost all the phpcs issues, only some unused variable and private methods issues are remaining

Thanks

MR !24 is changing JavaScript files, which are not even listed in the PHP_CodeSniffer report given in the issue summary, nor would they be in a GitLab CI report.

avpaderno → changed the visibility of the branch 3136117-gitlab-ci-reports to hidden.