- Issue created by @djsagar
- Status changed to Needs review
about 1 year ago 5:15pm 24 August 2023 - ๐ฎ๐ณIndia djsagar
Created patch to fix the issue reported by phpcs.
Kindly review.
Hi, reviewed the patch #2, doesn't apply cleanly shows error. Attaching the ss for reference. Thank you!
- Status changed to Needs work
9 months ago 8:51am 15 February 2024 - ๐ต๐ญPhilippines clarkssquared
Hi
I also applied the patch #2 and I confirmed that it doesn't apply properly
โ festeva git:(1.0.x) curl https://www.drupal.org/files/issues/2023-08-24/3383179-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 202k 100 202k 0 0 563k 0 --:--:-- --:--:-- --:--:-- 578k patching file 'css/bootstrap-icons.css' patching file 'css/templatemo-festava-live.css' 1 out of 31 hunks failed--saving rejects to 'css/templatemo-festava-live.css.rej' patching file 'js/click-scroll.js' patching file 'js/custom.js' patching file 'js/jquery.sticky.js' patching file theme-settings.php 2 out of 3 hunks failed--saving rejects to theme-settings.php.rej โ festeva git:(1.0.x) โ
I also execute the PHPCS command since there are files that the patch successfully applied and this is the result
โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml festeva FILE: ...ng/Projects/d9/d9-local/web/themes/contrib/festeva/festeva.breakpoints.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 18 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...rksubing-subing/Projects/d9/d9-local/web/themes/contrib/festeva/README.txt -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 18 WARNINGS AFFECTING 18 LINES -------------------------------------------------------------------------------- 13 | WARNING | Line exceeds 80 characters; contains 114 characters 33 | WARNING | Line exceeds 80 characters; contains 160 characters 36 | WARNING | Line exceeds 80 characters; contains 138 characters 39 | WARNING | Line exceeds 80 characters; contains 112 characters 42 | WARNING | Line exceeds 80 characters; contains 165 characters 45 | WARNING | Line exceeds 80 characters; contains 213 characters 48 | WARNING | Line exceeds 80 characters; contains 201 characters 51 | WARNING | Line exceeds 80 characters; contains 232 characters 54 | WARNING | Line exceeds 80 characters; contains 207 characters 57 | WARNING | Line exceeds 80 characters; contains 209 characters 60 | WARNING | Line exceeds 80 characters; contains 175 characters 63 | WARNING | Line exceeds 80 characters; contains 122 characters 66 | WARNING | Line exceeds 80 characters; contains 102 characters 69 | WARNING | Line exceeds 80 characters; contains 148 characters 72 | WARNING | Line exceeds 80 characters; contains 168 characters 75 | WARNING | Line exceeds 80 characters; contains 100 characters 77 | WARNING | Line exceeds 80 characters; contains 148 characters 79 | WARNING | Line exceeds 80 characters; contains 176 characters -------------------------------------------------------------------------------- FILE: ...ng-subing/Projects/d9/d9-local/web/themes/contrib/festeva/festeva.info.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 25 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...-subing/Projects/d9/d9-local/web/themes/contrib/festeva/theme-settings.php -------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------- 28 | ERROR | [x] Whitespace found at end of line 28 | ERROR | [x] Functions must not contain multiple empty lines in a row; | | found 2 empty lines 29 | ERROR | [x] Whitespace found at end of line 36 | ERROR | [x] Whitespace found at end of line 57 | ERROR | [x] Whitespace found at end of line 70 | ERROR | [x] Whitespace found at end of line 86 | ERROR | [x] Expected 1 newline at end of file; 0 found 86 | ERROR | [x] A closing tag is not permitted at the end of a PHP file -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ubing-subing/Projects/d9/d9-local/web/themes/contrib/festeva/festeva.theme -------------------------------------------------------------------------------- FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 7 LINES -------------------------------------------------------------------------------- 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 10 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Render\Element. 11 | WARNING | [x] Unused use statement 11 | ERROR | [x] There must be one blank line after the last USE statement; | | 0 found; 15 | ERROR | [x] Expected 1 blank line before function; 0 found 24 | ERROR | [x] Whitespace found at end of line 26 | ERROR | [x] Expected 1 newline at end of file; 0 found 26 | ERROR | [x] A closing tag is not permitted at the end of a PHP file -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 640ms; Memory: 36.01MB โ contrib git:(master) โ
If you can create a Merge Request than a patch file, that would be better for the maintainer's convenience.
I will move this to needs work
Hi,
Applied #5 patch. The patch applies cleanly.
There are still some warnings leftFILE: C:\festeva\README.txt ---------------------------------------------------------------------- FOUND 0 ERRORS AND 18 WARNINGS AFFECTING 18 LINES ---------------------------------------------------------------------- 13 | WARNING | Line exceeds 80 characters; contains 114 characters 33 | WARNING | Line exceeds 80 characters; contains 160 characters 36 | WARNING | Line exceeds 80 characters; contains 138 characters 39 | WARNING | Line exceeds 80 characters; contains 112 characters 42 | WARNING | Line exceeds 80 characters; contains 165 characters 45 | WARNING | Line exceeds 80 characters; contains 213 characters 48 | WARNING | Line exceeds 80 characters; contains 201 characters 51 | WARNING | Line exceeds 80 characters; contains 232 characters 54 | WARNING | Line exceeds 80 characters; contains 207 characters 57 | WARNING | Line exceeds 80 characters; contains 209 characters 60 | WARNING | Line exceeds 80 characters; contains 175 characters 63 | WARNING | Line exceeds 80 characters; contains 122 characters 66 | WARNING | Line exceeds 80 characters; contains 102 characters 69 | WARNING | Line exceeds 80 characters; contains 148 characters 72 | WARNING | Line exceeds 80 characters; contains 168 characters 75 | WARNING | Line exceeds 80 characters; contains 100 characters 77 | WARNING | Line exceeds 80 characters; contains 148 characters 79 | WARNING | Line exceeds 80 characters; contains 176 characters ----------------------------------------------------------------------
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 10:19am 16 February 2024 - ๐ฎ๐ณIndia Yashaswi18
Hello, I checked out to the branch '3383179-fix-the-issue' and ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml festeva. Found no errors or warnings remaining. RTBC +1.