Fix the issues reported by phpcs

Above warnings are fixed.

I will review patch and will update the status once done.
Also, please try to follow the MR workflow for new issues.

I have checked and reviewed MR and it works perfectly for me.
Moving it to RTBC.

Created MR for this issue.
Please review.

Rather than calling the class "BrowsersyncConstants", please rename it to "BrowsersyncHelper" and remove the "final" keyword from the class declaration.

i'll work on this ..

Hi @elimw,

changes has been made. Please review.

+/**
+ * Block Token Constants.
+ */

That does not describe the class. Constants should not be capitalized, since it is not at the begin of a sentence.
I am not sure I would even call those constants Block Token constants, since they are used in the definition of the browsersync_snippet theme function.

Please make all changes to "Issue fork browsersync-3335994" rather than the old patch file method.

The PHP_CodeSniffer warnings/errors still to fix are listed by GitLab CI.

Fixed Line indented incorrectly for browsersync.module.

Hi @pray_12,

I applied MR!2 and confirmed that the issues found on the browsersync.module file by the phpcs are fixed.

However, I am still encountering some issues when I run phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

➜  browsersync git:(main) ✗ curl https://git.drupalcode.org/project/browsersync/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8165    0  8165    0     0  18933      0 --:--:-- --:--:-- --:--:-- 18944
patching file .gitlab-ci.yml
patching file browsersync.module
patching file src/BrowserSyncConstants.php
➜  browsersync git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml browsersync

FILE: /Users/interns/Demo-site/drupal-orgissue/web/modules/contrib/browsersync/browsersync.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 190ms; Memory: 10MB

➜  contrib git:(main) ✗

I will retain the status to Needs review so that others can confirm as well.

Thank you.

Hi @pray_12,

I apologize for my previous testing. I discovered that the warnings I encountered were because I installed the module via composer.

I reapplied MR!2, it was applied smoothly and fixed the phpcs issues.

➜  browsersync git:(3.0.0-beta2) curl https://git.drupalcode.org/project/browsersync/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8165    0  8165    0     0  27680      0 --:--:-- --:--:-- --:--:-- 27677
patching file .gitlab-ci.yml
patching file browsersync.module
patching file src/BrowserSyncConstants.php
➜  browsersync git:(3.0.0-beta2) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml browsersync
➜  contrib

Thank you.

There is no need to test a merge request locally, since GitLab CI reports PHP_CodeSniffer errors/warnings.