- Issue created by @samit.310@gmail.com
- ๐ฎ๐ณIndia sahilgidwani Jaipur
I will review patch and will update the status once done.
Also, please try to follow the MR workflow for new issues. - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 12:00pm 25 January 2023 - ๐ฎ๐ณIndia sahilgidwani Jaipur
I have checked and reviewed MR and it works perfectly for me.
Moving it to RTBC. - Assigned to Charchil Khandelwal
- Issue was unassigned.
- ๐ฎ๐ณIndia Charchil Khandelwal
Created MR for this issue.
Please review. - Status changed to Needs work
over 1 year ago 4:52am 20 February 2023 - ๐ฆ๐บAustralia elimw
Rather than calling the class "BrowsersyncConstants", please rename it to "BrowsersyncHelper" and remove the "final" keyword from the class declaration.
- Assigned to AditiVB
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:24am 2 March 2023 - ๐ฎ๐ณIndia samit.310@gmail.com
Hi @elimw,
changes has been made. Please review.
- Status changed to Needs work
over 1 year ago 5:07am 2 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+/**
+ * Block Token Constants.
+ */That does not describe the class. Constants should not be capitalized, since it is not at the begin of a sentence.
I am not sure I would even call those constants Block Token constants, since they are used in the definition of the browsersync_snippet theme function. - ๐ฆ๐บAustralia elimw
Please make all changes to "Issue fork browsersync-3335994" rather than the old patch file method.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- Status changed to Needs review
3 months ago 10:38am 14 March 2024 - ๐ฎ๐ณIndia Preethy_ray
pray_12 โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Preethy_ray
Fixed Line indented incorrectly for browsersync.module.
- ๐ต๐ญPhilippines cleavinjosh
Hi @pray_12,
I applied MR!2 and confirmed that the issues found on the browsersync.module file by the phpcs are fixed.
However, I am still encountering some issues when I run
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
โ browsersync git:(main) โ curl https://git.drupalcode.org/project/browsersync/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 8165 0 8165 0 0 18933 0 --:--:-- --:--:-- --:--:-- 18944 patching file .gitlab-ci.yml patching file browsersync.module patching file src/BrowserSyncConstants.php โ browsersync git:(main) โ .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml browsersync FILE: /Users/interns/Demo-site/drupal-orgissue/web/modules/contrib/browsersync/browsersync.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- Time: 190ms; Memory: 10MB โ contrib git:(main) โ
I will retain the status to Needs review so that others can confirm as well.
Thank you.
- Status changed to Needs work
about 1 month ago 3:52am 24 May 2024