- Issue created by @rassoni
- First commit to issue fork.
- Status changed to Active
almost 2 years ago 2:23pm 1 May 2023 - Assigned to arpitk
- Status changed to Needs work
almost 2 years ago 3:39pm 11 May 2023 - First commit to issue fork.
- Issue was unassigned.
- 🇮🇳India zkhan.aamir
Hi,
MR #8 applied successfully.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/content_sync (3.0.x) $ curl https://git.drupalcode.org/project/content_sync/-/merge_requests/9.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 151k 0 151k 0 0 319k 0 --:--:-- --:--:-- --:--:-- 320k patching file README.txt patching file content_sync.admin.inc patching file content_sync.install patching file content_sync.links.task.yml patching file content_sync.module patching file content_sync.routing.yml patching file includes/content_sync.theme.inc patching file src/Commands/ContentSyncCommands.php patching file src/Content/ContentDatabaseStorage.php patching file src/Content/ContentFileStorageFactory.php patching file src/Content/ContentStorageComparer.php patching file src/ContentSyncHelpManager.php patching file src/ContentSyncManager.php patching file src/ContentSyncManagerInterface.php patching file src/Controller/ContentController.php patching file src/Controller/ContentElementController.php patching file src/Controller/ContentHelpController.php patching file src/Controller/ContentLogController.php patching file src/DependencyResolver/ContentSyncResolverInterface.php patching file src/DependencyResolver/ExportQueueResolver.php patching file src/DependencyResolver/ImportQueueResolver.php patching file src/Element/ContentSyncMessage.php patching file src/Encoder/YamlEncoder.php patching file src/EventSubscriber/ContentSyncEvents.php patching file src/Exporter/ContentExporter.php patching file src/Exporter/ContentExporterInterface.php patching file src/Form/ContentExportForm.php patching file src/Form/ContentExportMultiple.php patching file src/Form/ContentExportTrait.php patching file src/Form/ContentImportForm.php patching file src/Form/ContentImportTrait.php patching file src/Form/ContentLogFilterForm.php patching file src/Form/ContentSettingsForm.php patching file src/Form/ContentSingleExportForm.php patching file src/Form/ContentSingleImportForm.php patching file src/Form/ContentSync.php patching file src/Importer/ContentImporter.php patching file src/Importer/ContentImporterInterface.php patching file src/Logger/ContentSyncLog.php patching file src/Normalizer/ContentEntityNormalizer.php patching file src/Normalizer/EntityReferenceFieldItemNormalizer.php patching file src/Normalizer/FileEntityNormalizer.php patching file src/Normalizer/ImageItemNormalizer.php patching file src/Normalizer/LinkItemNormalizer.php patching file src/Normalizer/ParagraphEntityNormalizer.php patching file src/Normalizer/PathAliasEntityNormalizer.php patching file src/Normalizer/TimestampItemNormalizer.php patching file src/Normalizer/UserEntityNormalizer.php patching file src/Plugin/Action/ExportNodes.php patching file src/Plugin/SyncNormalizerDecorator/IdsCleaner.php patching file src/Plugin/SyncNormalizerDecoratorBase.php patching file src/Plugin/SyncNormalizerDecoratorInterface.php patching file src/Plugin/SyncNormalizerDecoratorTrait.php patching file src/Utility/ContentSyncDialogHelper.php
Still there are remaining errors.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml content_sync/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Content\ContentFileStorageFactory.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | The @see url 'https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/constant/CONFIG_ACTIVE_DIRECTORY/8.9.x' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Content\ContentStorageComparer.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 53 | WARNING | Unused variable $key. -------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\ContentSyncManager.php -------------------------------------------------------------------------------------------------------- FOUND 25 ERRORS AND 1 WARNING AFFECTING 19 LINES -------------------------------------------------------------------------------------------------------- 57 | ERROR | Missing short description in doc comment 58 | ERROR | Description for the @return value is missing 64 | ERROR | Missing short description in doc comment 65 | ERROR | Description for the @return value is missing 71 | ERROR | Missing short description in doc comment 72 | ERROR | Missing parameter comment 72 | ERROR | Missing parameter type 73 | ERROR | Missing parameter comment 73 | ERROR | Missing parameter type 75 | ERROR | Description for the @return value is missing 84 | WARNING | Unused variable $uuid. 101 | ERROR | Missing short description in doc comment 101 | ERROR | Parameter $decoded_entities is not described in comment 101 | ERROR | Parameter $visited is not described in comment 102 | ERROR | Missing parameter comment 102 | ERROR | Missing parameter type 103 | ERROR | Missing parameter comment 103 | ERROR | Missing parameter type 105 | ERROR | Description for the @return value is missing 116 | ERROR | Missing short description in doc comment 117 | ERROR | Description for the @return value is missing 123 | ERROR | Missing short description in doc comment 124 | ERROR | Description for the @return value is missing 133 | ERROR | Missing parameter comment 133 | ERROR | Missing parameter type 135 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\ContentSyncManagerInterface.php ----------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES ----------------------------------------------------------------------------------------------------------------- 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 12 | ERROR | Missing short description in doc comment 13 | ERROR | Description for the @return value is missing 17 | ERROR | Missing short description in doc comment 18 | ERROR | Description for the @return value is missing 22 | ERROR | Missing short description in doc comment 23 | ERROR | Description for the @return value is missing 27 | ERROR | Missing short description in doc comment 28 | ERROR | Description for the @return value is missing ----------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Controller\ContentLogController.php --------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 228 | ERROR | Comment indentation error, expected only 1 spaces 315 | ERROR | Function return type is not void, but function is returning void here --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\DependencyResolver\ExportQueueResolver.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------- 59 | WARNING | Unused variable $ref_entity_type_id. 68 | WARNING | Unused variable $ref_entity_type_id. 76 | WARNING | Unused variable $bundle. 89 | ERROR | Missing parameter type 91 | ERROR | Missing parameter type ---------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\DependencyResolver\ImportQueueResolver.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------- 100 | WARNING | Unused variable $ref_entity_type_id. 128 | ERROR | Missing parameter type 130 | ERROR | Missing parameter type 146 | WARNING | Unused variable $uuid. 168 | ERROR | Missing parameter type ---------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Encoder\YamlEncoder.php ----------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 23 | ERROR | Missing member variable doc comment 32 | ERROR | Doc comment is empty 39 | ERROR | Doc comment is empty 46 | ERROR | Doc comment is empty 53 | ERROR | Doc comment is empty ----------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Exporter\ContentExporter.php -------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES -------------------------------------------------------------------------------------------------------------- 14 | ERROR | Missing member variable doc comment 16 | ERROR | Missing member variable doc comment 18 | ERROR | Missing member variable doc comment 64 | ERROR | Missing short description in doc comment 65 | ERROR | Description for the @return value is missing 71 | ERROR | Missing short description in doc comment 72 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Exporter\ContentExporterInterface.php ----------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------- 15 | ERROR | Missing parameter comment 16 | ERROR | Missing parameter comment 18 | ERROR | Description for the @return value is missing ----------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentExportForm.php ------------------------------------------------------------------------------------------------------------ FOUND 8 ERRORS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------ 21 | ERROR | Missing short description in doc comment 26 | ERROR | Missing short description in doc comment 31 | ERROR | Missing short description in doc comment 46 | ERROR | Doc comment is empty 108 | ERROR | Doc comment is empty 136 | ERROR | Missing short description in doc comment 143 | ERROR | Missing short description in doc comment 150 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentExportMultiple.php ---------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------- 38 | ERROR | Missing short description in doc comment 43 | ERROR | Missing short description in doc comment 48 | ERROR | Missing short description in doc comment 53 | ERROR | Missing member variable doc comment 62 | ERROR | Parameter $formats is not described in comment ---------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentExportTrait.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 26 ERRORS AND 4 WARNINGS AFFECTING 27 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | Missing short description in doc comment 22 | ERROR | Missing short description in doc comment 23 | ERROR | Missing parameter comment 23 | ERROR | Missing parameter type 25 | ERROR | Missing parameter type 40 | ERROR | Description for the @return value is missing 56 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines 58 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines 58 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines 80 | ERROR | Parameter $entities is not described in comment 83 | ERROR | Missing parameter type 85 | ERROR | Missing parameter comment 85 | ERROR | Missing parameter type 89 | ERROR | Arguments with default values must be at the end of the argument list 179 | WARNING | Unused variable $file. 183 | WARNING | Unused variable $cache. 215 | ERROR | Parameter $serializer_context is not described in comment 217 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 219 | ERROR | Missing parameter type 224 | ERROR | Public method name "ContentExportTrait::generateSiteUUIDFile" is not in lowerCamel format 246 | WARNING | Unused variable $file. 269 | WARNING | Line exceeds 80 characters; contains 90 characters 307 | ERROR | Doc comment is empty 317 | ERROR | Doc comment is empty 324 | ERROR | Missing short description in doc comment 325 | ERROR | Description for the @return value is missing 329 | ERROR | Missing short description in doc comment 330 | ERROR | Description for the @return value is missing 334 | ERROR | Missing short description in doc comment 335 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentImportForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 28 | ERROR | The array declaration extends to column 144 (the limit is 80). The array content should be split up over multiple lines 81 | ERROR | The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines 93 | ERROR | Invalid function name, expected empty_directory but found emptyDirectory -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentImportTrait.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 20 ERRORS AND 4 WARNINGS AFFECTING 18 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Missing short description in doc comment 13 | ERROR | Missing parameter comment 13 | ERROR | Missing parameter type 15 | ERROR | Missing parameter comment 15 | ERROR | Missing parameter type 17 | ERROR | Missing parameter type 22 | ERROR | Description for the @return value is missing 27 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 27 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines 28 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 28 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 40 | WARNING | Line exceeds 80 characters; contains 91 characters 42 | ERROR | Missing parameter comment 42 | ERROR | Missing parameter type 43 | ERROR | Missing parameter comment 47 | ERROR | Arguments with default values must be at the end of the argument list 74 | WARNING | Unused variable $cache. 100 | ERROR | Parameter $content_to_delete is not described in comment 101 | WARNING | Line exceeds 80 characters; contains 91 characters 103 | ERROR | Missing parameter comment 103 | ERROR | Missing parameter type 104 | ERROR | Missing parameter comment 108 | ERROR | Arguments with default values must be at the end of the argument list 151 | WARNING | Unused variable $cache. ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentSettingsForm.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty -------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentSingleExportForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 1 WARNING AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 33 | ERROR | Missing short description in doc comment 41 | ERROR | Missing parameter comment 43 | ERROR | Parameter tags must be grouped together in a doc comment 43 | ERROR | Missing parameter comment 45 | ERROR | Parameter tags must be grouped together in a doc comment 45 | ERROR | Missing parameter comment 119 | WARNING | Line exceeds 80 characters; contains 87 characters 151 | ERROR | The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentSingleImportForm.php ------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------ 17 | ERROR | Missing short description in doc comment 22 | ERROR | Missing short description in doc comment 35 | ERROR | Doc comment is empty ------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Form\ContentSync.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------ 43 | ERROR | Missing short description in doc comment 123 | WARNING | Unused variable $source_list. 224 | WARNING | Unused variable $collection. ------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Importer\ContentImporter.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 186 | ERROR | Missing parameter type -------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Importer\ContentImporterInterface.php ----------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Doc comment is empty 10 | ERROR | Missing short description in doc comment 11 | ERROR | Missing parameter comment 11 | ERROR | Missing parameter type 12 | ERROR | Missing parameter comment 12 | ERROR | Missing parameter type 13 | ERROR | Missing parameter comment 15 | ERROR | Description for the @return value is missing ----------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\ContentEntityNormalizer.php ------------------------------------------------------------------------------------------------------------------------ FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------ 20 | ERROR | Missing short description in doc comment 34 | ERROR | Missing parameter comment 108 | WARNING | Possible useless method overriding detected 112 | ERROR | Missing short description in doc comment 113 | ERROR | Missing parameter comment 113 | ERROR | Missing parameter type 114 | ERROR | Missing parameter comment 116 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\EntityReferenceFieldItemNormalizer.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 121 | WARNING | Line exceeds 80 characters; contains 178 characters ----------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\FileEntityNormalizer.php --------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------- 41 | ERROR | Parameter tags must be grouped together in a doc comment 41 | ERROR | Missing parameter comment 43 | ERROR | Parameter tags must be grouped together in a doc comment 43 | ERROR | Missing parameter comment 120 | WARNING | Line exceeds 80 characters; contains 81 characters 124 | WARNING | Line exceeds 80 characters; contains 128 characters --------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\ImageItemNormalizer.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty -------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\LinkItemNormalizer.php ------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------- 26 | WARNING | Line exceeds 80 characters; contains 91 characters 34 | ERROR | Missing short description in doc comment 39 | ERROR | Parameter $entity_type_manager is not described in comment 73 | WARNING | Line exceeds 80 characters; contains 81 characters 140 | WARNING | Line exceeds 80 characters; contains 178 characters ------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\ParagraphEntityNormalizer.php -------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------- 41 | ERROR | Missing parameter comment 42 | ERROR | Missing parameter comment -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Normalizer\PathAliasEntityNormalizer.php -------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------- 42 | ERROR | Missing parameter comment 43 | ERROR | Missing parameter comment 89 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Plugin\SyncNormalizerDecorator\IdsCleaner.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 10 LINES ------------------------------------------------------------------------------------------------------------------------------- 97 | ERROR | Missing parameter comment 98 | ERROR | Missing parameter comment 99 | ERROR | Missing parameter comment 99 | ERROR | Missing parameter type 100 | ERROR | Missing parameter comment 109 | ERROR | Missing parameter comment 109 | ERROR | Missing parameter type 113 | ERROR | Description for the @return value is missing 152 | ERROR | Missing parameter comment 153 | ERROR | Missing parameter comment 153 | ERROR | Missing parameter type 154 | ERROR | Missing parameter comment 156 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\content_sync\src\Plugin\SyncNormalizerDecoratorTrait.php ------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | Doc comment is empty 12 | ERROR | Doc comment is empty 28 | ERROR | Doc comment is empty 40 | ERROR | Doc comment is empty 52 | ERROR | Missing short description in doc comment 53 | ERROR | Description for the @return value is missing ------------------------------------------------------------------------------------------------------------------------- Time: 1.38 secs; Memory: 14MB
- Assigned to shruu_rao
Remaining issues
FILE: C:\content_sync\src\Content\ContentFileStorageFactory.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | The @see url 'https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/constant/CONFIG_ACTIVE_DIRECTORY/8.9.x' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\content_sync\src\Content\ContentStorageComparer.php ------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------- 53 | WARNING | Unused variable $key. ------------------------------------------------------------------------- FILE: C:\content_sync\src\ContentSyncManager.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 95 | WARNING | Unused variable $uuid. 113 | WARNING | Line exceeds 80 characters; contains 87 characters ---------------------------------------------------------------------- FILE: C:\content_sync\src\Controller\ContentLogController.php ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 315 | ERROR | Function return type is not void, but function is returning void here ------------------------------------------------------------------------------------- FILE: C:\content_sync\src\DependencyResolver\ExportQueueResolver.php --------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES --------------------------------------------------------------------------------- 59 | WARNING | Unused variable $ref_entity_type_id. 68 | WARNING | Unused variable $ref_entity_type_id. 76 | WARNING | Unused variable $bundle. --------------------------------------------------------------------------------- FILE: C:\content_sync\src\DependencyResolver\ImportQueueResolver.php --------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------- 100 | WARNING | Unused variable $ref_entity_type_id. 146 | WARNING | Unused variable $uuid. --------------------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentExportMultiple.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 73 | ERROR | Parameter $formats is not described in comment ---------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentExportTrait.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AND 4 WARNINGS AFFECTING 15 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 27 | ERROR | Missing parameter type 29 | ERROR | Missing parameter type 61 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines 63 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines 63 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines 88 | ERROR | Missing parameter type 90 | ERROR | Missing parameter type 92 | ERROR | Missing parameter type 97 | ERROR | Arguments with default values must be at the end of the argument list 187 | WARNING | Unused variable $file. 191 | WARNING | Unused variable $cache. 223 | ERROR | Parameter $serializer_context is not described in comment 226 | ERROR | Missing parameter type 231 | ERROR | Public method name "ContentExportTrait::generateSiteUUIDFile" is not in lowerCamel format 253 | WARNING | Unused variable $file. 276 | WARNING | Line exceeds 80 characters; contains 90 characters ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentImportForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 28 | ERROR | The array declaration extends to column 144 (the limit is 80). The array content should be split up over multiple lines 81 | ERROR | The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines 93 | ERROR | Invalid function name, expected empty_directory but found emptyDirectory -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentImportTrait.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 30 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 30 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines 31 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 31 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 43 | WARNING | Line exceeds 80 characters; contains 91 characters 52 | ERROR | Arguments with default values must be at the end of the argument list 79 | WARNING | Unused variable $cache. 106 | WARNING | Line exceeds 80 characters; contains 91 characters 115 | ERROR | Arguments with default values must be at the end of the argument list 158 | WARNING | Unused variable $cache. ---------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentSingleExportForm.php ----------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------- 122 | WARNING | Line exceeds 80 characters; contains 87 characters ----------------------------------------------------------------------- FILE: C:\content_sync\src\Form\ContentSync.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 125 | WARNING | Unused variable $source_list. 226 | WARNING | Unused variable $collection. ---------------------------------------------------------------------- FILE: C:\content_sync\src\Importer\ContentImporter.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 186 | ERROR | Missing parameter type ---------------------------------------------------------------------- FILE: C:\content_sync\src\Importer\ContentImporterInterface.php ---------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------- 13 | ERROR | Missing parameter type 15 | ERROR | Missing parameter type ---------------------------------------------------------------------------- FILE: C:\content_sync\src\Normalizer\ContentEntityNormalizer.php ----------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------- 111 | WARNING | Possible useless method overriding detected 118 | ERROR | Missing parameter type ----------------------------------------------------------------------------- FILE: C:\content_sync\src\Normalizer\EntityReferenceFieldItemNormalizer.php ---------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------- 121 | WARNING | Line exceeds 80 characters; contains 178 characters ---------------------------------------------------------------------------------------- FILE: C:\content_sync\src\Normalizer\FileEntityNormalizer.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 120 | WARNING | Line exceeds 80 characters; contains 81 characters 124 | WARNING | Line exceeds 80 characters; contains 128 characters -------------------------------------------------------------------------- FILE: C:\content_sync\src\Normalizer\LinkItemNormalizer.php ---------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------- 26 | WARNING | Line exceeds 80 characters; contains 91 characters 41 | ERROR | Parameter $entity_type_manager is not described in comment 75 | WARNING | Line exceeds 80 characters; contains 81 characters 142 | WARNING | Line exceeds 80 characters; contains 178 characters ---------------------------------------------------------------------------- FILE: C:\content_sync\src\Normalizer\PathAliasEntityNormalizer.php ------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------- 91 | WARNING | Line exceeds 80 characters; contains 81 characters -------------------------------------------------------------------------------
- Issue was unassigned.
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- 🇵🇭Philippines cleavinjosh
Hi @silvi.addweb,
I applied MR!9 and it was applied smoothly. However, I still encountered some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
.➜ content_sync git:(3.0.x) curl https://git.drupalcode.org/project/content_sync/-/merge_requests/9.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 182k 0 182k 0 0 393k 0 --:--:-- --:--:-- --:--:-- 393k patching file README.txt patching file content_sync.admin.inc patching file content_sync.install patching file content_sync.links.task.yml patching file content_sync.module patching file content_sync.routing.yml patching file includes/content_sync.theme.inc patching file js/content_sync.element.message.js patching file src/Commands/ContentSyncCommands.php patching file src/Content/ContentDatabaseStorage.php patching file src/Content/ContentFileStorageFactory.php patching file src/Content/ContentStorageComparer.php patching file src/ContentSyncHelpManager.php patching file src/ContentSyncManager.php patching file src/ContentSyncManagerInterface.php patching file src/Controller/ContentController.php patching file src/Controller/ContentElementController.php patching file src/Controller/ContentHelpController.php patching file src/Controller/ContentLogController.php patching file src/DependencyResolver/ContentSyncResolverInterface.php patching file src/DependencyResolver/ExportQueueResolver.php patching file src/DependencyResolver/ImportQueueResolver.php patching file src/Element/ContentSyncMessage.php patching file src/Encoder/YamlEncoder.php patching file src/EventSubscriber/ContentSyncEvents.php patching file src/Exporter/ContentExporter.php patching file src/Exporter/ContentExporterInterface.php patching file src/Form/ContentExportForm.php patching file src/Form/ContentExportMultiple.php patching file src/Form/ContentExportTrait.php patching file src/Form/ContentImportForm.php patching file src/Form/ContentImportTrait.php patching file src/Form/ContentLogFilterForm.php patching file src/Form/ContentSettingsForm.php patching file src/Form/ContentSingleExportForm.php patching file src/Form/ContentSingleImportForm.php patching file src/Form/ContentSync.php patching file src/Importer/ContentImporter.php patching file src/Importer/ContentImporterInterface.php patching file src/Logger/ContentSyncLog.php patching file src/Normalizer/ContentEntityNormalizer.php patching file src/Normalizer/EntityReferenceFieldItemNormalizer.php patching file src/Normalizer/FileEntityNormalizer.php patching file src/Normalizer/ImageItemNormalizer.php patching file src/Normalizer/LinkItemNormalizer.php patching file src/Normalizer/ParagraphEntityNormalizer.php patching file src/Normalizer/PathAliasEntityNormalizer.php patching file src/Normalizer/TimestampItemNormalizer.php patching file src/Normalizer/UserEntityNormalizer.php patching file src/Plugin/Action/ExportNodes.php patching file src/Plugin/SyncNormalizerDecorator/IdsCleaner.php patching file src/Plugin/SyncNormalizerDecoratorBase.php patching file src/Plugin/SyncNormalizerDecoratorInterface.php patching file src/Plugin/SyncNormalizerDecoratorManager.php patching file src/Plugin/SyncNormalizerDecoratorTrait.php patching file src/Utility/ContentSyncDialogHelper.php ➜ content_sync git:(3.0.x) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_sync FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Form/ContentImportTrait.php ----------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------- 49 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 52 | ERROR | Arguments with default values must be at the end of the argument list 80 | ERROR | Comment indentation error, expected only 1 spaces 114 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 117 | ERROR | Arguments with default values must be at the end of the argument list 160 | WARNING | Unused variable $cache. ----------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Form/ContentImportForm.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 103 | ERROR | Invalid function name, expected empty_directory but found emptyDirectory ---------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Form/ContentExportTrait.php ----------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------- 92 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 95 | ERROR | Arguments with default values must be at the end of the argument list 226 | ERROR | Public method name "ContentExportTrait::generateSiteUUIDFile" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Importer/ContentImporterInterface.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | Doc comment for parameter $entity_type_id does not match actual variable name $context --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Plugin/SyncNormalizerDecorator/IdsCleaner.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 81 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Content/ContentFileStorageFactory.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | The @see url 'https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/constant/CONFIG_ACTIVE_DIRECTORY/8.9.x' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Commands/ContentSyncCommands.php ---------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 265 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 375 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Normalizer/FileEntityNormalizer.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 50 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Normalizer/ContentEntityNormalizer.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------- 111 | WARNING | Possible useless method overriding detected 118 | ERROR | Missing parameter type ---------------------------------------------------------------------------------------------------------------------------- Time: 1.95 secs; Memory: 14MB ➜ contrib
Thank you.
- Status changed to Needs review
9 months ago 7:45am 18 July 2024 - 🇵🇭Philippines cleavinjosh
Hi,
I fixed some of the phpcs issues. These are the remaining issues:
➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_sync FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Form/ContentImportTrait.php ----------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------- 49 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 52 | ERROR | Arguments with default values must be at the end of the argument list 80 | ERROR | Comment indentation error, expected only 1 spaces 114 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 117 | ERROR | Arguments with default values must be at the end of the argument list 160 | WARNING | Unused variable $cache. ----------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Form/ContentExportTrait.php ----------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------- 92 | ERROR | Doc comment for parameter $serializer_context does not match actual variable name <undefined> 95 | ERROR | Arguments with default values must be at the end of the argument list 226 | ERROR | Public method name "ContentExportTrait::generateSiteUUIDFile" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Importer/ContentImporterInterface.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | Doc comment for parameter $entity_type_id does not match actual variable name $context --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Content/ContentFileStorageFactory.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 18 | WARNING | The @see url 'https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/constant/CONFIG_ACTIVE_DIRECTORY/8.9.x' does not match the standard: | | http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/content_sync/src/Normalizer/ContentEntityNormalizer.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------- 111 | WARNING | Possible useless method overriding detected 118 | ERROR | Missing parameter type ---------------------------------------------------------------------------------------------------------------------------- Time: 2.5 secs; Memory: 14MB ➜ contrib
Please review.
Thank you.